Re: [quicwg/base-drafts] Don't use bitmap frames to describe varint structures (#3115)

Mike Bishop <notifications@github.com> Wed, 23 October 2019 18:22 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 12F4A12090C for <quic-issues@ietfa.amsl.com>; Wed, 23 Oct 2019 11:22:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XDzVlye8wker for <quic-issues@ietfa.amsl.com>; Wed, 23 Oct 2019 11:22:50 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2F2FB1200E9 for <quic-issues@ietf.org>; Wed, 23 Oct 2019 11:22:50 -0700 (PDT)
Received: from github-lowworker-39b4a70.va3-iad.github.net (github-lowworker-39b4a70.va3-iad.github.net [10.48.16.66]) by smtp.github.com (Postfix) with ESMTP id 459D3660009 for <quic-issues@ietf.org>; Wed, 23 Oct 2019 11:22:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571854969; bh=l+7oMFOXvp9SfyQwyaJsyZP4l4wPOob55MARSOKzd20=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1K0L3mEV7ZLONefsCQ3RPnazZPEDbX9Ho3CcJzIORFs40HBl1upieY69L3pVRrYU+ FCxGIcvBBurZfWLaHFKCt6sMoIyZG/HzIjz7qKe03AsgGRVKz5lUmSd8sxK/d4Yb7q qoRswxsWFiSq+mH3EA20bR1qPUCUmil+FqnUUl6I=
Date: Wed, 23 Oct 2019 11:22:49 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYR4QB73RLYEQRF7SF3XXNQTEVBNHHB4UPZEI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3115/545574047@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3115@github.com>
References: <quicwg/base-drafts/issues/3115@github.com>
Subject: Re: [quicwg/base-drafts] Don't use bitmap frames to describe varint structures (#3115)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db09a7937105_1f0e3fc0a70cd9689086"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jvx1FXGpMUhT_x4Aefe1AjIqF_E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Oct 2019 18:22:52 -0000

It's a fair point that when our structures are no longer 32-bit-aligned, the graphics are somewhat misleading.  However, for many of the frames, they're still more useful as a mental model than a C struct style, at least for many readers.  We've adopted conventions to indicate variable-sized fields; if you see places those aren't used properly, please flag them.

We previously had a principle that we don't illustrate frames/objects that contain a single varint.  The "inconsistency" resulted in them being added.  Ultimately, this is a question of editorial style and input on what readers find useful.  Your feedback is welcome and will be considered.

(I'll also note that this seems to oppose the discussion about moving the transport params from TLS-style description language to wire-frames.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3115#issuecomment-545574047