Re: [quicwg/base-drafts] Proposed change to #1965 (#2212)

martinduke <notifications@github.com> Thu, 20 December 2018 04:19 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C40A5130F4C for <quic-issues@ietfa.amsl.com>; Wed, 19 Dec 2018 20:19:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.064
X-Spam-Level:
X-Spam-Status: No, score=-8.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LKrr73Npokx3 for <quic-issues@ietfa.amsl.com>; Wed, 19 Dec 2018 20:19:15 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EC50F130F1A for <quic-issues@ietf.org>; Wed, 19 Dec 2018 20:19:14 -0800 (PST)
Date: Wed, 19 Dec 2018 20:19:12 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545279552; bh=mFg+Nb+HHvvj9ClYhcgDjeLlzySSO9baf7DZd/eOEkw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=h2DmJXZOeBp5qHsH/xjPGxtvfMJGwA0AIE2hmQkjMhHr2cnhdjJ1Cf6NWXhBMKtcW cU6AOQaNs48TqZdbg+jtlWOMdhorQB4qbnobbRjVvUTFOosOPgQCJOUlDgIQCoT3EY O5iENCXwUT2Qy+Q3W8pTAFEIsCt4NO3A7Qqq+sRg=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3bc41f28330bd05015bba08e6313b8361242f0c692cf000000011832da4092a169ce176a63e1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2212/c448861209@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2212@github.com>
References: <quicwg/base-drafts/pull/2212@github.com>
Subject: Re: [quicwg/base-drafts] Proposed change to #1965 (#2212)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1b1840b8a14_54913f9a3e0d45b82447d5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lG1xJUJR6bln4chW05caLILUP14>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2018 04:19:17 -0000

Correction: I like the change that means that all retransmitted packets are declared lost first. However, your change reopens the deadlock condition that @ianswett was trying to fix. That is, PTO, retransmission, ack of original packet, PTO. In this case there really is absolutely nothing to send, and nothing to declare lost. My impression was that @ianswett's change would encourage you to send a PING or something. That seems to have been lost in this PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2212#issuecomment-448861209