Re: [quicwg/base-drafts] Clarify section on negotiating connection IDs (#3349)

Martin Thomson <notifications@github.com> Tue, 10 March 2020 23:27 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C29103A0928 for <quic-issues@ietfa.amsl.com>; Tue, 10 Mar 2020 16:27:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G1NO6l5xsm_B for <quic-issues@ietfa.amsl.com>; Tue, 10 Mar 2020 16:27:45 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EEF033A08B5 for <quic-issues@ietf.org>; Tue, 10 Mar 2020 16:27:44 -0700 (PDT)
Date: Tue, 10 Mar 2020 16:27:43 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583882863; bh=+NyMVovKfDsR7KuJ2Xrm5czhcIle1HmKQVtW8ZtLB2E=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=t/hdJUDp5Ge6l6JO6LRPn4RM+ekH+KYzrkckS5o4SiVGEwwT0N4BvYgi25/c3JnOs AbnVlcWHiGhebucZU0WDX3A4fQkQ27JJg11cJdUSvHJCxk2MmbKaF3iDDj46T6nyl+ XaKzZBEGxbswEbGCG4M70h21J+xc5tR2T6Ix58fc=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6HUSMMDU5XSU3C3KF4OQBW7EVBNHHCBTP6UY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3349/review/372386691@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3349@github.com>
References: <quicwg/base-drafts/pull/3349@github.com>
Subject: Re: [quicwg/base-drafts] Clarify section on negotiating connection IDs (#3349)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e68226fd8fa0_4b043f98018cd95c177878"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/n6KfIO0DLfc5g1ixcxz7_H3OJYI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Mar 2020 23:27:51 -0000

martinthomson approved this pull request.



>  
 When an Initial packet is sent by a client that has not previously received an
-Initial or Retry packet from the server, the client populates the DCID field
-with an unpredictable value.  This DCID MUST be at least 8 bytes in length.
-Until a packet is received from the server, the client MUST use the same DCID
-value on all packets in this connection. This DCID is used to determine packet
+Initial or Retry packet from the server, the client populates the Destination
+Connection ID field with an unpredictable value.  This Destination Connection ID

That is below.

> -producing different connection IDs.
-
-The connection ID can change over the lifetime of a connection, especially in
-response to connection migration ({{migration}}); see {{issue-cid}} for details.
+for subsequent packets, including all subsequent 0-RTT packets.  This means that
+a client might have to change the connection ID it sets in the Destination
+Connection ID field twice during connection establishment: once in response to a
+Retry, and once in response to an Initial packet from the server. Once a client
+has received an Initial packet from the server, it MUST discard any subsequent
+packet it receives with a different Source Connection ID.
+
+A client MUST change the Destination Connection ID it uses for sending packets
+in response to only the first received Initial or Retry packet.  A server MUST
+set the Destination Connection ID it uses for sending packets based on the first
+received Initial packet. Any further changes to the Destination Connection ID
+are are only permitted if the values are taken from any received

```suggestion
are only permitted if the values are taken from any received
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3349#pullrequestreview-372386691