Re: [quicwg/base-drafts] Be more specific when naming bits (#3089)

Lucas Pardue <notifications@github.com> Sun, 13 October 2019 10:57 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BABC912008C for <quic-issues@ietfa.amsl.com>; Sun, 13 Oct 2019 03:57:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UeflqLdGdwCq for <quic-issues@ietfa.amsl.com>; Sun, 13 Oct 2019 03:57:23 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D46AA12008B for <quic-issues@ietf.org>; Sun, 13 Oct 2019 03:57:22 -0700 (PDT)
Received: from github-lowworker-cde56e0.va3-iad.github.net (github-lowworker-cde56e0.va3-iad.github.net [10.48.25.52]) by smtp.github.com (Postfix) with ESMTP id 05114A003D for <quic-issues@ietf.org>; Sun, 13 Oct 2019 03:57:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1570964242; bh=udM2ham1zbgiRAYGa9cjQHpBxTiXth5L5Nfq8eW0XEU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=vnVU5HvWZ7Rxe76DzGGnnfNCj6ZIfq9VEm9+5cujt+kC3pIhe/EsEd73P1CRNdd5a 6UK8RT41kQjHcQHjF505f45rqzL7yd16oDxmC1kPYLrnU5R0qo9109dNjwqH5sKfaR GuVRCMsaaAW+Xd8GIySaJ92f+QlBkFXOuWv5FK2Q=
Date: Sun, 13 Oct 2019 03:57:21 -0700
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6ZTZPNFQSB2VKK3TN3WBB2DEVBNHHB4LNBAY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3089/review/301043507@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3089@github.com>
References: <quicwg/base-drafts/pull/3089@github.com>
Subject: Re: [quicwg/base-drafts] Be more specific when naming bits (#3089)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da30311e9cd7_74a83ff9f6acd96c169667"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/tD-bDSV58Jq6kSz1LkSntaYXe-k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Oct 2019 10:57:25 -0000

LPardue commented on this pull request.



> @@ -311,7 +311,7 @@ instructions received on the encoder stream.
 The decoder MUST emit header fields in the order their representations appear in
 the input header block.
 
-### Blocked Decoding
+### Blocked Decoding  {#blocked-decoding}

I think auto anchoring should mean this is not required (I.e. only need to define explicit links that differ from the section title)

> @@ -682,10 +682,10 @@ acknowledged as this instruction does not insert an entry.
 An encoder adds an entry to the dynamic table where the header field name
 matches the header field name of an entry stored in the static or the dynamic
 table using an instruction that starts with the '1' one-bit pattern.  The second
-(`S`) bit indicates whether the reference is to the static or dynamic table. The
+('T') bit indicates whether the reference is to the static or dynamic table. The

T seems odd to me because they both use a table. And then we have T=1 meaning that it's the static table.

Are we really so constrained that we can't assign a noun to bits?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3089#pullrequestreview-301043507