Re: [secdir] Secdir review of draft-ietf-mpls-tp-oam-id-mib-08

Tina TSOU <Tina.Tsou.Zouting@huawei.com> Mon, 07 September 2015 01:23 UTC

Return-Path: <Tina.Tsou.Zouting@huawei.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A2F9C1B384C; Sun, 6 Sep 2015 18:23:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.111
X-Spam-Level:
X-Spam-Status: No, score=-1.111 tagged_above=-999 required=5 tests=[BAYES_20=-0.001, HTML_MESSAGE=0.001, J_CHICKENPOX_35=0.6, J_CHICKENPOX_45=0.6, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4gPMl9wBz1YD; Sun, 6 Sep 2015 18:23:25 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F16721B2E85; Sun, 6 Sep 2015 18:23:23 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml403-hub.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CAX15990; Mon, 07 Sep 2015 01:23:22 +0000 (GMT)
Received: from SZXEML422-HUB.china.huawei.com (10.82.67.152) by lhreml403-hub.china.huawei.com (10.201.5.217) with Microsoft SMTP Server (TLS) id 14.3.235.1; Mon, 7 Sep 2015 02:23:21 +0100
Received: from szxeml557-mbs.china.huawei.com ([169.254.6.212]) by szxeml422-hub.china.huawei.com ([10.82.67.152]) with mapi id 14.03.0235.001; Mon, 7 Sep 2015 09:23:16 +0800
From: Tina TSOU <Tina.Tsou.Zouting@huawei.com>
To: Venkatesan Mahalingam <venkat.mahalingams@gmail.com>
Thread-Topic: Secdir review of draft-ietf-mpls-tp-oam-id-mib-08
Thread-Index: AQHQ5L/gEot3P+eKLk6oIdN2iw08Qp4oF68AgAAvEgCACAZHMA==
Date: Mon, 7 Sep 2015 01:23:15 +0000
Message-ID: <C0E0A32284495243BDE0AC8A066631A818DC324A@szxeml557-mbs.china.huawei.com>
References: <CADajj4bzDNqCzaJSjviVZm1nk8CrbUopzj0PrNNOUcK9SNG1ZA@mail.gmail.com> <C0E0A32284495243BDE0AC8A066631A818DAD4F1@szxeml557-mbs.china.huawei.com> <CA+UNA02oU2CvwNEFVKPUTydSSc30bCzR8FY=xVG1J1mCKYkCvQ@mail.gmail.com> <CA+UNA02fvNFqOOomZ8O9QnGGVMYSo=u0JvgxVsvoQC3Ci5KK5Q@mail.gmail.com>
In-Reply-To: <CA+UNA02fvNFqOOomZ8O9QnGGVMYSo=u0JvgxVsvoQC3Ci5KK5Q@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.66.87.91]
Content-Type: multipart/alternative; boundary="_000_C0E0A32284495243BDE0AC8A066631A818DC324Aszxeml557mbschi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <http://mailarchive.ietf.org/arch/msg/secdir/2MIVMk30W_prl4VwhU8YeV5U_OI>
Cc: "draft-ietf-mpls-tp-oam-id-mib.all@tools.ietf.org" <draft-ietf-mpls-tp-oam-id-mib.all@tools.ietf.org>, The IESG <iesg@ietf.org>, "secdir@ietf.org" <secdir@ietf.org>
Subject: Re: [secdir] Secdir review of draft-ietf-mpls-tp-oam-id-mib-08
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Sep 2015 01:23:28 -0000

Dear Venkat,

Thank you for your prompt reply.

I reviewed -09, it solves my previous comments.


Thank you,
Tina

From: Venkatesan Mahalingam [mailto:venkat.mahalingams@gmail.com]
Sent: Wednesday, September 02, 2015 2:47 PM
To: Tina TSOU
Cc: secdir@ietf.org; draft-ietf-mpls-tp-oam-id-mib.all@tools.ietf.org; The IESG
Subject: Re: Secdir review of draft-ietf-mpls-tp-oam-id-mib-08

Tina,

We have published the new version 09, please go through the diff, if you have any further comments, please let us know.

URL:            https://www.ietf.org/internet-drafts/draft-ietf-mpls-tp-oam-id-mib-09.txt
Status:         https://datatracker.ietf.org/doc/draft-ietf-mpls-tp-oam-id-mib/
Htmlized:       https://tools.ietf.org/html/draft-ietf-mpls-tp-oam-id-mib-09
Diff:           https://www.ietf.org/rfcdiff?url2=draft-ietf-mpls-tp-oam-id-mib-09

>>The title of this draft indicates mib for MPLS-TP OAM ID but in the body MPLS is used mostly and sometimes MPLS-TP appears, for example, both MPLS tunnels and MPLS-TP tunnels are mentioned. I'm not sure if they can be used >>interchangeable. Besides, I notice that the names for the objects all start with "mplsoamidxxx", which seems to address mib for MPLS OAM ID. Then it is not aligned with the title of this draft. A bit confused. Could the authors provide >>any clarification on this? A general suggestion is to make alignment throughout the document, including the title of the draft.

As Loa suggested, we have included MPLS-TP (as we do this work as part of MPLS-TP) in the title but this draft actually describes the managed object for both MPLS and MPLS-TP tunnel identifiers.


-Venkat.

On Tue, Sep 1, 2015 at 8:58 PM, Venkatesan Mahalingam <venkat.mahalingams@gmail.com<mailto:venkat.mahalingams@gmail.com>> wrote:
Thanks for your comments Tina, will address and publish the new version 09 soon.

-Venkat,

On Tue, Sep 1, 2015 at 7:09 AM, Tina TSOU <Tina.Tsou.Zouting@huawei.com<mailto:Tina.Tsou.Zouting@huawei.com>> wrote:
Dear all,

I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the security area directors. Document editors and WG chairs should treat these comments just like any other last call comments.
The document seems ready to go. I only found these minor nits:

The title of this draft indicates mib for MPLS-TP OAM ID but in the body MPLS is used mostly and sometimes MPLS-TP appears, for example, both MPLS tunnels and MPLS-TP tunnels are mentioned. I'm not sure if they can be used interchangeable. Besides, I notice that the names for the objects all start with "mplsoamidxxx", which seems to address mib for MPLS OAM ID. Then it is not aligned with the title of this draft. A bit confused. Could the authors provide any clarification on this? A general suggestion is to make alignment throughout the document, including the title of the draft.

* Abstract:

> it describes Operations, Administration, and Management (OAM)
> identifiers related managed objects for Multiprotocol Label Switching
> (MPLS) and MPLS based Transport Profile (TP).

I find this sentence hard to parse. Maybe s/related managed objects/related to managed objects/ ?


* Section 1, page 3:
> MPLS LSP(Label

There's a missing space.


* Section 5.1, page 4:

> The mplsOamIdMegTable is used to manage one or more Maintenance
> Entities (MEs) that belongs

s/belongs/belong/


* Section 6, copy&paste mistake

-- Source MEP id is derived from the IP compatible MPLS LSP
       mplsOamIdMeSinkMepIndex           = 0,

The description in the note should be sink MEP. There is already another line to describe source MEP.


* Page 15:

> BFD

This is the first and only instance of BFD. Please expand. (and maybe reference RFC5880)?


* Page 17:

"p2p" and "P2P" first used here. should probably be expanded.


Thank you,
Tina