Re: [secdir] Secdir review of draft-ietf-mpls-tp-oam-id-mib-08

Venkatesan Mahalingam <venkat.mahalingams@gmail.com> Wed, 02 September 2015 06:47 UTC

Return-Path: <venkat.mahalingams@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 513DF1B4AD1; Tue, 1 Sep 2015 23:47:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.799
X-Spam-Level:
X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, J_CHICKENPOX_35=0.6, J_CHICKENPOX_45=0.6, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vu_8WvPmyCF0; Tue, 1 Sep 2015 23:47:08 -0700 (PDT)
Received: from mail-lb0-x22b.google.com (mail-lb0-x22b.google.com [IPv6:2a00:1450:4010:c04::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3F0351B4AD5; Tue, 1 Sep 2015 23:47:08 -0700 (PDT)
Received: by lbbmp1 with SMTP id mp1so422200lbb.1; Tue, 01 Sep 2015 23:47:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=TU8c9mGLQ0pITCRG52VCTBPBaQzxe4SRLzQZyxpDHXM=; b=cNQUypfKCgAcqNpA32axFXLGKXEVt/RmB0GT4JLCwzaeKzMXOaXNNDH5btmqQHRXkh pBS1F34cbK2ZciIcRC2luXfxvbPJOQ8F6ID0CGV188QjOJoMz9baqXFyIt5Po1HFQNgq tjVSibZuApwUjZeH/TDfpD6Cyb+GXT0NGvctzR5WYFbSqexna5EwAjtij+INoEywN0G3 yoMiQsD1ZSMxPuYyNl3eoCsc6zRqRJpol8uV5n+gqdDhpVHVCy6A2hTljbT197tVIdTP oKnf2V0BBFwWdZKfepWiqOOpjbOf11Ljk/AaXkYxt+Yye6n1IK/LmtsZmxVU7ne7M+3E bUYg==
MIME-Version: 1.0
X-Received: by 10.152.8.233 with SMTP id u9mr15307334laa.8.1441176426558; Tue, 01 Sep 2015 23:47:06 -0700 (PDT)
Received: by 10.25.84.147 with HTTP; Tue, 1 Sep 2015 23:47:06 -0700 (PDT)
In-Reply-To: <CA+UNA02oU2CvwNEFVKPUTydSSc30bCzR8FY=xVG1J1mCKYkCvQ@mail.gmail.com>
References: <CADajj4bzDNqCzaJSjviVZm1nk8CrbUopzj0PrNNOUcK9SNG1ZA@mail.gmail.com> <C0E0A32284495243BDE0AC8A066631A818DAD4F1@szxeml557-mbs.china.huawei.com> <CA+UNA02oU2CvwNEFVKPUTydSSc30bCzR8FY=xVG1J1mCKYkCvQ@mail.gmail.com>
Date: Tue, 1 Sep 2015 23:47:06 -0700
Message-ID: <CA+UNA02fvNFqOOomZ8O9QnGGVMYSo=u0JvgxVsvoQC3Ci5KK5Q@mail.gmail.com>
From: Venkatesan Mahalingam <venkat.mahalingams@gmail.com>
To: Tina TSOU <Tina.Tsou.Zouting@huawei.com>
Content-Type: multipart/alternative; boundary=089e0158b77cf6c109051ebe081a
Archived-At: <http://mailarchive.ietf.org/arch/msg/secdir/YSqIRArGBRAwRd_O0KDAzbIpU8o>
X-Mailman-Approved-At: Wed, 02 Sep 2015 07:10:52 -0700
Cc: "draft-ietf-mpls-tp-oam-id-mib.all@tools.ietf.org" <draft-ietf-mpls-tp-oam-id-mib.all@tools.ietf.org>, The IESG <iesg@ietf.org>, "secdir@ietf.org" <secdir@ietf.org>
Subject: Re: [secdir] Secdir review of draft-ietf-mpls-tp-oam-id-mib-08
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Sep 2015 06:47:11 -0000

Tina,

We have published the new version 09, please go through the diff, if you
have any further comments, please let us know.

URL:
https://www.ietf.org/internet-drafts/draft-ietf-mpls-tp-oam-id-mib-09.txt
Status:
https://datatracker.ietf.org/doc/draft-ietf-mpls-tp-oam-id-mib/
Htmlized:       https://tools.ietf.org/html/draft-ietf-mpls-tp-oam-id-mib-09
Diff:
https://www.ietf.org/rfcdiff?url2=draft-ietf-mpls-tp-oam-id-mib-09

>>The title of this draft indicates mib for MPLS-TP OAM ID but in the body
MPLS is used mostly and sometimes MPLS-TP appears, for example, both MPLS
tunnels and MPLS-TP tunnels are mentioned. I'm not sure if they can be used
>>interchangeable. Besides, I notice that the names for the objects all
start with "mplsoamidxxx", which seems to address mib for MPLS OAM ID. Then
it is not aligned with the title of this draft. A bit confused. Could the
authors provide >>any clarification on this? A general suggestion is to
make alignment throughout the document, including the title of the draft.

As Loa suggested, we have included MPLS-TP (as we do this work as part of
MPLS-TP) in the title but this draft actually describes the managed object
for both MPLS and MPLS-TP tunnel identifiers.


-Venkat.

On Tue, Sep 1, 2015 at 8:58 PM, Venkatesan Mahalingam <
venkat.mahalingams@gmail.com> wrote:

> Thanks for your comments Tina, will address and publish the new version 09
> soon.
>
> -Venkat,
>
> On Tue, Sep 1, 2015 at 7:09 AM, Tina TSOU <Tina.Tsou.Zouting@huawei.com>
> wrote:
>
>> Dear all,
>>
>>
>>
>> I have reviewed this document as part of the security directorate's
>> ongoing effort to review all IETF documents being processed by the IESG.
>> These comments were written primarily for the benefit of the security area
>> directors. Document editors and WG chairs should treat these comments just
>> like any other last call comments.
>>
>> The document seems ready to go. I only found these minor nits:
>>
>>
>>
>> The title of this draft indicates mib for MPLS-TP OAM ID but in the body
>> MPLS is used mostly and sometimes MPLS-TP appears, for example, both MPLS
>> tunnels and MPLS-TP tunnels are mentioned. I'm not sure if they can be used
>> interchangeable. Besides, I notice that the names for the objects all start
>> with "mplsoamidxxx", which seems to address mib for MPLS OAM ID. Then it is
>> not aligned with the title of this draft. A bit confused. Could the authors
>> provide any clarification on this? A general suggestion is to make
>> alignment throughout the document, including the title of the draft.
>>
>>
>>
>> * Abstract:
>>
>>
>>
>> > it describes Operations, Administration, and Management (OAM)
>>
>> > identifiers related managed objects for Multiprotocol Label Switching
>>
>> > (MPLS) and MPLS based Transport Profile (TP).
>>
>>
>>
>> I find this sentence hard to parse. Maybe s/related managed
>> objects/related to managed objects/ ?
>>
>>
>>
>>
>>
>> * Section 1, page 3:
>>
>> > MPLS LSP(Label
>>
>>
>>
>> There's a missing space.
>>
>>
>>
>>
>>
>> * Section 5.1, page 4:
>>
>>
>>
>> > The mplsOamIdMegTable is used to manage one or more Maintenance
>>
>> > Entities (MEs) that belongs
>>
>>
>>
>> s/belongs/belong/
>>
>>
>>
>>
>>
>> * Section 6, copy&paste mistake
>>
>>
>>
>> -- Source MEP id is derived from the IP compatible MPLS LSP
>>
>>        mplsOamIdMeSinkMepIndex           = 0,
>>
>>
>>
>> The description in the note should be sink MEP. There is already another
>> line to describe source MEP.
>>
>>
>>
>>
>>
>> * Page 15:
>>
>>
>>
>> > BFD
>>
>>
>>
>> This is the first and only instance of BFD. Please expand. (and maybe
>> reference RFC5880)?
>>
>>
>>
>>
>>
>> * Page 17:
>>
>>
>>
>> "p2p" and "P2P" first used here. should probably be expanded.
>>
>>
>>
>>
>>
>> Thank you,
>>
>> Tina
>>
>>
>>
>
>