[tcpm] Opsdir telechat review of draft-ietf-tcpm-yang-tcp-07

Gyan Mishra via Datatracker <noreply@ietf.org> Mon, 04 July 2022 04:04 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: tcpm@ietf.org
Delivered-To: tcpm@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 8424DC14792F; Sun, 3 Jul 2022 21:04:36 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Gyan Mishra via Datatracker <noreply@ietf.org>
To: ops-dir@ietf.org
Cc: draft-ietf-tcpm-yang-tcp.all@ietf.org, last-call@ietf.org, tcpm@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 8.5.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <165690747653.9313.6940379164951428048@ietfa.amsl.com>
Reply-To: Gyan Mishra <hayabusagsm@gmail.com>
Date: Sun, 03 Jul 2022 21:04:36 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/870cb1yb9YQ_KPubBdhoxsYW784>
Subject: [tcpm] Opsdir telechat review of draft-ietf-tcpm-yang-tcp-07
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.39
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jul 2022 04:04:36 -0000

Reviewer: Gyan Mishra
Review result: Not Ready

This draft provides the Yang data mode for TCP.

The draft is well written and is almost ready publication.  I verified the FSM
state machine and all states are listed.

Minor issues:

Major issues:

I reviewed the TCP Yang data model and has a question related to the FSM state

Would it be possible to specify the TCP Header flags SYN, FIN, ACK, RST of BFD
FSM finite state machine Events and Transition.  I think this would be very
helpful for the TCP Yang model FSM state machine.  For each state you could
specify the flags set.


I think the TCP TCB (TCP Control Block) is missing in the Yang model. This is
important for troubleshooting TCP connection state.