Re: [tcpm] Genart last call review of draft-ietf-tcpm-rto-consider-14

Gorry Fairhurst <gorry@erg.abdn.ac.uk> Thu, 18 June 2020 11:01 UTC

Return-Path: <gorry@erg.abdn.ac.uk>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 466C73A0AF8; Thu, 18 Jun 2020 04:01:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a6-jG0J6eGCz; Thu, 18 Jun 2020 04:01:23 -0700 (PDT)
Received: from pegasus.erg.abdn.ac.uk (pegasus.erg.abdn.ac.uk [137.50.19.135]) by ietfa.amsl.com (Postfix) with ESMTP id EEC2E3A0AEB; Thu, 18 Jun 2020 04:01:22 -0700 (PDT)
Received: from GF-MacBook-Pro.lan (fgrpf.plus.com [212.159.18.54]) by pegasus.erg.abdn.ac.uk (Postfix) with ESMTPSA id 9421C1B00158; Thu, 18 Jun 2020 12:01:12 +0100 (BST)
To: Stewart Bryant <stewart.bryant@gmail.com>, Martin Duke <martin.h.duke@gmail.com>
Cc: tcpm <tcpm@ietf.org>, Review Team <gen-art@ietf.org>, Mark Allman <mallman@icir.org>, Last Call <last-call@ietf.org>, tom petch <daedulus@btconnect.com>, draft-ietf-tcpm-rto-consider.all@ietf.org
References: <159083802039.5596.14695350463305243689@ietfa.amsl.com> <FE0FA7D5-176D-4111-95DA-BD5424A24FE2@icir.org> <9A0DBDC4-2E39-4D09-80A6-FEDE72ED205B@gmail.com> <0F4B56B1-C8B9-493E-B3CD-AC2FBA9E62E4@icir.org> <CAM4esxTAMgUc4gfL-_Z2bjChjaHJGWL0F5VJn8Nd-=j2Zj5V_A@mail.gmail.com> <CAM4esxROPy-MX8_fu5inMvsKYVKR16jjTkAntt9qy=vfGM+mUg@mail.gmail.com> <EB54EC6A-418E-430F-91B1-C6832A606257@gmail.com>
From: Gorry Fairhurst <gorry@erg.abdn.ac.uk>
Message-ID: <522d1439-a24f-490a-6a5b-6544e024c969@erg.abdn.ac.uk>
Date: Thu, 18 Jun 2020 12:01:12 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <EB54EC6A-418E-430F-91B1-C6832A606257@gmail.com>
Content-Type: multipart/alternative; boundary="------------73D7C32980E67CE265FBA7DB"
Content-Language: en-GB
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/FyQKmB5o007MBiVWMcilTL6SsOQ>
Subject: Re: [tcpm] Genart last call review of draft-ietf-tcpm-rto-consider-14
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2020 11:01:28 -0000

See a few comments (marked GF) from the perspective of other transport 
RFCs, in case this helps you find text...

-------- Forwarded Message --------
Subject: 	Re: [tcpm] Genart last call review of 
draft-ietf-tcpm-rto-consider-14
Date: 	Thu, 18 Jun 2020 11:00:15 +0100
From: 	Stewart Bryant <stewart.bryant@gmail.com>
To: 	Martin Duke <martin.h.duke@gmail.com>
CC: 	tcpm <tcpm@ietf.org>, Review Team <gen-art@ietf.org>, Mark Allman 
<mallman@icir.org>, Last Call <last-call@ietf.org>, Stewart Bryant 
<stewart.bryant@gmail.com>, tom petch <daedulus@btconnect.com>, 
draft-ietf-tcpm-rto-consider.all@ietf.org





> On 17 Jun 2020, at 18:20, Martin Duke <martin.h.duke@gmail.com 
> <mailto:martin.h.duke@gmail.com>> wrote:
>
> Hi Stewart,
>
> If there are no further objections, I'm going to declare consensus.
>
> On Thu, Jun 11, 2020 at 1:45 PM Martin Duke <martin.h.duke@gmail.com 
> <mailto:martin.h.duke@gmail.com>> wrote:
>
>     Stewart,
>
>     do we need more cycles for this, or is draft-15 sufficient to
>     address your concerns?
>
>     On Mon, Jun 8, 2020 at 12:52 PM Mark Allman <mallman@icir.org
>     <mailto:mallman@icir.org>> wrote:
>
>
>         Hi Stewart, et.al <http://et.al/>.!
>
>         I just submitted a new version of rto-consider. Please ask the
>         datatracker for diffs between this and rev -14.  The highlights:
>
>           - The diffs with the last rev are here:
>         https://tools.ietf.org/rfcdiff?difftype=--hwdiff&url2=draft-ietf-tcpm-rto-consider-15.txt
>

*In the general case, delay across a network path depends not only on 
distance, but also a number of variable components such as the route and 
the level of buffering in intermediate devices.*


Its is more the contending/conflicting traffic rather than the 
buffering, or perhaps the time spent in queues, but “buffering” is a 
link a transport colloquial term.

GF: The word being sought might be "queueing" (I think that buffering is 
thought of as memory- and hence max queue).

*Since our wide-area network paths are best effort, packet loss is a 
regular occurrence. *


No the best effort Internet experiences this. There ate many well 
engineered WAN that do not.

What I am not seeing is clearer text that distinguishes between user 
traffic and “engineering” traffic that is used to make the network work, 
and between the end to end traffic and traffic within an AS that may be 
there for other purposes (high value service also offered by the 
provider) and WANs that are well engineered.

Perhaps we could include a clearer disclaimer regarding the 
non-best-effort-internet-end-to-end traffic?

You have some text on this down in section 2 but it is a bit buried.

Perhaps something early on of the form: This document is specially 
concerned with end to end behaviour over the best effort Internet. As 
noted in section 2 it may not me applicable to other types of WAN, or to 
the  traffic used in affecting the operation of the Internet itself.

GF: Actually, I do think a well-engineering WAN can be in scope of your 
spec. The two wrods I was expecting were "controlled environment" or 
"pre-provisioned" capacity, these might not see the same oath 
properties. A DC is typically regarded in transport specs as a 
"controlled environment".

*An exception to this rule is if an IETF standardized mechanism 
determines that a particular loss is due to a non-congestion event 
(e.g., packet corruption). *


That is a bit heavy. It should be “a protocol” there than an IETF 
standardarized mechanism. The IETF does not have a monopoly on 
pre-blessing protocols before they are deployed.

GF: Unsure myself what is needed - isn't this guidance for design of 
protocol mechansims?

>
>           - All small comments addressed.
>
>           - I think we all agree that this is not a one-size-fits-all
>             situation.  Rather, this document is meant to be a default
>         case.
>             So, the main action of this rev is to make that point more
>             clearly.  The first paragraph in the intro is new.  Also,
>         there
>             are some more words fleshing out the context more in
>         section 2.
>             In particular, more emphatically making the point that other
>             loss detectors are fine for specific cases.
>


As I note above from a routing and packet transport (as opposed to the 
transport layer) perspective I think we should more clearly recognise at 
the beginning the fact that this is for the worst case network, not for 
well engineered (WAN and DC) networks  and the mechanisms fundamental to 
the operation of the network itself.

>
>           - The first paragraph in the intro also makes clear we adopt the
>             loss == congestion model (as that is the conservative default,
>             not because it is always true).
>
>           - I made one other change that wasn't exactly called for, but
>             seems like an oversight.
>
>             Previously guideline (4) said loss MUST be taken as an
>             indication of congestion and some standard response
>         taken.  But,
>             this guideline has an explicit exception for cases where
>         we know
>             the loss was caused by some non-congestion event. 
>         Guideline (3)
>             says you MUST backoff.  But, it did not have this
>         exception for
>             cases where we can tell the cause.  But, I think based on the
>             spirit of (4), (3) should also have these words.  So, I added
>             them.
>

In some cases you cannot tell the cause, but it is more important to 
ignore the loss. OAM being a particularly good example.

>
>             Also, I swapped (3) and (4) because it seemed more natural in
>             re-reading to first think about taking congestion action and
>             then dealing with backoff.  I think the ordering is a small
>             thing, but folks can yell and I'll put it back if there is
>             angst.
>
>         Please take a look and let me know if this helps things along or
>         not.
>
>         allman
>

We are getting there, but I would ask that you take the transport hat 
off and look again from an infrastructure and packet transport perspective.

Best regards

Stewart


On 18/06/2020 11:00, Stewart Bryant wrote:
>
>
>> On 17 Jun 2020, at 18:20, Martin Duke <martin.h.duke@gmail.com 
>> <mailto:martin.h.duke@gmail.com>> wrote:
>>
>> Hi Stewart,
>>
>> If there are no further objections, I'm going to declare consensus.
>>
>> On Thu, Jun 11, 2020 at 1:45 PM Martin Duke <martin.h.duke@gmail.com 
>> <mailto:martin.h.duke@gmail.com>> wrote:
>>
>>     Stewart,
>>
>>     do we need more cycles for this, or is draft-15 sufficient to
>>     address your concerns?
>>
>>     On Mon, Jun 8, 2020 at 12:52 PM Mark Allman <mallman@icir.org
>>     <mailto:mallman@icir.org>> wrote:
>>
>>
>>         Hi Stewart, et.al <http://et.al/>.!
>>
>>         I just submitted a new version of rto-consider. Please ask the
>>         datatracker for diffs between this and rev -14.  The highlights:
>>
>>           - The diffs with the last rev are here:
>>         https://tools.ietf.org/rfcdiff?difftype=--hwdiff&url2=draft-ietf-tcpm-rto-consider-15.txt
>>
>
> *In the general case, delay across a network path depends not only on 
> distance, but also a number of variable components such as the route 
> and the level of buffering in intermediate devices.*
>
> Its is more the contending/conflicting traffic rather than the 
> buffering, or perhaps the time spent in queues, but “buffering” is a 
> link a transport colloquial term.
>
>
> *Since our wide-area network paths are best effort, packet loss is a 
> regular occurrence. *
>
> No the best effort Internet experiences this. There ate many well 
> engineered WAN that do not.
>
> What I am not seeing is clearer text that distinguishes between user 
> traffic and “engineering” traffic that is used to make the network 
> work, and between the end to end traffic and traffic within an AS that 
> may be there for other purposes (high value service also offered by 
> the provider) and WANs that are well engineered.
>
> Perhaps we could include a clearer disclaimer regarding the 
> non-best-effort-internet-end-to-end traffic?
>
> You have some text on this down in section 2 but it is a bit buried.
>
> Perhaps something early on of the form: This document is specially 
> concerned with end to end behaviour over the best effort Internet. As 
> noted in section 2 it may not me applicable to other types of WAN, or 
> to the  traffic used in affecting the operation of the Internet itself.
>
>
> *An exception to this rule is if an IETF standardized mechanism 
> determines that a particular loss is due to a non-congestion event 
> (e.g., packet corruption). *
>
> That is a bit heavy. It should be “a protocol” there than an IETF 
> standardarized mechanism. The IETF does not have a monopoly on 
> pre-blessing protocols before they are deployed.
>
>
>
>>
>>           - All small comments addressed.
>>
>>           - I think we all agree that this is not a one-size-fits-all
>>             situation.  Rather, this document is meant to be a
>>         default case.
>>             So, the main action of this rev is to make that point more
>>             clearly.  The first paragraph in the intro is new.  Also,
>>         there
>>             are some more words fleshing out the context more in
>>         section 2.
>>             In particular, more emphatically making the point that other
>>             loss detectors are fine for specific cases.
>>
>
>
> As I note above from a routing and packet transport (as opposed to the 
> transport layer) perspective I think we should more clearly recognise 
> at the beginning the fact that this is for the worst case network, not 
> for well engineered (WAN and DC) networks  and the mechanisms 
> fundamental to the operation of the network itself.
>
>>
>>           - The first paragraph in the intro also makes clear we
>>         adopt the
>>             loss == congestion model (as that is the conservative
>>         default,
>>             not because it is always true).
>>
>>           - I made one other change that wasn't exactly called for, but
>>             seems like an oversight.
>>
>>             Previously guideline (4) said loss MUST be taken as an
>>             indication of congestion and some standard response
>>         taken.  But,
>>             this guideline has an explicit exception for cases where
>>         we know
>>             the loss was caused by some non-congestion event. 
>>         Guideline (3)
>>             says you MUST backoff.  But, it did not have this
>>         exception for
>>             cases where we can tell the cause.  But, I think based on the
>>             spirit of (4), (3) should also have these words.  So, I added
>>             them.
>>
>
> In some cases you cannot tell the cause, but it is more important to 
> ignore the loss. OAM being a particularly good example.
>
>>
>>             Also, I swapped (3) and (4) because it seemed more natural in
>>             re-reading to first think about taking congestion action and
>>             then dealing with backoff.  I think the ordering is a small
>>             thing, but folks can yell and I'll put it back if there is
>>             angst.
>>
>>         Please take a look and let me know if this helps things along or
>>         not.
>>
>>         allman
>>
>
> We are getting there, but I would ask that you take the transport hat 
> off and look again from an infrastructure and packet transport 
> perspective.
>
> Best regards
>
> Stewart
>
>
>
> _______________________________________________
> tcpm mailing list
> tcpm@ietf.org
> https://www.ietf.org/mailman/listinfo/tcpm