Re: [tcpm] Genart last call review of draft-ietf-tcpm-rto-consider-14

Stewart Bryant <stewart.bryant@gmail.com> Wed, 17 June 2020 17:46 UTC

Return-Path: <stewart.bryant@gmail.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4958D3A096B; Wed, 17 Jun 2020 10:46:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.997
X-Spam-Level:
X-Spam-Status: No, score=-1.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, MIME_HTML_ONLY=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ReDO1ixoCUZP; Wed, 17 Jun 2020 10:46:23 -0700 (PDT)
Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5ECF73A0933; Wed, 17 Jun 2020 10:46:23 -0700 (PDT)
Received: by mail-wm1-x329.google.com with SMTP id t194so2936767wmt.4; Wed, 17 Jun 2020 10:46:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=UIhNOEHf/ZVwKI9vq2wTIGJcA+JHbHdU34ZVRdSKVOs=; b=cRgJc76qvnJrURlUg3Mv4/wLFjUg/AAr3QAVlQI6TgJu1zGn/WI9UkcT5lmmJ2c1Uc SnNlsTxZotBosa57MzC9ZxAAEiyqU0MyDVrDCkvhv46ofiApfaGWKbMcXnEbuq8B7Twy BMNJ+Itp2+cRL5nRphdnSUig5lbeu5WUp4jS3ZW3Yl/dw9iUozgJo1F31wF0lB0uQv9O I77FYKhJyhV/4WPDrtXMKGZ5JIl1uMfpKr3EU0GmBO3WIyp3ivCMvZlLma08kE10xysS 4oxPvHF5H1qME0oHTBAZnCXXFczwnryyZTtwC1+sFBgdV95yp+Ie+RWoQhoAF7acFYxl pKig==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=UIhNOEHf/ZVwKI9vq2wTIGJcA+JHbHdU34ZVRdSKVOs=; b=WgonED5/ABVrA0DQLq0+g9n7nVTc2FZpZHTvlAqayrZNwZAJbMreqPuYW7QyhI14Jy 8I7eaRDcwt7+cIOE5TZXe93aX7Uc0i+mLjEiAx8AXtCpdfIi3ToaENUaaAyGZ1ivZBWS 5cJIR62x/Cmpwwx+XSolKjLOS9kPg08eqhpn/eAN5WJjxCRQkOspT5fVIBJdrX44gU71 IXxjYTqAm0Bsb/j10HUGSK5WTFJy+98f5cdmGiDjXxlGg7DUkspT1Affhjachdpt1M0t 9GrCQtxa/z3Lk0IBFSZ+6/ZeRcRduWp8OhgGBVJOFetY2ZpHhN6JZy4zZC1FrbDBZEug nJlQ==
X-Gm-Message-State: AOAM531YxP20k4CENgZI8VTyRpOsuBp4UgASCsZYGo+hXBKgDKtVHVeT 8pYd4H1P4XTRXLgtkhuV9Cs=
X-Google-Smtp-Source: ABdhPJzRlOEhcEOHvmdfPjSufK6bHHC5GU4tqoj+YkazkAqeunpDhHB0+N3DVyUfIudfyfd5NZUeNw==
X-Received: by 2002:a7b:c7d8:: with SMTP id z24mr9353744wmk.28.1592415981693; Wed, 17 Jun 2020 10:46:21 -0700 (PDT)
Received: from appleton.fritz.box ([62.3.64.16]) by smtp.gmail.com with ESMTPSA id n7sm341613wrx.82.2020.06.17.10.46.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jun 2020 10:46:20 -0700 (PDT)
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Content-Type: text/html; charset="us-ascii"
X-Apple-Auto-Saved: 1
X-Apple-Mail-Remote-Attachments: YES
From: Stewart Bryant <stewart.bryant@gmail.com>
X-Apple-Base-Url: x-msg://20/
In-Reply-To: <CAM4esxROPy-MX8_fu5inMvsKYVKR16jjTkAntt9qy=vfGM+mUg@mail.gmail.com>
X-Apple-Windows-Friendly: 1
Date: Wed, 17 Jun 2020 18:46:08 +0100
Cc: Stewart Bryant <stewart.bryant@gmail.com>, Mark Allman <mallman@icir.org>, Review Team <gen-art@ietf.org>, tcpm <tcpm@ietf.org>, Last Call <last-call@ietf.org>, draft-ietf-tcpm-rto-consider.all@ietf.org, tom petch <daedulus@btconnect.com>
X-Apple-Mail-Signature: SKIP_SIGNATURE
Content-Transfer-Encoding: quoted-printable
Message-Id: <3D7ADB34-2D66-4AA2-9F03-77CB688B1EB4@gmail.com>
References: <159083802039.5596.14695350463305243689@ietfa.amsl.com> <FE0FA7D5-176D-4111-95DA-BD5424A24FE2@icir.org> <9A0DBDC4-2E39-4D09-80A6-FEDE72ED205B@gmail.com> <0F4B56B1-C8B9-493E-B3CD-AC2FBA9E62E4@icir.org> <CAM4esxTAMgUc4gfL-_Z2bjChjaHJGWL0F5VJn8Nd-=j2Zj5V_A@mail.gmail.com> <CAM4esxROPy-MX8_fu5inMvsKYVKR16jjTkAntt9qy=vfGM+mUg@mail.gmail.com>
X-Uniform-Type-Identifier: com.apple.mail-draft
To: Martin Duke <martin.h.duke@gmail.com>
X-Mailer: Apple Mail (2.3608.80.23.2.2)
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/YyMaC0-y70SJGWKNElaJCWFwmKY>
Subject: Re: [tcpm] Genart last call review of draft-ietf-tcpm-rto-consider-14
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jun 2020 17:46:29 -0000

Please give me until tomorrow and I will take a look.

Life has been a bit busy here,

Stewart

On 17 Jun 2020, at 18:20, Martin Duke <martin.h.duke@gmail.com> wrote:

Hi Stewart,

If there are no further objections, I'm going to declare consensus.

On Thu, Jun 11, 2020 at 1:45 PM Martin Duke <martin.h.duke@gmail.com> wrote:
Stewart,

do we need more cycles for this, or is draft-15 sufficient to address your concerns?

On Mon, Jun 8, 2020 at 12:52 PM Mark Allman <mallman@icir.org> wrote:

Hi Stewart, http://et.al/" rel="noreferrer nofollow" target="_blank" class="">et.al.!

I just submitted a new version of rto-consider.  Please ask the
datatracker for diffs between this and rev -14.  The highlights:

  - The diffs with the last rev are here: https://tools.ietf.org/rfcdiff?difftype=--hwdiff&url2=draft-ietf-tcpm-rto-consider-15.txt" rel="noreferrer nofollow" target="_blank" class="">https://tools.ietf.org/rfcdiff?difftype=--hwdiff&url2=draft-ietf-tcpm-rto-consider-15.txt

  - All small comments addressed.

  - I think we all agree that this is not a one-size-fits-all
    situation.  Rather, this document is meant to be a default case.
    So, the main action of this rev is to make that point more
    clearly.  The first paragraph in the intro is new.  Also, there
    are some more words fleshing out the context more in section 2.
    In particular, more emphatically making the point that other
    loss detectors are fine for specific cases.

  - The first paragraph in the intro also makes clear we adopt the
    loss == congestion model (as that is the conservative default,
    not because it is always true).

  - I made one other change that wasn't exactly called for, but
    seems like an oversight.

    Previously guideline (4) said loss MUST be taken as an
    indication of congestion and some standard response taken.  But,
    this guideline has an explicit exception for cases where we know
    the loss was caused by some non-congestion event.  Guideline (3)
    says you MUST backoff.  But, it did not have this exception for
    cases where we can tell the cause.  But, I think based on the
    spirit of (4), (3) should also have these words.  So, I added
    them.

    Also, I swapped (3) and (4) because it seemed more natural in
    re-reading to first think about taking congestion action and
    then dealing with backoff.  I think the ordering is a small
    thing, but folks can yell and I'll put it back if there is
    angst.

Please take a look and let me know if this helps things along or
not.

allman