Re: [bess] AD Review of draft-ietf-bess-evpn-vpws-07

"Shah, Himanshu" <hshah@ciena.com> Fri, 24 February 2017 17:31 UTC

Return-Path: <hshah@ciena.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AC6B312943D; Fri, 24 Feb 2017 09:31:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.921
X-Spam-Level:
X-Spam-Status: No, score=-1.921 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cienacorp.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EKYTZcWY2jy2; Fri, 24 Feb 2017 09:31:06 -0800 (PST)
Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0044.outbound.protection.outlook.com [104.47.33.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A71C4129424; Fri, 24 Feb 2017 09:31:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cienacorp.onmicrosoft.com; s=selector1-ciena-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NcjpgvpzhV41qsEzBEsZrkJF2vqlqS6cNGrbNtBjNtk=; b=dy/DPxnfMOHHJrEPLpLmrdotOXLOdUx08bJqqvFYtnjlRu1LMiesUM2HEOlpemQbYoMIM0uluULnJlvHhx91R3EwROHTwhDoVPbbQpQ1OcDw8EEBV4oE5ThFL8KvWbtmT9WVPiV7U1NRjVdymYeJuurvrS+l0AzqXxSUJNoJjyU=
Received: from DM5PR04MB0234.namprd04.prod.outlook.com (10.168.234.135) by DM5PR04MB0237.namprd04.prod.outlook.com (10.168.234.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.919.13; Fri, 24 Feb 2017 17:31:01 +0000
Received: from DM5PR04MB0234.namprd04.prod.outlook.com ([10.168.234.135]) by DM5PR04MB0234.namprd04.prod.outlook.com ([10.168.234.135]) with mapi id 15.01.0919.018; Fri, 24 Feb 2017 17:31:01 +0000
From: "Shah, Himanshu" <hshah@ciena.com>
To: "Alvaro Retana (aretana)" <aretana@cisco.com>, Sami Boutros <sboutros@vmware.com>, "draft-ietf-bess-evpn-vpws@ietf.org" <draft-ietf-bess-evpn-vpws@ietf.org>
Thread-Topic: [bess] AD Review of draft-ietf-bess-evpn-vpws-07
Thread-Index: AQHSjrENeHDnPiSdYEOjkNnPB7FdAaF4FlMA
Date: Fri, 24 Feb 2017 17:31:01 +0000
Message-ID: <EB4BD3E8-E5CF-4285-8ABB-2C422D883F1A@ciena.com>
References: <7BA49247-B24B-42FC-AAD8-85620F04E648@cisco.com>
In-Reply-To: <7BA49247-B24B-42FC-AAD8-85620F04E648@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.1e.0.170107
authentication-results: spf=none (sender IP is ) smtp.mailfrom=hshah@ciena.com;
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [63.80.42.132]
x-ms-office365-filtering-correlation-id: d0703ae5-0227-4b32-324e-08d45cdae72e
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR04MB0237;
x-microsoft-exchange-diagnostics: 1; DM5PR04MB0237; 7:Qd5keUKiF8wBZvut7SdgaXOZHpUAuOlEUZ1K7QmaXfKGREeCQ0Pg80gmW7AAIYfMvfZawMbsd30M26m+/fimVf6guc4E8ffpuOIoCK8sjaE0DTAby3eYOzMOTj1LfPiGrjUkZdz9MXBx//UwvDJiK0eRi68IvuVIMhSxec74OlUA9AemfucsEWBkm97aK1G4WY1YHKczweg1rv8SeWt1zLUWnSKbRYNTwgftIiVGsvSOEkWL4NN+YrJQ+DkfU70qQXIJ/+iSK5X8cawG96qwPPqqAYoexJ7A0tvB9o0Iz6P/YTPA8kQPxTKZ6edXIqDD/nn0stMqIgutvSpiJhldjQ==
x-microsoft-antispam-prvs: <DM5PR04MB02372CAE01241C4A8BEB3A36AF520@DM5PR04MB0237.namprd04.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(61668805478150)(138986009662008)(95692535739014)(21748063052155);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123555025)(20161123560025)(20161123558025)(20161123564025)(20161123562025)(6072148); SRVR:DM5PR04MB0237; BCL:0; PCL:0; RULEID:; SRVR:DM5PR04MB0237;
x-forefront-prvs: 0228DDDDD7
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(7916002)(39450400003)(189002)(377454003)(199003)(38730400002)(76176999)(53546006)(6246003)(106356001)(105586002)(106116001)(122556002)(50986999)(66066001)(33656002)(54356999)(101416001)(2950100002)(5660300001)(2900100001)(92566002)(36756003)(86362001)(230783001)(77096006)(99286003)(6506006)(236005)(6512007)(54906002)(229853002)(6436002)(6306002)(6486002)(606005)(54896002)(53936002)(8936002)(8676002)(81166006)(7906003)(81156014)(3660700001)(97736004)(4001350100001)(3280700002)(68736007)(82746002)(8666007)(25786008)(7736002)(3846002)(6116002)(102836003)(189998001)(5890100001)(2501003)(83716003)(2906002)(83506001)(4326007)(104396002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR04MB0237; H:DM5PR04MB0234.namprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en;
received-spf: None (protection.outlook.com: ciena.com does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_EB4BD3E8E5CF42858ABB2C422D883F1Acienacom_"
MIME-Version: 1.0
X-OriginatorOrg: ciena.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2017 17:31:01.5941 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 457a2b01-0019-42ba-a449-45f99e96b60a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB0237
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/gN-d4c3a0pPz-KhYZ5NwyLDxBHo>
Cc: Jeffrey Zhang <zzhang@juniper.net>, "bess-chairs@ietf.org" <bess-chairs@ietf.org>, "bess@ietf.org" <bess@ietf.org>
Subject: Re: [bess] AD Review of draft-ietf-bess-evpn-vpws-07
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Feb 2017 17:31:09 -0000

Hi Sami –

Some more comments for your consideration (based on -09- version) –
Many of the followings are either clarifications related or editorial.

1-

Overall comment : the draft uses long sentences, short sentences are more
favored (at least that is the feedback I used to get for my drafts).

For example:
--- original text --
Unlike EVPN where Ethernet Tag ID in EVPN routes are set to zero for
   Port-based, vlan-based, and vlan-bundle interface mode and it is set
   to non-zero Ethernet tag ID for vlan-aware bundle mode, in EVPN-VPWS,
   for all the four interface modes, Ethernet tag ID in the Ethernet A-D
   route MUST be set to a non-zero value in all the service interface
   types.
----
This could be written as –

Ethernet tag ID in Ethernet A-D route MUST be set to a non-zero value
irrespective of the service interface types. This is a deviation from
what is expected for EVPN. In EVPN, Ethernet Tag ID in EVPN routes are
set to zero for Port-based, vlan-based and vlan-bundle interface mode
while non-zero Ethernet tag ID only for vlan-aware bundle mode.
----

2-

In section 2.1

Original text ---

If the VLAN is represented by different VIDs on different PEs.
(note there should not be a period here)
(e.g., a different VID per Ethernet segment per PE), then each PE needs to
perform VID translation for frames destined to its Ethernet segment.

Comment ---

This particular paragraph is somewhat confusing. The confusing part is
That text seems to indicate that multiple PEs connected to an ES may
see same VLAN as different VID (which I believe is not true). For
example, PE members PE1 and PE2 of same ESx, may see VID 100 for PE1
but 101 for PE2. I believe what you are trying to convey is PEs on
local ES and PEs on remote ES may have different VIDs.

It can be clarified as –

If the VLAN is represented by different VIDs on local PEs (connected
to local ES) and remote PEs (connected to remote ES), then each PE
needs to perform VID translation for frames destined to its Ethernet segment.

---
3- editorial

Original text for page 8 –

A remote PE SHOULD receive P=1 from only one Primary PE and a B-1 from only one Backup PE.

Comment –
B=1


4- clarification

original text –

This allows an ingress PE to perform flow-based load-balancing
of traffic flows to all of the PEs attached to that ES.



Comment --

In multi-homed All-active configuration, this allows an ingress PE to perform
Flow-based load-balancing of traffic flows to all the PEs attached to that ES.

(I am assuming that in VPWS, single active multi-homing, there is load-balancing
from remote to local multi-homed PEs – Right??)

--

Thanks,
Himanshu

From: BESS <bess-bounces@ietf.org> on behalf of Alvaro Retana <aretana@cisco.com>
Date: Friday, February 24, 2017 at 10:17 AM
To: Sami Boutros <sboutros@vmware.com>, "draft-ietf-bess-evpn-vpws@ietf.org" <draft-ietf-bess-evpn-vpws@ietf.org>
Cc: Jeffrey Zhang <zzhang@juniper.net>, "bess-chairs@ietf.org" <bess-chairs@ietf.org>, "bess@ietf.org" <bess@ietf.org>
Subject: Re: [bess] AD Review of draft-ietf-bess-evpn-vpws-07

One more thing…you’re missing the reference to RFC5226.

Thanks!

Alvaro.

_______________________________________________
BESS mailing list
BESS@ietf.org<mailto:BESS@ietf.org>
https://www.ietf.org/mailman/listinfo/bess