Re: [Detnet] Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14

Don Fedyk <dfedyk@labn.net> Wed, 05 January 2022 20:04 UTC

Return-Path: <dfedyk@labn.net>
X-Original-To: detnet@ietfa.amsl.com
Delivered-To: detnet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8F25C3A044D; Wed, 5 Jan 2022 12:04:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=labn.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Qlw3ld2QmHCA; Wed, 5 Jan 2022 12:04:14 -0800 (PST)
Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2126.outbound.protection.outlook.com [40.107.93.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 747C13A04BC; Wed, 5 Jan 2022 12:04:13 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aEOEshX/SP6EsBLpjPnOHiq+1c5jE1JNVat8aaLjvtEQnjLsKC9iOLXPwprET2RqxwBsovnIevbQwyC38b1lZUYmww9md6IWAWqTF/CYmKfZpej3rTlMIFTR+0KTd1pYw/OV8JRZAkoU8AXa1G9SiiMhYgzIVLPOIeK7CfCHOYc2yGtvDcmlSR7x1KHI4TcZ/t/BJZDYOFV5LwRa478yktL6XFYnfoynaE6NhoPO4wr4ADTsP4OPhadokVtrlCKbOIPkXxR9KvsGMA1sxSjTxzEMPm8l3DRU0NqlmTwvu9PiSgtSDwbNCy87JVatYmNw95EKq14Is+dtpE5+tTsqIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DUW2WS/fDSfApdawgCXgRwBNM6OWEcIF+R9r3n9OwlA=; b=f8c7NxFOesqf/mFZuo5N7De6xihVSUEznch2h25D69ObFPD6hHWtOmWveYoyP9WpxuTA8GlV5dimBPGHuOKmeWpL4tYYmaOn3Zjnpw+wuMz/9dxZwGtVLqI2aHd9sA/Wi7VlAWRunmp246V6Z4IO2SRhceXPexddIojs94P2Ns9gNvRaryEpamz1dOd4I70uLSrr45/U/qt0UzPDyQuDWs/cQjhWOBXE82ehm/QTTntLapNJG8O4DCS18zQHprTulK/jXFZLJk9IgsFaPRHi2i02AWSbqXQpqHkbQtzlfYlXAjBmrSfcaX4Qx03bJCOxa9VKT7m42+nh0J0tm8r9Yw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labn.net; dmarc=pass action=none header.from=labn.net; dkim=pass header.d=labn.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labn.onmicrosoft.com; s=selector2-labn-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DUW2WS/fDSfApdawgCXgRwBNM6OWEcIF+R9r3n9OwlA=; b=bclL4gW8x74pyliS2fTQegu5rBs9KSGka96QwzqIIXJ1ikMae+3k6KJrks39QYdXL5an2UWWJcZCxtj37zsWLpMyJA79dd9zQ0RSXaWyDpGzKyIXH8gIvXlbkWbuSvCDuAgLMOl6TlsVU9Ut1FsTJo6TYCrl4S4lalOVaQFL2Yo=
Received: from MN2PR14MB4030.namprd14.prod.outlook.com (2603:10b6:208:1dc::14) by MN2PR14MB3504.namprd14.prod.outlook.com (2603:10b6:208:1a3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Wed, 5 Jan 2022 20:04:11 +0000
Received: from MN2PR14MB4030.namprd14.prod.outlook.com ([fe80::29a7:f994:54f5:b486]) by MN2PR14MB4030.namprd14.prod.outlook.com ([fe80::29a7:f994:54f5:b486%5]) with mapi id 15.20.4844.017; Wed, 5 Jan 2022 20:04:11 +0000
From: Don Fedyk <dfedyk@labn.net>
To: tom petch <daedulus@btconnect.com>
CC: "detnet@ietf.org" <detnet@ietf.org>, "draft-ietf-detnet-yang.all@ietf.org" <draft-ietf-detnet-yang.all@ietf.org>
Thread-Topic: Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14
Thread-Index: AQHX1aVVzOJCkt7zEEO2OKLaojNpkKxAOHCAgBTg/mA=
Date: Wed, 5 Jan 2022 20:04:11 +0000
Message-ID: <MN2PR14MB403066E8D1953043A52D3FE3BB4B9@MN2PR14MB4030.namprd14.prod.outlook.com>
References: <163648840575.19216.561627083204230489@ietfa.amsl.com> <61C46025.5040800@btconnect.com>
In-Reply-To: <61C46025.5040800@btconnect.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=labn.net;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: de68a70a-d4cb-409e-9410-08d9d0868a2e
x-ms-traffictypediagnostic: MN2PR14MB3504:EE_
x-microsoft-antispam-prvs: <MN2PR14MB35044A2220F9679C3794CAF7BB4B9@MN2PR14MB3504.namprd14.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: w4noPmFTSfA2s2V/9ZtIkBxjS5y9FzGnXZ52foRiz/BnboTwmYPTlPaz4LHf8vI53t4cszzpduvgig/1kHNDEuvIoIcK7aIrCReMlV/Z+lL7qdOMKPyUqVsRWylFC9lwyC1i/kHPjRB1B+FXSC5bMuPbL3rInXfpT+rW55cdstfXTTKmlxUqmXYry/bUMRdzpgxygjZxx/BNqx/UBQdZoc030yM4pErVOnEL2POIqh1j9yrBSrz4EsU17+JROcYupfq/LcYbpEaTU7dSUaaMChfvp5Mwph0BMYH1c+lreV8Ed6Ksh8VCQY9iQRtKZYXmTE89lwu9/5DRyjwfDRUwZXf865lXWP8metsVuOCGOWBSPaSPOTIGKS4VLSnLX896nrBfi+LO0rf3VgeLzbF+o7CfcmKi4KChDksUG2FnzXwcqhP11NsIMpUbLLxwceGA+t8INeG7x9iY1c1mq7zzly0p4Fqh5/610E/l9SEuhSTezJ7zfJJa+o4R0bs9PXjRyt8+wvzGukAT0FyGkktraV0a6Gf812EfV17DGReQ7n9OH74kI02GFZQeTB4UhyrGIxYFuNNuPuvA/4Xw1CrWw1TT+xKOGrrXj21NyHFzWZZyLI/eLpPsDDItofpGRhLWLwL5dPvBl/HcYjN8tnWYHNthNl+SWyNHDWg6cs9RYcjvJM4rb/KhwgZvIE2mQJ82CUXoUEVZfJCWH79dcifqdF3ITaCqBoY1ODhnh2BzhR8yJP7qauNWDmVc2vhwmZJLqk4dr3s9/FxNTmlIjWulkFW9EkbsqX404wowG84BoyA=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR14MB4030.namprd14.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(346002)(39830400003)(136003)(396003)(366004)(83380400001)(66946007)(66476007)(38070700005)(66446008)(8676002)(33656002)(9686003)(7696005)(64756008)(26005)(2906002)(76116006)(8936002)(71200400001)(5660300002)(53546011)(38100700002)(186003)(52536014)(66556008)(6506007)(6916009)(55016003)(966005)(296002)(316002)(122000001)(54906003)(4326008)(508600001)(86362001); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SlRCOUV3Q0ZRM0NYU24xVDVZVXUwT21ld1ROak5VLzF2ekRESGt1cVkvTjVa?= =?utf-8?B?ZjNaVE5DVVBQV01nN0xOWGxRdmRIOVdOblF6Uzd2MlZEMTRLZ2loaWsvQklj?= =?utf-8?B?SlVLbTJJd1RTR0lad2lqeGNFTzNLL2h0UlA2eDI5dlVMbkJJR1JsWHVpMHRV?= =?utf-8?B?aFREM3J2cFBmZnZBWGx5L2JiUWJKb3c4eXJJRFlxV1Nkd2ZjQ3VTWGhmRGFW?= =?utf-8?B?M09zeTdrd0o5Sm9JekNYcDBZL0FJa2J6Vmo2aGI4NUlLbnJNSFM3QmJLdTF6?= =?utf-8?B?eDlCdVBobnNJeWdkOGFPU2t6TFRXNGlGRUFtNU1yb1RHY3pBWDFMbTdjUTRD?= =?utf-8?B?NThTS2E3UFMvZ0x0R1lxUmUxc3hHMTZqcDB6Q05NZTc2TFI1eENiM1RTNEFO?= =?utf-8?B?d1pIQmptd2wrSEdLNGgvdldtZEdhWmlQZjBoNTZEQ0hVYzB6YTk4WkUwWHRx?= =?utf-8?B?RU1aTW44eUk5RHh0MWxWQjFKZ3Zyc2F2dDNreHpNUHQvdlhHRXRqQ3ZncmNT?= =?utf-8?B?ZjZIQUt2YnlkRjF4YVIwd3hyYkFYdlE3bDBTUk91emV1UnJNdXFSV2ZJMVYv?= =?utf-8?B?cFFFQ3RjR2QyM1htVERnb2NCbjA1V2pQdU9FdEhzRlVPRWVZSndIZ0swSElm?= =?utf-8?B?NjBXL3hvZlhQS2xtenFwdFpxZEF5cXlDWGZFcDhFc3RLdHEwekFKOGtrYUM0?= =?utf-8?B?bWpJdGFBTFhXN3JONHB4UHRTYkwvajluY2NXQ1BQZ2ZOL2E1Y3FDRDdKZ3Za?= =?utf-8?B?UVh6VFl5MEptR1VyMXVITGdZd2kwSW5nWGkvV1lIRmRnN1drRmFUUFN1aytk?= =?utf-8?B?Tlc4Zy9FazROeWFJM25obWxXTU9IaWI4RVNpUE5TakkvZnVkYU9sRGQ5Nk0w?= =?utf-8?B?aUN5QTNoKzFidkp2NTVrcy9pVVEydjRCMkRuTk1FK2p6NDR1dE5KOUk5ZEdu?= =?utf-8?B?NzZxdFdDUkswU1czTnpvcllEU2twblBST04rdGs3VEpvYVprMWFXMXJFVHhx?= =?utf-8?B?UXZEc1FaSnhXQ1RpUlVNOHFhUUVoTjRFaG0wVkdnU2ptaTNuOWFZME5wam9v?= =?utf-8?B?UlJyVFJUem9sQWJSeDM4dTN5V0ptUyswYk9oS2JkcFkwdjBNNnZYUEN1TGJS?= =?utf-8?B?RzN0cFRJaEVVL3pFWmhhTlBuQ3BYZExGbUc2TEVzREkzbENKSnQ1bjZEdWxt?= =?utf-8?B?QTFnNVlOYmJybThlNFQwUGk2UUU0SVVpNVY0WmRxQlJtc1lVVm11Z2tlYTJa?= =?utf-8?B?SFdjVUpCQ3l2SlhwRUJUYVRzZVBnQWVtSDBQVzR2T2dGV1dnWElDd1FodE92?= =?utf-8?B?N01PZk5QN3F0M2JMSVFaNG1DY1pLZEl6bFNhNHcrUFpqZzBWZkdlL2g0TnUr?= =?utf-8?B?MHRaZWJBK0FwaW82MmlnT1JGaFhHMUZ1TG5JKzVJYWIxWE1HUFRYRDlOMHNn?= =?utf-8?B?aWdWVUFwL2ZYY1JESGh4bzFudDZiaDFpSS9vakV0R1N5TFRUMS9yUTJVSnZC?= =?utf-8?B?YkdCekdJTWNLaWVKN2xzQmN4RXBMWVh6a2pHbXRpaFRsY2pQTklHSm96OFE4?= =?utf-8?B?TW90YmcxUG03bVlUK3RoQlA0dVhjU2o0M3BBVXZVYThrM0gxaUpVU1J2WkZ6?= =?utf-8?B?eEZUK3dVVkxLQjhkcjBEVkJYM2dyaWtWTTBDc3NGVi9oS0tqRmRJWUlROVkw?= =?utf-8?B?TFBIOFJhSlJTV004WWZ5WC8rQUk4b2xDUXlLVTV1ZVBWZDI1OGE1TFZPZ2FU?= =?utf-8?B?dHRDNUlmT25UK2J2OXVkaWNpK3ZudDQzZHB6UXNiVVR1L25NaGpNaElRcE1v?= =?utf-8?B?V3kzRXhUUDZpVEdhZ1o3RWJ4MlQ3dG8rVzl5MWlpNGlhalJacmJWbmtSazBv?= =?utf-8?B?dEFMcFF2K3dBbWo2dllZV3BGOVA3U0J5ejZ1UEF3c1c2VUFmQlQrUmE3TkxR?= =?utf-8?B?Vkc1NUsvVXVnT01KSTNJZnorVnBMa2lodW5uUUE2YUR4N1FoNFd0OHpQVUUz?= =?utf-8?B?ME1taFNDdjh1KzhSSkJ4aFp0VHRMQjEvNzJtRElTQS9Vek1uZlZETDJiNVBN?= =?utf-8?B?cXo0ZDFCNVUyYy9NL2NLam1aUmpjd2cyR0dxSWNvQWQ0bk1rc1pOTm5PSUdz?= =?utf-8?B?aEdaUUlZMUdlYUFIUFcybGc5Q3hhOVlJajJsVHh2SllXSThMZGtidFlkVGlw?= =?utf-8?B?ZHc9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: labn.net
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR14MB4030.namprd14.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de68a70a-d4cb-409e-9410-08d9d0868a2e
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2022 20:04:11.1358 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eb60ac54-2184-4344-9b60-40c8b2b72561
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rfB7i4HcvOn4IomYvuff6hg4LA/eK6xpbdgiAG5Cs4IVQV9Nb7OvlGM9Sj0/8I2r4XQ7ewR6bTTjP0oRJA0I1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR14MB3504
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/5e7P81ozirMLfl8dbYkhoRas-o4>
Subject: Re: [Detnet] Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jan 2022 20:04:19 -0000

Hi Tom

Comments Inline [Don]
Also incorporated, https://github.com/detnet-wg/draft-ietf-detnet-yang

Thanks
Don 


-----Original Message-----
From: tom petch <daedulus@btconnect.com> 
Sent: Thursday, December 23, 2021 6:40 AM
Cc: detnet@ietf.org; draft-ietf-detnet-yang.all@ietf.org
Subject: Comments on detnet-yang-15 Re: [Last-Call] Yangdoctors last call review of draft-ietf-detnet-yang-14

Borrowing a useful cc: with a related topic

two documents in the YANG module need adding to the I-D References
RFC8938
[Don] OK on this one 
IEEE 802.1Qcx-2020 
[Don] I see. Yes
contact URL
insecure, obsolete - https://datatracker ...
[Don] Fixed

Editor: Mach Chen
not in the authors of the I-D
[Don] Fixed

TLP out of date
[Don] TLP?  I changed the date reference in the XML header.  It should line up with the module date. 

Reference: this ID when published
Reference: "RFC XXXX: Deterministic Networking (DetNet) YANG Model
[Don] I think the RFC editor correct this on publication. 


Tom Petch


On 09/11/2021 20:06, Xufeng Liu via Datatracker wrote:
> Reviewer: Xufeng Liu
> Review result: Ready with Nits
>
> Thanks to authors for addressing the previous review comments.
>
> The updates look good. The followings are a few additional nits:
>
> 1) In the model, “container flow-spec” has been changed to “container 
> traffic-spec”, but the description has not been updated, shown as below:
>
>           container traffic-spec {
>             description
>               "Flow-specification specifies how the Source transmits
>                packets for the flow.  This is the promise/request of the
>                Source to the network.  The network uses this flow
>                specification to allocate resources and adjust queue
>                parameters in network nodes.";
>
> 2) Most names of list and leaf-list have been fixes. The following 
> three were
> missed: “leaf-list member-apps” should be “leaf-list member-app” 
> “leaf-list member-services” should be “leaf-list member-service” 
> “leaf-list member-fwd-sublayers” should be “leaf-list member-fwd-sublayer”
>
> 3) Section 10.  Security Considerations would need to include a list 
> of “sensitive or vulnerable” nodes.  RFC 8349 shows an example.
>
> Thanks,
> - Xufeng