[Detnet] Yangdoctors last call review of draft-ietf-detnet-yang-14

Xufeng Liu via Datatracker <noreply@ietf.org> Tue, 09 November 2021 20:06 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: detnet@ietf.org
Delivered-To: detnet@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id C73233A1079; Tue, 9 Nov 2021 12:06:45 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Xufeng Liu via Datatracker <noreply@ietf.org>
To: <yang-doctors@ietf.org>
Cc: detnet@ietf.org, draft-ietf-detnet-yang.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.39.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <163648840575.19216.561627083204230489@ietfa.amsl.com>
Reply-To: Xufeng Liu <xufeng.liu.ietf@gmail.com>
Date: Tue, 09 Nov 2021 12:06:45 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/Z81g9KpIPlDbpJsAEdH7S2nhmdc>
Subject: [Detnet] Yangdoctors last call review of draft-ietf-detnet-yang-14
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Nov 2021 20:06:46 -0000

Reviewer: Xufeng Liu
Review result: Ready with Nits

Thanks to authors for addressing the previous review comments.

The updates look good. The followings are a few additional nits:

1) In the model, “container flow-spec” has been changed to “container
traffic-spec”, but the description has not been updated, shown as below:

         container traffic-spec {
           description
             "Flow-specification specifies how the Source transmits
              packets for the flow.  This is the promise/request of the
              Source to the network.  The network uses this flow
              specification to allocate resources and adjust queue
              parameters in network nodes.";

2) Most names of list and leaf-list have been fixes. The following three were
missed: “leaf-list member-apps” should be “leaf-list member-app” “leaf-list
member-services” should be “leaf-list member-service” “leaf-list
member-fwd-sublayers” should be “leaf-list member-fwd-sublayer”

3) Section 10.  Security Considerations would need to include a list of
“sensitive or vulnerable” nodes.  RFC 8349 shows an example.

Thanks,
- Xufeng