Re: [Dime] [dime] #54: OC-Report-Type as mandatory AVP

Jouni Korhonen <jouni.nospam@gmail.com> Thu, 13 February 2014 12:05 UTC

Return-Path: <jouni.nospam@gmail.com>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6F0411A01FC for <dime@ietfa.amsl.com>; Thu, 13 Feb 2014 04:05:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1
X-Spam-Level:
X-Spam-Status: No, score=-1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HNzROp_AB74T for <dime@ietfa.amsl.com>; Thu, 13 Feb 2014 04:05:32 -0800 (PST)
Received: from mail-la0-x231.google.com (mail-la0-x231.google.com [IPv6:2a00:1450:4010:c03::231]) by ietfa.amsl.com (Postfix) with ESMTP id 4E77B1A01FA for <dime@ietf.org>; Thu, 13 Feb 2014 04:05:32 -0800 (PST)
Received: by mail-la0-f49.google.com with SMTP id y1so8067888lam.36 for <dime@ietf.org>; Thu, 13 Feb 2014 04:05:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=RHpmTDlbQKxx7FmmExBBC43E7F6x3etQok0fNHxhHm8=; b=E24B/cJBHkZFF67BBW20K8GeDLbQail2IJuUQwN1SAnVwXNvQqcrUq0f9V/IJXSwvo E7p1cL0pfIidv4jJjxKDozFib+YYQleA1FIXJ7qcL0RnaTWhRUAyCKsshCSLIc2oXBJx IXadk0e05kZVfulr0nE4AWUJ3g3SIOCSma0yWcN99w0o4/JCWVwcKS8NVj55Q7HKE2Ag 2b3F29rMQ1m2RxaCqj2ejHg0OafpOGRYPyQvYE76npc22ZnxD+Psb6acjHvnvYIxbkih HjgPRQeUWNnLHLTguGiFlLZumUSzTbFb5YJ21QKor+v3wnxmJEwbuiyXlThU83CntD5k h93A==
X-Received: by 10.112.253.34 with SMTP id zx2mr729928lbc.61.1392293130438; Thu, 13 Feb 2014 04:05:30 -0800 (PST)
Received: from [192.168.250.109] ([194.100.71.98]) by mx.google.com with ESMTPSA id cl5sm1850780lbb.14.2014.02.13.04.05.28 for <multiple recipients> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 13 Feb 2014 04:05:29 -0800 (PST)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
From: Jouni Korhonen <jouni.nospam@gmail.com>
In-Reply-To: <E194C2E18676714DACA9C3A2516265D2026649A3@FR712WXCHMBA11.zeu.alcatel-lucent.com>
Date: Thu, 13 Feb 2014 14:05:24 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <EE7D3FEB-CD2A-45D9-9700-5CCA118D9A14@gmail.com>
References: <075.72da31b401c033905a4fb81d09a8b4aa@trac.tools.ietf.org> <7077_1392216348_52FB891B_7077_4146_1_6B7134B31289DC4FAF731D844122B36E49E1A4@PEXCVZYM13.corporate.adroot.infra.ftgroup> <E194C2E18676714DACA9C3A2516265D2026649A3@FR712WXCHMBA11.zeu.alcatel-lucent.com>
To: "TROTTIN, JEAN-JACQUES (JEAN-JACQUES)" <jean-jacques.trottin@alcatel-lucent.com>
X-Mailer: Apple Mail (2.1510)
Cc: "dime@ietf.org" <dime@ietf.org>
Subject: Re: [Dime] [dime] #54: OC-Report-Type as mandatory AVP
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Feb 2014 12:05:34 -0000

Agree that it is a small optimization, which I put there
because at the beginning there seemed to be a lot of worry
on every extra AVP ;-)

I prefer having the AVP optional but with a default value
just like it is now. We have the same for the reduction
percentage and the validity time as well.

- Jouni

On Feb 13, 2014, at 10:55 AM, "TROTTIN, JEAN-JACQUES (JEAN-JACQUES)" <jean-jacques.trottin@alcatel-lucent.com> wrote:

> Hi Mcruz
> 
> The current description indicates that when not present the OLR is of type Host, which was fine for me and keeps my preference. 
> We may have  deployments where Realm OLR is not used, or where statistically the HOST type is the most frequent, so to have the grouped OLR-AVP containing a minimum of AVPs minimizes parsing. I agree it is a small optimization.
> 
> Best regards
> 
> JJacques 
> 
> 
> 
> 
> -----Message d'origine-----
> De : DiME [mailto:dime-bounces@ietf.org] De la part de lionel.morand@orange.com
> Envoyé : mercredi 12 février 2014 15:46
> À : dime@ietf.org; maria.cruz.bartolome@ericsson.com
> Objet : Re: [Dime] [dime] #54: OC-Report-Type as mandatory AVP
> 
> Hi Maria Cruz,
> 
> I'm assuming that you mean "required" instead of "mandatory", right?
> 
> So instead of:
> 
>   OC-OLR ::= < AVP Header: TBD2 >
>              < OC-Sequence-Number >
>              [ OC-Report-Type ]
>              [ OC-Reduction-Percentage ]
>              [ OC-Validity-Duration ]
>            * [ AVP ]
> 
> You would prefer:
> 
>   OC-OLR ::= < AVP Header: TBD2 >
>              < OC-Sequence-Number >
>              { OC-Report-Type }
>              [ OC-Reduction-Percentage ]
>              [ OC-Validity-Duration ]
>            * [ AVP ]
> 
> And I'm fine with this proposal.
> 
> Cheers,
> 
> Lionel
> 
> -----Message d'origine-----
> De : DiME [mailto:dime-bounces@ietf.org] De la part de dime issue tracker Envoyé : mercredi 12 février 2014 15:26 À : maria.cruz.bartolome@ericsson.com Cc : dime@ietf.org Objet : [Dime] [dime] #54: OC-Report-Type as mandatory AVP
> 
> #54: OC-Report-Type as mandatory AVP
> 
> Now in chapter 4.6:
> 
>    The default value of the OC-Report-Type AVP is 0 (i.e. the host
>    report).
> 
> This AVP is always required, right? Then, I think it is more precise that  we define this AVP as mandatory.
> 
> -- 
> -----------------------------------------------+------------------------
> -----------------------------------------------+---
> Reporter:  maria.cruz.bartolome@ericsson.com  |      Owner:  MCruz
>     Type:  defect                             |  Bartolomé
> Priority:  major                              |     Status:  new
> Component:  draft-docdt-dime-ovli              |  Milestone:
> Severity:  Active WG Document                 |    Version:  1.0
>                                               |   Keywords:
> -----------------------------------------------+------------------------
> -----------------------------------------------+---
> 
> Ticket URL: <http://trac.tools.ietf.org/wg/dime/trac/ticket/54>
> dime <http://tools.ietf.org/wg/dime/>
> 
> _______________________________________________
> DiME mailing list
> DiME@ietf.org
> https://www.ietf.org/mailman/listinfo/dime
> 
> _________________________________________________________________________________________________________________________
> 
> Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
> 
> This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation.
> If you have received this email in error, please notify the sender and delete this message and its attachments.
> As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
> Thank you.
> 
> _______________________________________________
> DiME mailing list
> DiME@ietf.org
> https://www.ietf.org/mailman/listinfo/dime
> _______________________________________________
> DiME mailing list
> DiME@ietf.org
> https://www.ietf.org/mailman/listinfo/dime