IETF Logo Mail Archive

Re: [Gen-art] [kitten] Genart telechat review of draft-ietf-kitten-rfc5653bis-06

Weijun Wang <weijun.wang@oracle.com> Sun, 28 January 2018 13:41 UTC

Return-Path: <weijun.wang@oracle.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F317312DA2B; Sun, 28 Jan 2018 05:41:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.031
X-Spam-Level:
X-Spam-Status: No, score=-2.031 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=oracle.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g64mWiI2_yAH; Sun, 28 Jan 2018 05:41:15 -0800 (PST)
Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3C8AB129C6D; Sun, 28 Jan 2018 05:41:15 -0800 (PST)
Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w0SDc4Xg064069; Sun, 28 Jan 2018 13:41:10 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2017-10-26; bh=mKsU4yaSBPwq6Bi2a2eaJAg3flFwkAJHtYIbj6wsJ9k=; b=PrW1cMxnNaSHIsW6SR2jyj0XEFfkqz2XvqKFoeD0tjvGmT8fvhQglBLrSIkoPUqK5679 9J3Ls3ta6KmV1V/vNx6laJskychhRICRBS8mWOz8mXiPgutxSjWK9okWh/3XLvs8QslW /PcvyL6LBfl0HBAMHkHgBUmLKpXjkqdyLFffWqx4xnDWN+RQ3fyyq8hEByS+Dq/V4Kzb C8btBkhcpr2g/80YNGFhW7DxBKdkGMmgybOlXcQs0CzFFaq6w/riacTu2m6hT8KrOPas HPsO9Mb2Ru7YHMY+RRwQedHEDbXx1JHCyhnGCXSl2yir5tY8mcndnzkVNgsTZ1eopAz9 yw==
Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2fsesvg2m0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 28 Jan 2018 13:41:10 +0000
Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w0SDf9sO002937 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 28 Jan 2018 13:41:09 GMT
Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w0SDf8DK026668; Sun, 28 Jan 2018 13:41:08 GMT
Received: from [192.168.1.101] (/114.240.102.71) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 28 Jan 2018 05:41:08 -0800
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\))
From: Weijun Wang <weijun.wang@oracle.com>
In-Reply-To: <366697b8-2a0c-243b-b153-ee8eb4358580@mit.edu>
Date: Sun, 28 Jan 2018 21:41:03 +0800
Cc: Alissa Cooper <alissa@cooperw.in>, kitten <kitten@ietf.org>, gen-art <gen-art@ietf.org>, "Joel M. Halpern" <jmh@joelhalpern.com>, draft-ietf-kitten-rfc5653bis.all@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <0798B7AD-FC4A-4799-827D-BEE51A34B392@oracle.com>
References: <151493583156.30989.1076207750886953383@ietfa.amsl.com> <20180103013808.GG50827@kduck.kaduk.org> <25d5a1bb-e7bb-431b-6632-09904a581d77@joelhalpern.com> <074DA813-1E7F-4C03-AEEE-5D76E8804C31@oracle.com> <41bbbe7d-0f35-78ad-a5cd-673488f3ac09@joelhalpern.com> <20180103030817.GH50827@kduck.kaduk.org> <C47701B8-2504-490B-BE38-ED35A1D2C1A2@oracle.com> <19F5D23D-3677-41C6-B504-454C7595FF1F@cooperw.in> <D6DB69A6-5768-4536-89AA-40E0A905DF95@oracle.com> <366697b8-2a0c-243b-b153-ee8eb4358580@mit.edu>
To: Greg Hudson <ghudson@mit.edu>
X-Mailer: Apple Mail (2.3445.5.20)
X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8787 signatures=668655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=9 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=610 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801280190
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/tuLExlfZ9Mx0pUy4wUeNBOM8Xfw>
Subject: Re: [Gen-art] [kitten] Genart telechat review of draft-ietf-kitten-rfc5653bis-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Jan 2018 13:41:17 -0000

Hi Greg

Thank you so much for your careful review. All suggestions accepted.

> On Jan 27, 2018, at 10:12 AM, Greg Hudson <ghudson@mit.edu> wrote:
> 
> On 01/23/2018 06:43 PM, Weijun Wang wrote:
>> I've uploaded an updated version at
>> 
>>  http://cr.openjdk.java.net/~weijun/rfc5653bis/draft-ietf-kitten-rfc5653bis-07.html
> 
> This is a great format for reviewing these changes; thanks for
> generating it.

Glad you like it. I have to do this to avoid words like the 2nd MAY in the 3rd paragraph on page 45.

> 
> Line 416 does not capitalize "optional" in "optional services", but
> lines 385 and 391 do.
> 
> Lines 422 and 424 should probably capitalize "should".  Line 429 should
> probably capitalize "may".
> 
> At line 598, I would lean towards leaving "MUST" in lowercase as we are
> describing an application requirement, not prescribing one.
> 
> Line 1174, I would leave "MAY" in lowercase.
> 
> Line 1129, "may" should probably be capitalized.

1179?

Thanks
Weijun

> 
> Line 1369, I would leave "MAY" alone as this seems more descriptive than
> prescriptive.
> 
> Line 3221's use of "SHOULD" is prescriptive, but there's no other way to
> request the default QOP.  So I would leave it lowercase (or change the
> wording, but I'm not trying to open any more cans of worms).
>

v2.23.0 | Report a Bug | By Email