Re: [Gen-art] [kitten] Genart telechat review of draft-ietf-kitten-rfc5653bis-06

Greg Hudson <ghudson@mit.edu> Sat, 27 January 2018 02:13 UTC

Return-Path: <ghudson@mit.edu>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2AC0612D876; Fri, 26 Jan 2018 18:13:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.229
X-Spam-Level:
X-Spam-Status: No, score=-4.229 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B85VP2Fxjteq; Fri, 26 Jan 2018 18:13:02 -0800 (PST)
Received: from dmz-mailsec-scanner-3.mit.edu (dmz-mailsec-scanner-3.mit.edu [18.9.25.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 14AF012D86F; Fri, 26 Jan 2018 18:13:01 -0800 (PST)
X-AuditID: 1209190e-90bff70000000ce3-67-5a6be02c0a6d
Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP id 9A.3F.03299.C20EB6A5; Fri, 26 Jan 2018 21:13:00 -0500 (EST)
Received: from outgoing.mit.edu (OUTGOING-AUTH-1.MIT.EDU [18.9.28.11]) by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id w0R2CxpA029135; Fri, 26 Jan 2018 21:12:59 -0500
Received: from [18.101.8.176] (VPN-18-101-8-176.MIT.EDU [18.101.8.176]) (authenticated bits=0) (User authenticated as ghudson@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id w0R2Ct2o030493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 26 Jan 2018 21:12:56 -0500
To: Weijun Wang <weijun.wang@oracle.com>, Alissa Cooper <alissa@cooperw.in>
Cc: kitten <kitten@ietf.org>, gen-art <gen-art@ietf.org>, "Joel M. Halpern" <jmh@joelhalpern.com>, draft-ietf-kitten-rfc5653bis.all@ietf.org
References: <151493583156.30989.1076207750886953383@ietfa.amsl.com> <20180103013808.GG50827@kduck.kaduk.org> <25d5a1bb-e7bb-431b-6632-09904a581d77@joelhalpern.com> <074DA813-1E7F-4C03-AEEE-5D76E8804C31@oracle.com> <41bbbe7d-0f35-78ad-a5cd-673488f3ac09@joelhalpern.com> <20180103030817.GH50827@kduck.kaduk.org> <C47701B8-2504-490B-BE38-ED35A1D2C1A2@oracle.com> <19F5D23D-3677-41C6-B504-454C7595FF1F@cooperw.in> <D6DB69A6-5768-4536-89AA-40E0A905DF95@oracle.com>
From: Greg Hudson <ghudson@mit.edu>
Message-ID: <366697b8-2a0c-243b-b153-ee8eb4358580@mit.edu>
Date: Fri, 26 Jan 2018 21:12:54 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <D6DB69A6-5768-4536-89AA-40E0A905DF95@oracle.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsUixCmqravzIDvK4OBdU4vpZ/4yWiw6uo/Z 4uqrzywWH0+9YbI4unkVi8XXpRuYHdg8vjx5yeSxZMlPJo9zU74zenx8eoslgCWKyyYlNSez LLVI3y6BK+PmTe6Ch+wVz6/nNDAuYeti5OSQEDCRmPP2JXMXIxeHkMBiJolZ2/+zQDgbGSV6 ehqgnKNMEr9uz2MHaREWiJZoW3gNrF1EwFti4cEWRpAiZoF5jBLt8xdCzbrNLHFhXxcTSBWb gLLE+v1bWUBsXgEriQnnL7J2MXJwsAioSsz7Zw4SFhWIkGiaOZcVokRQ4uTMJ2DlnAJ2EhNb vjKC2MwC6hJ/5l1ihrDFJW49mc8EYctLbH87h3kCo+AsJO2zkLTMQtIyC0nLAkaWVYyyKblV urmJmTnFqcm6xcmJeXmpRbrGermZJXqpKaWbGMFRIcm3g3FSg/chRgEORiUe3gST7Cgh1sSy 4srcQ4ySHExKorwi84BCfEn5KZUZicUZ8UWlOanFhxglOJiVRHjNOIFyvCmJlVWpRfkwKWkO FiVxXncT7SghgfTEktTs1NSC1CKYrAwHh5IEL9N9oEbBotT01Iq0zJwShDQTByfIcB6g4Zvu gQwvLkjMLc5Mh8ifYjTmaFv5pI2Z48aL123MQix5+XmpUuK8bCDjBEBKM0rz4KaBE1sqx4ZX jOJAzwnzFoFU8QCTIty8V0CrmIBW2VVkgqwqSURISTUw5v6zVo49/nSGoRT7pJo3vpqB5jnW 4pFrmP9KBkv+7ha6+2Zbt51OFMO5GKcn6kc3X1zXxrdk+nG7tIBb6xRuyUikMypc2HLjkNtp 6/0i1WI/Wj85rTt5pF5RRzjyZVbU/5xLhp9uTSiWeTWjd8ndRY8UtXhOcVxu7WGLY6rd4Ca7 Q0JxskmaEktxRqKhFnNRcSIAbkZzT0cDAAA=
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/Ee9TrqL87vwmobS3Ko2J-DtGV2g>
Subject: Re: [Gen-art] [kitten] Genart telechat review of draft-ietf-kitten-rfc5653bis-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Jan 2018 02:13:04 -0000

On 01/23/2018 06:43 PM, Weijun Wang wrote:
> I've uploaded an updated version at
> 
>   http://cr.openjdk.java.net/~weijun/rfc5653bis/draft-ietf-kitten-rfc5653bis-07.html

This is a great format for reviewing these changes; thanks for
generating it.

Line 416 does not capitalize "optional" in "optional services", but
lines 385 and 391 do.

Lines 422 and 424 should probably capitalize "should".  Line 429 should
probably capitalize "may".

At line 598, I would lean towards leaving "MUST" in lowercase as we are
describing an application requirement, not prescribing one.

Line 1174, I would leave "MAY" in lowercase.

Line 1129, "may" should probably be capitalized.

Line 1369, I would leave "MAY" alone as this seems more descriptive than
prescriptive.

Line 3221's use of "SHOULD" is prescriptive, but there's no other way to
request the default QOP.  So I would leave it lowercase (or change the
wording, but I'm not trying to open any more cans of worms).