Re: [Gen-art] [kitten] Genart telechat review of draft-ietf-kitten-rfc5653bis-06

Weijun Wang <weijun.wang@oracle.com> Mon, 29 January 2018 01:28 UTC

Return-Path: <weijun.wang@oracle.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 823751314CF; Sun, 28 Jan 2018 17:28:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.03
X-Spam-Level:
X-Spam-Status: No, score=-2.03 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=oracle.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id opskAc6hHUf8; Sun, 28 Jan 2018 17:28:31 -0800 (PST)
Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5D4A41314D8; Sun, 28 Jan 2018 17:28:07 -0800 (PST)
Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w0T1S1be070323; Mon, 29 Jan 2018 01:28:02 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2017-10-26; bh=iCJ4Gw0+zaXqHzlNKjaUNAbVKy+ZRy1qekYS7pp8iuk=; b=eG3Lu6oN8BuJvahqMPqbK52GDtKCISCAftDciQQddEif4/ffUlm4oPxK9iBHN8f35eQk ZMcoyP0hQvOyC16tcrY1XE7utCqIyQWL4KgRce39S7m/TZHEdRlduDVUjr2ny5uGtCIf 20V92PRxqsdWwRV0Z0UHf3vNP/mXP+5fXlZ/0Y5vb6bE8ljTNQRdetl0vP1U+Mnw8MJC IjHT47a4Pzjv2FU5SjKygieqyOyOXV8cu9eMrCoYHRcIHf+EHfCwQ9Va1aO2f4qqbNu5 fPkvOhdUYzRtj9BcFlJHEW55BDC6SlBhQEpWeU6H/DLlbVJFjoNyoJOZKG0anxJwhwZg 6Q==
Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2120.oracle.com with ESMTP id 2fsryhr325-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Jan 2018 01:28:01 +0000
Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w0T1QE9x002819 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 29 Jan 2018 01:26:14 GMT
Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w0T1QD9h020414; Mon, 29 Jan 2018 01:26:13 GMT
Received: from [192.168.1.101] (/114.240.102.71) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 28 Jan 2018 17:26:12 -0800
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\))
From: Weijun Wang <weijun.wang@oracle.com>
In-Reply-To: <366697b8-2a0c-243b-b153-ee8eb4358580@mit.edu>
Date: Mon, 29 Jan 2018 09:26:08 +0800
Cc: Alissa Cooper <alissa@cooperw.in>, kitten <kitten@ietf.org>, gen-art <gen-art@ietf.org>, "Joel M. Halpern" <jmh@joelhalpern.com>, draft-ietf-kitten-rfc5653bis.all@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <8F5B79CD-B928-4B8E-97FA-D946784228B7@oracle.com>
References: <151493583156.30989.1076207750886953383@ietfa.amsl.com> <20180103013808.GG50827@kduck.kaduk.org> <25d5a1bb-e7bb-431b-6632-09904a581d77@joelhalpern.com> <074DA813-1E7F-4C03-AEEE-5D76E8804C31@oracle.com> <41bbbe7d-0f35-78ad-a5cd-673488f3ac09@joelhalpern.com> <20180103030817.GH50827@kduck.kaduk.org> <C47701B8-2504-490B-BE38-ED35A1D2C1A2@oracle.com> <19F5D23D-3677-41C6-B504-454C7595FF1F@cooperw.in> <D6DB69A6-5768-4536-89AA-40E0A905DF95@oracle.com> <366697b8-2a0c-243b-b153-ee8eb4358580@mit.edu>
To: Greg Hudson <ghudson@mit.edu>
X-Mailer: Apple Mail (2.3445.5.20)
X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8788 signatures=668655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=9 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=592 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801290017
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/588Do7YK4ToifQhybbC1TQRBmNs>
Subject: Re: [Gen-art] [kitten] Genart telechat review of draft-ietf-kitten-rfc5653bis-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jan 2018 01:28:34 -0000

The HTML file updated in place.

Thanks
Weijun

> On Jan 27, 2018, at 10:12 AM, Greg Hudson <ghudson@mit.edu> wrote:
> 
> On 01/23/2018 06:43 PM, Weijun Wang wrote:
>> I've uploaded an updated version at
>> 
>>  http://cr.openjdk.java.net/~weijun/rfc5653bis/draft-ietf-kitten-rfc5653bis-07.html
> 
> This is a great format for reviewing these changes; thanks for
> generating it.
> 
> Line 416 does not capitalize "optional" in "optional services", but
> lines 385 and 391 do.
> 
> Lines 422 and 424 should probably capitalize "should".  Line 429 should
> probably capitalize "may".
> 
> At line 598, I would lean towards leaving "MUST" in lowercase as we are
> describing an application requirement, not prescribing one.
> 
> Line 1174, I would leave "MAY" in lowercase.
> 
> Line 1229, "may" should probably be capitalized.
> 
> Line 1369, I would leave "MAY" alone as this seems more descriptive than
> prescriptive.
> 
> Line 3221's use of "SHOULD" is prescriptive, but there's no other way to
> request the default QOP.  So I would leave it lowercase (or change the
> wording, but I'm not trying to open any more cans of worms).
>