Re: [quicwg/base-drafts] Use PTO to declare in-flight packets lost (#1965)

[janaiyengar <[e-mail]>]

janaiyengar commented on this pull request.

I think @martinduke is right that we should handle this particular case, and I'm fine with the resolution in this PR. A few comments (and the text is in teh wrong place)

> @@ -421,6 +421,15 @@ control and loss recovery state, including resetting any pending timers.  Either
 packet indicates that the Initial was received but not processed.  Neither
 packet can be treated as an acknowledgment for the Initial.
 
+If no new data or unacknowledged data is available to send, an ack-eliciting
+packet SHOULD be sent.  Sending a retransmittable frame ensures that any in
+flight packets are acknowledged or declared lost in a timely manner.  If no
+ack-eliciting packet is sent, the in flight packets should be declared lost
+to avoid repeatedly arming and firing the PTO timer.
+
+A sender may not know that a packet being sent is a tail packet.  Consequently,
+a sender may have to arm or adjust the TLP timer on every sent retransmittable
+packet.

I suspect this para is leftover and should be removed.

> @@ -421,6 +421,15 @@ control and loss recovery state, including resetting any pending timers.  Either
 packet indicates that the Initial was received but not processed.  Neither
 packet can be treated as an acknowledgment for the Initial.
 
+If no new data or unacknowledged data is available to send, an ack-eliciting
+packet SHOULD be sent.  Sending a retransmittable frame ensures that any in
+flight packets are acknowledged or declared lost in a timely manner.  If no
+ack-eliciting packet is sent, the in flight packets should be declared lost

```suggestion
ack-eliciting packet is sent, any packets currently in flight should be declared lost
```

> @@ -421,6 +421,15 @@ control and loss recovery state, including resetting any pending timers.  Either
 packet indicates that the Initial was received but not processed.  Neither
 packet can be treated as an acknowledgment for the Initial.
 
+If no new data or unacknowledged data is available to send, an ack-eliciting

This new text should be further below in the #pto section.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1965#pullrequestreview-186767719