IETF Logo Mail Archive

Re: [quicwg/base-drafts] Prevent an unlikely deadlock (#1965)

Mike Bishop <notifications@github.com> Mon, 05 November 2018 09:30 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B55CF1277BB for <quic-issues@ietfa.amsl.com>; Mon, 5 Nov 2018 01:30:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9rdiUP_Yqhof for <quic-issues@ietfa.amsl.com>; Mon, 5 Nov 2018 01:30:23 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CAF671274D0 for <quic-issues@ietf.org>; Mon, 5 Nov 2018 01:30:22 -0800 (PST)
Date: Mon, 05 Nov 2018 01:30:21 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1541410221; bh=nLkOrngfH61qo7UeFdupTC/ie9zEAQSiyCcfWQqeeg0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yphxy23HBnhX0xb5EA1FfDc93nMawCFPJBAh70xJLHSpUJ/dt+Bwn9WlxTMIovOw7 mliIWYiYV2TJJUPi2A6TYOatmJmOwCc2ZYpuJ2iyperdr4hrcAyMm4VAKs9dSBS2uC V4/VBn0VroHdW35Vz+AR/VNSsc1b/Gf/AAOCanf0=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abfdc15d8cc4458b4ee18dc0e8881e4da28eb7942c92cf0000000117f7cfad92a169ce167cded5@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1965/review/171469749@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1965@github.com>
References: <quicwg/base-drafts/pull/1965@github.com>
Subject: Re: [quicwg/base-drafts] Prevent an unlikely deadlock (#1965)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5be00dadb6583_63f13fbc7a0d45b49761b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/EKbfk-639-7PRuxTx895IGdDVnc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Nov 2018 09:30:25 -0000

MikeBishop commented on this pull request.



> @@ -418,6 +418,12 @@ used to send a probe into the network prior to establishing any packet loss,
 prior unacknowledged packets SHOULD NOT be marked as lost when a TLP timer
 expires.
 
+If no new data or unacknowledged data is available to send, a retransmittable
+frame SHOULD be sent.  Sending a retransmittable frame ensures that any in
+flight packets are acknowledged or declared lost in a timely manner.
+Otherwise, a deadlock results if there is no available congestion window and
+all in flight packets contain no data that can be retransmitted.

Hyphenate "in-flight" when used before the noun this way.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1965#pullrequestreview-171469749

v2.23.0 | Report a Bug | By Email