IETF Logo Mail Archive

Re: [quicwg/base-drafts] Prevent an unlikely deadlock (#1965)

MikkelFJ <notifications@github.com> Mon, 05 November 2018 22:23 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C0ACC124D68 for <quic-issues@ietfa.amsl.com>; Mon, 5 Nov 2018 14:23:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.47
X-Spam-Level:
X-Spam-Status: No, score=-3.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iDj-ncYU1A_8 for <quic-issues@ietfa.amsl.com>; Mon, 5 Nov 2018 14:23:13 -0800 (PST)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AA0E2124C04 for <quic-issues@ietf.org>; Mon, 5 Nov 2018 14:23:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=hWFb9YDpHniS96R9j/swYyVBHTw=; b=tfqSFKNhwS3HIDb3 aUPA68Was1YR9qqHuWnwscTrUwvpj0ta86r4kAgHtvvrACtaV+ojuBYdygli0ftP n9YUZCaPA2rt7dkYRfXxB3nttRa68yK+gv7DtCPwo5GkbLCeKM+XvDzYIlXp/eG3 U2OVIE7mEiAyEb7RWr1lINfi8I0=
Received: by filter0805p1las1.sendgrid.net with SMTP id filter0805p1las1-29779-5BE0C2CE-33 2018-11-05 22:23:11.083060641 +0000 UTC m=+426693.172323676
Received: from github-lowworker-fc273f0.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id MTIQELeSQeK94U4gQ9UJog for <quic-issues@ietf.org>; Mon, 05 Nov 2018 22:23:10.903 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-fc273f0.cp1-iad.github.net (Postfix) with ESMTP id DA087C0F69 for <quic-issues@ietf.org>; Mon, 5 Nov 2018 14:23:10 -0800 (PST)
Date: Mon, 05 Nov 2018 22:23:11 +0000
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf33a681300a1db92f29b761bea44d7f53bd9e78992cf0000000117f884ce92a169ce167cded5@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1965/review/171789213@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1965@github.com>
References: <quicwg/base-drafts/pull/1965@github.com>
Subject: Re: [quicwg/base-drafts] Prevent an unlikely deadlock (#1965)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5be0c2ced7eda_22883fba396d45c416586d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3LMSVHbsLYFJmlmTHKts0XDteajda+nFE5SU a4O3tYzJhhEnF0SUJQJJPWFV1ZZlYZUM6SjAs9PMIfNsDkeK+TlccloioWI0hdRpsJCDtukIAC3MOG ffgWsW1S6Tun4q1zdgQkouDlloN6a2uoAKBIo0TFfqkbumSkDX2VKzWnGGWWjCZSJNCIDNSoJb9gKn I=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/goPOkDeZAr4kpU9wxxwJB0m5-FE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Nov 2018 22:23:15 -0000

mikkelfj commented on this pull request.



> @@ -142,7 +142,7 @@ of frames contained in a packet affect recovery and congestion control logic:
 
 * Packets that contain only ACK frames do not count toward congestion control
   limits and are not considered in-flight. Note that this means PADDING frames
-  cause packets to contribute toward bytes in flight without directly causing an
+  cause packets to contribute toward bytes in-flight without directly causing an
   acknowledgment to be sent.

If `in-flight` is used, I think other text needs to updated also. The motivation for not using hyphen was the confusion with `bytes_in_flight` as a variable name.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1965#discussion_r230936149

v2.23.0 | Report a Bug | By Email