Re: [quicwg/base-drafts] Prevent an unlikely deadlock (#1965)
Mike Bishop <notifications@github.com> Wed, 14 November 2018 00:19 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C85A1130E02 for <quic-issues@ietfa.amsl.com>; Tue, 13 Nov 2018 16:19:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.469
X-Spam-Level:
X-Spam-Status: No, score=-8.469 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GbNElh2ms-_Y for <quic-issues@ietfa.amsl.com>; Tue, 13 Nov 2018 16:19:28 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 866A3130DF5 for <quic-issues@ietf.org>; Tue, 13 Nov 2018 16:19:28 -0800 (PST)
Date: Tue, 13 Nov 2018 16:19:27 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542154767; bh=fbNLWGdGVFOUx6FA01EScl78sM6nIXtogKHwiwh43Uo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=e9sUudcSSp3F0JsnXoZd/nIlKMbV99SbW0405NRINVstV0ghRPwj2ZVdvuk/R+9uv cTsGf4qZ1hvcrXCVoofP633xFN2z+4nEfh1vWZdc/WgNr1rGx/2krNZfdxIYOS9Mop 9E5WO2tCamARzUjjFEgQJ6uT/bP5CAiA9Et2/xOg=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6a78c31d5da7113ab5879abf146702d095083a1a92cf0000000118032c0f92a169ce167cded5@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1965/review/174649770@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1965@github.com>
References: <quicwg/base-drafts/pull/1965@github.com>
Subject: Re: [quicwg/base-drafts] Prevent an unlikely deadlock (#1965)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5beb6a0f225c8_54053f8adf2d45c035767"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/klXNJBBho975bi9Rm6NDJe65yp4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Nov 2018 00:19:31 -0000
MikeBishop commented on this pull request. > @@ -142,7 +142,7 @@ of frames contained in a packet affect recovery and congestion control logic: * Packets that contain only ACK frames do not count toward congestion control limits and are not considered in-flight. Note that this means PADDING frames - cause packets to contribute toward bytes in flight without directly causing an + cause packets to contribute toward bytes in-flight without directly causing an acknowledgment to be sent. "in-flight" when used as a compound modifier (in-flight packets, for example) should usually have a hyphen before the noun. Here, it's after the noun, so this wouldn't get one. See [here](https://www.quickanddirtytips.com/education/grammar/how-to-use-a-hyphen), for example. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1965#discussion_r233273505
- [quicwg/base-drafts] Prevent an unlikely deadlock… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… martinduke
- Re: [quicwg/base-drafts] Prevent an unlikely dead… martinduke
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… martinduke
- Re: [quicwg/base-drafts] Prevent an unlikely dead… martinduke
- Re: [quicwg/base-drafts] Prevent an unlikely dead… martinduke
- Re: [quicwg/base-drafts] Prevent an unlikely dead… Mike Bishop
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ekr
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… MikkelFJ
- Re: [quicwg/base-drafts] Prevent an unlikely dead… Matt Olson
- Re: [quicwg/base-drafts] Prevent an unlikely dead… Nick Banks
- Re: [quicwg/base-drafts] Prevent an unlikely dead… MikkelFJ
- Re: [quicwg/base-drafts] Prevent an unlikely dead… Nick Banks
- Re: [quicwg/base-drafts] Prevent an unlikely dead… Nick Banks
- Re: [quicwg/base-drafts] Prevent an unlikely dead… MikkelFJ
- Re: [quicwg/base-drafts] Prevent an unlikely dead… MikkelFJ
- Re: [quicwg/base-drafts] Prevent an unlikely dead… Mike Bishop
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… martinduke
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… ianswett
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… martinduke
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… ianswett
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… janaiyengar
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… ianswett
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… ianswett
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… ianswett
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… janaiyengar
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… janaiyengar
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… janaiyengar
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… ianswett
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… martinduke
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… ianswett