Re: [quicwg/base-drafts] Prevent an unlikely deadlock (#1965)
martinduke <notifications@github.com> Mon, 05 November 2018 08:26 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AD29A12EB11 for <quic-issues@ietfa.amsl.com>; Mon, 5 Nov 2018 00:26:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Mzb44mGyalFI for <quic-issues@ietfa.amsl.com>; Mon, 5 Nov 2018 00:26:06 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B30981274D0 for <quic-issues@ietf.org>; Mon, 5 Nov 2018 00:26:06 -0800 (PST)
Date: Mon, 05 Nov 2018 00:26:05 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1541406365; bh=jnp5eeuEdjoaykSlpc1jLb+ffW6jdISmQwZmdIWCU6A=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=NzB707crwWbR5rZh6q7ZnVI9RusnOXuQwes985W/erANP3r6hlPQMcWq87hVFqFLo a1VP/p7XMxyo8GUe9prZnk6GX/Uz4Ma3ipdiEcjzBtyUjPBpERqF0BMsrg+3Yi/kJo TPve+ogdNVxn5EepROKFidrEvteCz96I9YBeKHEs=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab42ecd84186a5b189f5c86372d4b75ba737f6caa092cf0000000117f7c09d92a169ce167cded5@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1965/review/171445838@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1965@github.com>
References: <quicwg/base-drafts/pull/1965@github.com>
Subject: Re: [quicwg/base-drafts] Prevent an unlikely deadlock (#1965)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bdffe9d8529e_3def3fa630ed45c081398"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/p8g8ylPaSRvjhZieG7gJU4MefFg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Nov 2018 08:26:09 -0000
martinduke approved this pull request. I agree with the concept, though I have some problems with the explanatory text. One zoom-out question about TLP in QUIC: If there's a tail loss, you'll have to wait for an entire delayed-ack timeout to send, wait at worst for another DAT to get the ack, then a reordering timeout to declare the intervening packets lost. How does that compare to a plain old RTO? > @@ -418,6 +418,12 @@ used to send a probe into the network prior to establishing any packet loss, prior unacknowledged packets SHOULD NOT be marked as lost when a TLP timer expires. +If no new data or unacknowledged data is available to send, a retransmittable +frame SHOULD be sent. Sending a retransmittable frame ensures that any in +flight packets are acknowledged or declared lost in a timely manner, I don't think TLP accelerates acknowledgment of in-flight pkts unless you happen to hit what the maximum number of delayed-acked pkts are. So I would delete "acknowledged or" > @@ -418,6 +418,12 @@ used to send a probe into the network prior to establishing any packet loss, prior unacknowledged packets SHOULD NOT be marked as lost when a TLP timer expires. +If no new data or unacknowledged data is available to send, a retransmittable +frame SHOULD be sent. Sending a retransmittable frame ensures that any in +flight packets are acknowledged or declared lost in a timely manner, +potentially preventing a deadlock if all in flight packets contain no data Delete everything after "deadlock." -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1965#pullrequestreview-171445838
- [quicwg/base-drafts] Prevent an unlikely deadlock… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… martinduke
- Re: [quicwg/base-drafts] Prevent an unlikely dead… martinduke
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… martinduke
- Re: [quicwg/base-drafts] Prevent an unlikely dead… martinduke
- Re: [quicwg/base-drafts] Prevent an unlikely dead… martinduke
- Re: [quicwg/base-drafts] Prevent an unlikely dead… Mike Bishop
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ekr
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… MikkelFJ
- Re: [quicwg/base-drafts] Prevent an unlikely dead… Matt Olson
- Re: [quicwg/base-drafts] Prevent an unlikely dead… Nick Banks
- Re: [quicwg/base-drafts] Prevent an unlikely dead… MikkelFJ
- Re: [quicwg/base-drafts] Prevent an unlikely dead… Nick Banks
- Re: [quicwg/base-drafts] Prevent an unlikely dead… Nick Banks
- Re: [quicwg/base-drafts] Prevent an unlikely dead… MikkelFJ
- Re: [quicwg/base-drafts] Prevent an unlikely dead… MikkelFJ
- Re: [quicwg/base-drafts] Prevent an unlikely dead… Mike Bishop
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… martinduke
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Prevent an unlikely dead… ianswett
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… ianswett
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… martinduke
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… ianswett
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… janaiyengar
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… ianswett
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… ianswett
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… ianswett
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… janaiyengar
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… janaiyengar
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… janaiyengar
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… ianswett
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… martinduke
- Re: [quicwg/base-drafts] Use PTO to declare in-fl… ianswett