IETF Logo Mail Archive

Re: [quicwg/base-drafts] Prevent an unlikely deadlock (#1965)

martinduke <notifications@github.com> Wed, 19 December 2018 06:45 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F58312D84D for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 22:45:52 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Level:
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RjglCjsjwxH3 for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 22:45:50 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5DDAB124408 for <quic-issues@ietf.org>; Tue, 18 Dec 2018 22:45:50 -0800 (PST)
Date: Tue, 18 Dec 2018 22:45:49 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545201949; bh=x+20SH0IzXzRuZxTSlTzrPIUF7FtG+P3Qjpu2cmo+4U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=CrAY6YenAc9QOI6W8YDft9aJ9LbKMmRUWRbaEzH9eWXSn5sujN3ncmy2fAD+CYUUH DUb7OgaoxnSJgTmCdIGu9dl2UYhRos1tOutpzvwz874RJxXf8T6SdSYNj/0hML/azp d9D8Z/fKNDuNOzOBx8wGsUUQvIdW6dtTyJwgWv5M=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab870468ccb3dc05dc295b8bac0306813410d41c0692cf000000011831ab1d92a169ce167cded5@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1965/c448487557@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1965@github.com>
References: <quicwg/base-drafts/pull/1965@github.com>
Subject: Re: [quicwg/base-drafts] Prevent an unlikely deadlock (#1965)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c19e91d327d4_40d73f8c6cad45c025521b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/PpkWNlp6onXMEzaYE4fNL95bcqg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Dec 2018 06:45:52 -0000

@nibanks The simplest way for this to happen is that the first TLP timeout resends some data, and then the original is acked. Thus we have an in-flight packet (the retransmission) but the actual application data is already gone from the send buffer.

The TLP timer will fire again, and there's nothing to send.

@ianswett There are still some problems with the new text. The main practical impact is that we will delay declaring the last packet lost, meaning we won't free up the flightsize or execute a congestion response as quickly. I'm having a little trouble reasoning about the full implications of this for new data.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1965#issuecomment-448487557

v2.23.0 | Report a Bug | By Email