Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)

Mike Bishop <notifications@github.com> Fri, 11 October 2019 15:13 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1A9E3120073 for <quic-issues@ietfa.amsl.com>; Fri, 11 Oct 2019 08:13:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Br7rqoh1t5CY for <quic-issues@ietfa.amsl.com>; Fri, 11 Oct 2019 08:13:26 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A407F1200B4 for <quic-issues@ietf.org>; Fri, 11 Oct 2019 08:13:26 -0700 (PDT)
Received: from github-lowworker-edec459.ac4-iad.github.net (github-lowworker-edec459.ac4-iad.github.net [10.52.18.32]) by smtp.github.com (Postfix) with ESMTP id A38E4C60394 for <quic-issues@ietf.org>; Fri, 11 Oct 2019 08:13:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1570806805; bh=ylNXHAoYLKRbHINEa2C1lk6thYwNFQ01CFcGF3b856Q=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wK02hyKvBbFrhH28R0/M6ZemRuQ3PgZ4H3yuyTKQ7TRb8P0EjE+yPJi55HYazlAGE XMvzmggMGOmENW6uWh/t5DHn+wNbBX1EeiVg5jgyBCst+49qoxLVKv08jygdNuIU6J Q42bXIDrDbPGWAQJ6/SCOWidiTsZ6k2fD2MC+dqk=
Date: Fri, 11 Oct 2019 08:13:25 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKY2MP2PPIALAKI4VGN3VXOKLEVBNHHB4DMTGA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3083/review/300753804@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3083@github.com>
References: <quicwg/base-drafts/pull/3083@github.com>
Subject: Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da09c1593eed_6c393fd229acd95c10309b"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/3qRl_qOi6wdvvCAHqxGSCQIL6p4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Oct 2019 15:13:30 -0000

MikeBishop commented on this pull request.



> @@ -1071,7 +1071,8 @@ When a server receives this frame, it aborts sending the response for the
 identified server push.  If the server has not yet started to send the server
 push, it can use the receipt of a CANCEL_PUSH frame to avoid opening a push
 stream.  If the push stream has been opened by the server, the server SHOULD

The logic there is that, even if the stream is closed (FIN sent), there might still be value in sending a RESET_STREAM to abort any retransmissions.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3083#discussion_r334041847