Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)

ianswett <> Thu, 10 October 2019 18:44 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 73F78120142 for <>; Thu, 10 Oct 2019 11:44:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id UcnGK92NmSWZ for <>; Thu, 10 Oct 2019 11:44:46 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id B01E6120127 for <>; Thu, 10 Oct 2019 11:44:46 -0700 (PDT)
Received: from ( []) by (Postfix) with ESMTP id BEBFB521112 for <>; Thu, 10 Oct 2019 11:44:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1570733085; bh=AC1DyAAeUSDFMmldeRuPrWbZJOaviUuTCkw1KCi03oE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Y3bvCZML6DV325baw04HGr1FbqwVkmNPy60rxZWuhaJ55e2yXzIJqdo3iGxSWeMxn LwhGXyXtXFHmkngI5pprszh+QEyMpffYEPqhPk+FxHnseXASGXCKtHULjWJCGUeNMo zz7T9PDei/5ppNEhGGbe+Yryq7nTvJjFk/+ZPg/E=
Date: Thu, 10 Oct 2019 11:44:45 -0700
From: ianswett <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3083/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d9f7c1daf45d_afa3fd5c26cd964872dd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Thu, 10 Oct 2019 18:44:49 -0000

ianswett commented on this pull request.

> @@ -1093,10 +1094,15 @@ error of type HTTP_FRAME_UNEXPECTED.
 The CANCEL_PUSH frame carries a Push ID encoded as a variable-length integer.
 The Push ID identifies the server push that is being cancelled (see
+{{frame-push-promise}}).  If a CANCEL_PUSH frame is received which references a
+Push ID greater than currently allowed on the connection, this MUST be treated

Should this only be enforced by the client, given it's the one limiting the number of pushes?  The next paragraph discusses the server closing the connection when the client sends a CANCEL_PUSH mentioning a push ID that's never been used by the server.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: