Re: [quicwg/base-drafts] use TRANSPORT_PARAMETER_ERROR when authenticating connection IDs (#3691)

Martin Thomson <notifications@github.com> Wed, 27 May 2020 03:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CED9E3A0DB9 for <quic-issues@ietfa.amsl.com>; Tue, 26 May 2020 20:42:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c-rRo-0nI4Ys for <quic-issues@ietfa.amsl.com>; Tue, 26 May 2020 20:42:15 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7B2FC3A0DB8 for <quic-issues@ietf.org>; Tue, 26 May 2020 20:42:15 -0700 (PDT)
Received: from github-lowworker-cd7bc13.ac4-iad.github.net (github-lowworker-cd7bc13.ac4-iad.github.net [10.52.25.102]) by smtp.github.com (Postfix) with ESMTP id D9F6B6E0768 for <quic-issues@ietf.org>; Tue, 26 May 2020 20:42:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590550934; bh=pwGcV8C2iXiuih5/4D1EBCX636kvqHJUAQWfg4RSn0Q=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FToy9wY42OIYGep2GvTAey6wOTsCPfUTNTYOuTOGVlta9Gl1MnIzxSoyJwZRzftX7 tCClA2Mm4+Gs2LyessAkxwXLGbCnAfJz2nHvxcZGGfAvrzqOmloSbmOdH0CJ/lfhh5 7potDPF2jaDtx/BNZlyT+coYKJoYGrn/atrMRvac=
Date: Tue, 26 May 2020 20:42:14 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2KU2Z7MPZ5M7WCWHN43HBJNEVBNHHCKLSLMI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3691/review/418836032@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3691@github.com>
References: <quicwg/base-drafts/pull/3691@github.com>
Subject: Re: [quicwg/base-drafts] use TRANSPORT_PARAMETER_ERROR when authenticating connection IDs (#3691)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ecde196cb97d_78733ff8362cd968262318"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8_Bn0MoGSWqU_vC0LW2z_bL6ugk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 May 2020 03:42:17 -0000

@martinthomson commented on this pull request.



>  carrying attacker-chosen connection IDs during the handshake. An endpoint MUST
-treat any of the following as a connection error of type PROTOCOL_VIOLATION:
+treat any of the following as a connection error of type
+TRANSPORT_PARAMETER_ERROR:

A list is good here, but these aren't all equal.  In particular, the behaviour that is conditioned on whether a Retry was sent is not consistent with your principle.  I would argue that those are also PROTOCOL_VIOLATION cases.

If you agree, then you can move those two into the next list (which currently only has one item).  That leaves two items in this list and I think that can be turned back into prose.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3691#pullrequestreview-418836032