[quicwg/base-drafts] use TRANSPORT_PARAMETER_ERROR when authenticating connection IDs (#3691)

Marten Seemann <notifications@github.com> Sun, 24 May 2020 04:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C8F63A10B8 for <quic-issues@ietfa.amsl.com>; Sat, 23 May 2020 21:18:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.099
X-Spam-Level:
X-Spam-Status: No, score=-3.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lGhEmyEp3q-8 for <quic-issues@ietfa.amsl.com>; Sat, 23 May 2020 21:18:54 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8E8AA3A10B5 for <quic-issues@ietf.org>; Sat, 23 May 2020 21:18:54 -0700 (PDT)
Received: from github-lowworker-0eea13f.ash1-iad.github.net (github-lowworker-0eea13f.ash1-iad.github.net [10.56.109.26]) by smtp.github.com (Postfix) with ESMTP id 43884E0ABA for <quic-issues@ietf.org>; Sat, 23 May 2020 21:18:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590293932; bh=Vj0KtzNuv6cEQO6CEruAHXICYQ0BSHm75RV1+FFxpNk=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=v5rkpRRGCOJbVabrfqfK4t6jMVPwOqkbYuHJR3dmR0jqVirXVcl1ogHyid0pQqZdn 9MQNCRy9phXL1tKPpfiGuYeTX3MZoHCB7ao/PLC0MgaIKKw6F9chvwSBCZFRYHDjAy ZM67+0Y1gGZAvg3bjC3axo/UezmKHEGTRxkiY58M=
Date: Sat, 23 May 2020 21:18:52 -0700
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKY735IOXEJWHXVWHBF42XLKZEVBNHHCKLSLMI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3691@github.com>
Subject: [quicwg/base-drafts] use TRANSPORT_PARAMETER_ERROR when authenticating connection IDs (#3691)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ec9f5ac32cce_12283fd19accd96c950a6"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8mt3-z6ukwI8-3-vFf9C30Wg4z8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 24 May 2020 04:18:58 -0000

As discussed in https://github.com/quicwg/base-drafts/pull/3499/files#r422775281, most of the errors that can occur when authenticating connection IDs should be TRANSPORT_PARAMETER_ERRORs, not PROTOCOL_VIOLATIONs.

The guiding principle here (as we apply it for FRAME_ENCODING_ERRORs) is that if an error is detectable without accessing connection state, we use the more specific error. So for example, since `initial_source_connection_id` and `original_destination_connection_id` are required transport parameters, their absence should be responded to with a TRANSPORT_PARAMETER_ERROR. A similar argument applies to the absence of the `retry_source_connection_id` TP, although I can see how one might use PROTOCOL_VIOLATION here (note that this is still valid behavior with this PR, as every more specific error can be replaced with a PROTOCOL_VIOLATION, if an implementation wishes to do so).
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/3691

-- Commit Summary --

  * use TRANSPORT_PARAMETER_ERROR when authenticating connection IDs

-- File Changes --

    M draft-ietf-quic-transport.md (8)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/3691.patch
https://github.com/quicwg/base-drafts/pull/3691.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3691