IETF Logo Mail Archive

Re: [quicwg/base-drafts] Fix Recovery Pseudocode (#2907)

ianswett <notifications@github.com> Wed, 04 September 2019 00:15 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6164E12009C for <quic-issues@ietfa.amsl.com>; Tue, 3 Sep 2019 17:15:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fuau0WlBv9tf for <quic-issues@ietfa.amsl.com>; Tue, 3 Sep 2019 17:15:21 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7A7FF12006F for <quic-issues@ietf.org>; Tue, 3 Sep 2019 17:15:21 -0700 (PDT)
Date: Tue, 03 Sep 2019 17:15:20 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1567556120; bh=FXPv2fx+noh+gsN1WLPfo7mrkwiWVlQz1hEnji+BVOA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oXVxJLL6yA4k+dc+jMrto8wXpDWbYF7xAJu6WIWB2bcyJtq7p8M4/QV16VR0rJnJa TV2b3BNlkoYn3jDwTyatTQUXlmKQsCcpcP1tBJk60qPFoCXZwZOrqVUML59soUb70E DblrJrbowSoz5v1GoCoxIf9bGOBqsR8M7rMw/c+g=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYUTWDOYYP6ZZM5PAN3PRBKREVBNHHBX66EHQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2907/review/283322372@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2907@github.com>
References: <quicwg/base-drafts/pull/2907@github.com>
Subject: Re: [quicwg/base-drafts] Fix Recovery Pseudocode (#2907)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d6f02186fdd8_6ac63f7e330cd9601685bc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/CUZkpkMNiq8E0dbW-nsabmczF2A>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Sep 2019 00:15:24 -0000

ianswett commented on this pull request.



> @@ -1189,10 +1191,13 @@ SetLossDetectionTimer():
     loss_detection_timer.update(loss_time)
     return
 
-  // Don't arm timer if there are no ack-eliciting packets
-  // in flight and the handshake is complete.
-  if (endpoint is client with 1-RTT keys &&
-      no ack-eliciting packets in flight):
+  // Cancel the timer if there are no ack-eliciting packets
+  // in flight and the endpoint is a server. Do not cancel the
+  // timer until the client has received a Handshake or 1-RTT ACK.
+  if (no ack-eliciting packets in flight &&
+      (endpoint is server ||
+       has received Handshake ACK ||
+       has received 1-RTT ACK)):

As a code reviewer, I'd request a method like PeerAwaitingAddressValidation() and say 

if (no ack-eliciting packets in flight &&
     !PeerAwaitingAddressValidation()):

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2907#discussion_r320527773

v2.23.0 | Report a Bug | By Email