Re: [quicwg/base-drafts] Fix Recovery Pseudocode (#2907)
ianswett <notifications@github.com> Sun, 21 July 2019 11:29 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 88EC71200B5 for <quic-issues@ietfa.amsl.com>; Sun, 21 Jul 2019 04:29:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8BSb6iG4lRjU for <quic-issues@ietfa.amsl.com>; Sun, 21 Jul 2019 04:29:33 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 26AFA12009C for <quic-issues@ietf.org>; Sun, 21 Jul 2019 04:29:33 -0700 (PDT)
Date: Sun, 21 Jul 2019 04:29:32 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1563708572; bh=gTGyEICQ96uEXBM3tohLZD7DLZD4WfnppMgNWVnGFAc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TYWV5BB6SEm2unUa9AyXxqQVH98t4HglBRYec/inTlrzyhQJFTdT2VEKCI1phFJV3 WxlFYWduwt1++VUVf6pR0t/p2hi9PBT9le2+AIRqU/FixyQgNT8m6Mq7YAdxOLZ/iv aZ/ZEt8IV2LXw7ao/0hDnO9gGOC+pYLyRgfC++dA=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZRUZB2VZYIPDLEN553IF7RZEVBNHHBX66EHQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2907/review/264532132@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2907@github.com>
References: <quicwg/base-drafts/pull/2907@github.com>
Subject: Re: [quicwg/base-drafts] Fix Recovery Pseudocode (#2907)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d344c9c1606a_285a3fd7c14cd9602136715"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_UU9UjuHeQM5Qo-Zp5SZ3pdO1qg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Jul 2019 11:29:34 -0000
ianswett commented on this pull request. > @@ -1175,7 +1175,7 @@ GetEarliestLossTime(): space = Initial for pn_space in [ Handshake, ApplicationData ]: if (loss_time[pn_space] != 0 && - (time == 0 || loss_time[pn_space] < time)): + (time == 0 or loss_time[pn_space] < time)): Prior to this PR, most of the pseudocode was && and || I realize, so I'm going back to that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2907#discussion_r305613331
- [quicwg/base-drafts] Fix Recovery Pseudocode (#29… ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Martin Thomson
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Martin Thomson
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … martinduke
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … martinduke
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Martin Thomson
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Martin Thomson
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … martinduke
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Martin Thomson
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Martin Thomson
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Martin Thomson
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett