Re: [quicwg/base-drafts] Fix some of the nits in #3214 (#4016)

Martin Thomson <notifications@github.com> Mon, 24 August 2020 03:26 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1F24E3A0991 for <quic-issues@ietfa.amsl.com>; Sun, 23 Aug 2020 20:26:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.2
X-Spam-Level:
X-Spam-Status: No, score=-1.2 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UCuRDLg3QQ2e for <quic-issues@ietfa.amsl.com>; Sun, 23 Aug 2020 20:26:30 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A7E413A098E for <quic-issues@ietf.org>; Sun, 23 Aug 2020 20:26:30 -0700 (PDT)
Received: from github-lowworker-6b40fdd.va3-iad.github.net (github-lowworker-6b40fdd.va3-iad.github.net [10.48.16.64]) by smtp.github.com (Postfix) with ESMTP id CA6D35207DF for <quic-issues@ietf.org>; Sun, 23 Aug 2020 20:26:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1598239589; bh=ffMquzmQdXUgqymzJ2CPQuGZU1aVcejo0bn/0ZEwWsg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Wkft2gbEBeq33apnwCxzGTZlr7jRtyrvqPy1RwkFGtSAkWKWZSNU7nCdwfn7eXSKw r0UwQ29F+ImdADkeDpvmdGqFewn1bY6+ZizWBVmABuu5wHBsJjxbP0oybRrlokXy/c //9VAj/FedbpQQ93/Qk4FcZu1BXROehLJutZXB/U=
Date: Sun, 23 Aug 2020 20:26:29 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZNC3H67IKZRASBL3F5J4KGLEVBNHHCRJE2U4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4016/review/473080656@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4016@github.com>
References: <quicwg/base-drafts/pull/4016@github.com>
Subject: Re: [quicwg/base-drafts] Fix some of the nits in #3214 (#4016)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f433365b920f_5c519643719ac"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/EWYqYpP4KMZnNZw_ThmT2Q-iUCg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Aug 2020 03:26:32 -0000

@martinthomson approved this pull request.

Nits only.  Thanks for working through these.

> @@ -1076,8 +1076,9 @@ A zero-length connection ID can be used when a connection ID is not needed to
 route to the correct endpoint. However, multiplexing connections on the same
 local IP address and port while using zero-length connection IDs will cause
 failures in the presence of peer connection migration, NAT rebinding, and client
-port reuse; and therefore MUST NOT be done unless an endpoint is certain that
-those protocol features are not in use.
+port reuse. An endpoint MUST NOT use an IP address and port pair for multiple

```suggestion
port reuse. An endpoint MUST NOT use the same IP address and port for multiple
```

> +The definition of a new transport parameter ({{new-transport-parameters}}) is
+REQUIRED to specify whether it MUST, MAY, or MUST NOT be stored for 0-RTT. A

This is fine, but I tend to prefer:

```suggestion
The definition of a new transport parameter ({{new-transport-parameters}}) MUST
specify whether that storing the transport parameter for 0-RTT is mandatory, optional, or prohibited. A
```

(Whether an extension uses 2119 language or not is not relevant, the level of requirement is.  And as these keywords are not used in this context in the way described in RFC 2119, this is better.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4016#pullrequestreview-473080656