IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add EXTENSION frame (#1068)

martinduke <notifications@github.com> Thu, 25 January 2018 03:50 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D969A12E05C for <quic-issues@ietfa.amsl.com>; Wed, 24 Jan 2018 19:50:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.381
X-Spam-Level:
X-Spam-Status: No, score=-5.381 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gPx3NrWKZwnf for <quic-issues@ietfa.amsl.com>; Wed, 24 Jan 2018 19:50:20 -0800 (PST)
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2-ext2.iad.github.net [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4963112D950 for <quic-issues@ietf.org>; Wed, 24 Jan 2018 19:50:20 -0800 (PST)
Date: Wed, 24 Jan 2018 19:50:19 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1516852219; bh=WJHgu7N4n9MX1FlTKfTHHA1d5rgi2cYwgrS8T/8juZw=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hpChiU0Qsz1pbGVHuSVTtyaYxFWgS2QIRxQBOGIpvOtO3xfW/C3PZOEmh2UjzPEHe qz3HaRZC0kHgVBP0JZV74MmaE/dYXlkt9b6mX6DD916b4FM95dJJ4Rjh819aus7UsB mUi8dCskpStl8JQ5izC+29dKv04/CC9QsqvwxB6w=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8bf85b894cac9dfe0b45977aae16e71cec60c3ec92cf00000001168115fb92a169ce115ea54e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1068/c360353058@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1068@github.com>
References: <quicwg/base-drafts/pull/1068@github.com>
Subject: Re: [quicwg/base-drafts] Add EXTENSION frame (#1068)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5a6953fba1c06_aa22ad3aab58ecc1117dc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Kp08-UV-0Z4clOt8wIS5d4jOtZs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jan 2018 03:50:22 -0000

This all LGTM, though I'm mildly tempted to make the type field a varint. 64K is enough, but why not let it be shorter until we get to 64?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1068#issuecomment-360353058

v2.31.3 | Report a Bug | By Email | System Status