Re: [quicwg/base-drafts] renamed max_packet_size to max_udp_size (#3473)

[David Schinazi <[e-mail]>]

DavidSchinazi commented on this pull request.



>  
-: The maximum packet size parameter is an integer value that limits the size of
-  packets that the endpoint is willing to receive.  This indicates that packets
-  larger than this limit will be dropped.  The default for this parameter is the
-  maximum permitted UDP payload of 65527.  Values below 1200 are invalid.  This
-  limit only applies to protected packets ({{packet-protected}}).
+: The maximum udp size parameter is an integer value that limits the size of
+  UDP payloads that the endpoint is willing to receive.  This indicates that
+  packets larger than this limit are likely not to be processed by the receiver.

I would change this sentence to something like `This indicates that UDP packets whose payload is larger than this limit are likely not to be processed by the receiver.`


>  
-: The maximum packet size parameter is an integer value that limits the size of
-  packets that the endpoint is willing to receive.  This indicates that packets
-  larger than this limit will be dropped.  The default for this parameter is the
-  maximum permitted UDP payload of 65527.  Values below 1200 are invalid.  This
-  limit only applies to protected packets ({{packet-protected}}).
+: The maximum udp size parameter is an integer value that limits the size of
+  UDP payloads that the endpoint is willing to receive.  This indicates that
+  packets larger than this limit are likely not to be processed by the receiver.
+  The default for this parameter is the maximum permitted UDP payload of 65527.
+  Values below 1200 are invalid.  This limit only applies to protected packets

What was the rationale for this text: `This limit only applies to protected packets ({{packet-protected}}).` ? Given the new clarification, I think we should just remove this sentence.

> @@ -4584,13 +4584,14 @@ stateless_reset_token (0x0002):
   reset ({{stateless-reset}}) for the connection ID negotiated during the
   handshake.
 
-max_packet_size (0x0003):
+max_udp_size (0x0003):

I think `max_udp_payload_size` is clearer than `max_udp_size` but this is still better than `max_packet_size`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3473#pullrequestreview-362299331