Re: [quicwg/base-drafts] update the pseudo code to include packet number spaces (#2417)

[Jana Iyengar <[e-mail]>]

janaiyengar approved this pull request.

A couple of nits, but looks good. Thanks for doing this work! Yes, we don't have ER for crypto packets, but that was always true, and this PR makes it more explicit, which is good.

> @@ -890,8 +901,9 @@ follows:
    min_rtt = infinite
    time_of_last_sent_ack_eliciting_packet = 0
    time_of_last_sent_crypto_packet = 0
-   largest_sent_packet = 0
-   largest_acked_packet = 0
+   for pn_space in [ Initial, Handshake, Applicaton data ]:

```suggestion
   for pn_space in [ Initial, Handshake, ApplicatonData ]:
```

>      loss_detection_timer.update(
-      time_of_last_sent_ack_eliciting_packet + timeout)
+      time_of_last_sent_crypto_packet + timeout)
+    return
+  if (loss_time != 0):

```suggestion

  if (loss_time != 0):
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2417#pullrequestreview-201178586