Re: [quicwg/base-drafts] Rework Retry packet (#1498)
Martin Thomson <notifications@github.com> Fri, 29 June 2018 05:19 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EAE60130E55 for <quic-issues@ietfa.amsl.com>; Thu, 28 Jun 2018 22:19:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DdFh4MIhOgOU for <quic-issues@ietfa.amsl.com>; Thu, 28 Jun 2018 22:19:21 -0700 (PDT)
Received: from out-12.smtp.github.com (out-12.smtp.github.com [192.30.254.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E996A129C6A for <quic-issues@ietf.org>; Thu, 28 Jun 2018 22:19:20 -0700 (PDT)
Date: Thu, 28 Jun 2018 22:19:20 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530249560; bh=GpdBCqCJXO6uxI4GwcCJg3E2e9pOkESVcyyDwrYgcko=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oyXQ/0dK6dxgYprnmAKi8FuiUB1/vQ1vXH8oH7viFJvJ3zwFIFLZzTdCUZPNp6Qr5 m/W6wDjB+EATQSuCxVSZuGL8s9BPbIWiVycwg+GeB188U0UI37C5KmWUO09DILuewf UttE5D4ehg10hNf+TnMt+Zh3QV7Docs6Vz58PeBw=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab61128223b34f55b8c7310289b82db14674d9705d92cf00000001174d835892a169ce14138c09@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1498/review/133100353@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1498@github.com>
References: <quicwg/base-drafts/pull/1498@github.com>
Subject: Re: [quicwg/base-drafts] Rework Retry packet (#1498)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b35c1581e8f8_47ce3ff384d4af784533e7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pFiDPp45boMl4fpv5CXTrF_Zx0o>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jun 2018 05:19:24 -0000
martinthomson commented on this pull request. > + +A Retry packet does not include a packet number and cannot be explictly +acknowledged by a client. + +A server MUST only send a Retry in response to a client Initial packet. + +If the Original Destination Connection ID field does not match the Destination +Connection ID from most recent the Initial packet it sent, clients MUST discard +the packet. This prevents an off-path attacker from injecting a Retry packet +with a bogus new Source Connection ID. + +The client responds to a Retry packet with Initial packet that includes the +provided Retry Token to continue connection establishment. + +A server that might send another Retry packet in response to a subsequent +Initial packet MUST set the Source Connection ID to new value of at least 8 If things on the path aren't planning to terminate the connection (presumably they know this), then they can never send a token with <8. 8 is the number we picked for Initial. It seemed best to align with that. That's all. It's probably the case that 4 would give us equivalent defense against off-path attacks to the TCP handshake, but there is value in consistency here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1498#discussion_r199055162
- Re: [quicwg/base-drafts] Rework Retry packet (#14… janaiyengar
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Christian Huitema
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Kazuho Oku
- Re: [quicwg/base-drafts] Rework Retry packet (#14… ekr
- [quicwg/base-drafts] Rework Retry packet (#1498) Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… ekr
- Re: [quicwg/base-drafts] Rework Retry packet (#14… ianswett
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Mike Bishop
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… ianswett
- Re: [quicwg/base-drafts] Rework Retry packet (#14… ianswett
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Christian Huitema
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Mike Bishop
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Mike Bishop
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Marten Seemann
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Christian Huitema
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Marten Seemann
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson