Re: [quicwg/base-drafts] Use "Insert Count" rather than "Largest Reference" (#2111)

[afrind <[e-mail]>]

afrind commented on this pull request.

I'm not crazy about just 'Base'.  Does 'Base Count' or 'Base Insert Count' read any better to you?

>  
 When blocking references are permitted, the encoder uses header block
-acknowledgement to identify the Largest Known Received index, as described in
+acknowledgement to identify the Known Received Count, as described in

s/identify/maintain/ ?

>  
 ~~~~~ drawing
-             Base Index
-                 |
-                 V
+ Required
+  Insert
+  Count      Base
+    |         |
+    V         V

I would still have these point at the boxes (where the numbers are) rather than the lines.

>  
 ~~~~~ drawing
-             Base Index
-                 |
-                 V
+ Required
+  Insert
+  Count      Base
+    |         |
+    V         V

Also, not sure we need Required Insert Count in this drawing.  The section is describing relative indexing so it's not really adding anything?

>  
-`Largest Reference` identifies the largest absolute dynamic index referenced in
-the block.  Blocking decoders use the Largest Reference to determine when it is
-safe to process the rest of the block.  If Largest Reference is greater than
-zero, the encoder transforms it as follows before encoding:
+#### Required Insert Count {#ric}
+
+Required Insert Count identifies the state of the dynamic table needed to
+process the header block successfully.  Blocking decoders use the Required

Does 'successfully' add much here?

> @@ -923,10 +961,9 @@ header field name matches the header field name of an entry stored in the static
 table or the dynamic table.
 
 If the entry is in the static table, or in the dynamic table with an absolute
-index less than or equal to Base Index, this representation starts with the '01'
-two-bit pattern.  If the entry is in the dynamic table with an absolute index
-greater than Base Index, the representation starts with the '0000' four-bit
-pattern.
+index less than the Base, this representation starts with the '01' two-bit
+pattern.  If the entry is in the dynamic table with an absolute index greater
+than the Base, the representation starts with the '0000' four-bit pattern.

Something is off here because it doesn't say what to do if Base and the Absolute Index of the entry are equal.  If Base is the Insert Count when encoding started, then we need to use post-base indexing if the entry is greater than or equal to base.

>  
 ### Literal Header Field With Post-Base Name Reference
 
-For entries in the dynamic table with an absolute index greater than Base Index,
-the header field name is represented using the post-base index of that entry
-(see {{post-base-indexing}}) encoded as an integer with a 3-bit prefix.
+For entries in the dynamic table with an absolute index greater than or equal to
+the Base, the header field name is represented using the post-base index of that

or equal?  per above.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2111#pullrequestreview-190497904