Re: [lamps] WG Last Call for draft-ietf-lamps-pkcs12-pbmac1-02

Hubert Kario <hkario@redhat.com> Tue, 07 November 2023 15:31 UTC

Return-Path: <hkario@redhat.com>
X-Original-To: spasm@ietfa.amsl.com
Delivered-To: spasm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 45C9FC1CB006 for <spasm@ietfa.amsl.com>; Tue, 7 Nov 2023 07:31:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.106
X-Spam-Level:
X-Spam-Status: No, score=-7.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0TebFhcrGbBX for <spasm@ietfa.amsl.com>; Tue, 7 Nov 2023 07:31:29 -0800 (PST)
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B2A74C1CB004 for <spasm@ietf.org>; Tue, 7 Nov 2023 07:31:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699371088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4NoKZrw7gFKzPWqwTEQr7Qw4UK2PvHmy3sFyFyyNM2o=; b=H8ep5H13vNCqgQHoY/wv+aF/DfF22yUmEuInrn2VoJ3zW7K3eWLc31FGCIMTQSp5Vf3X16 AAU4EhQ8fFNkyjM8aVCG9syECGmTUkNNiLxt2+gm0LyPXKbxuBSHvcjVWzCkOh5JDm1x0a fevd6gEhUgTjVpX+TK8AwSaXbH+1YEM=
Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-_GkXqE4yPXOgEwljVby7Hg-1; Tue, 07 Nov 2023 10:31:27 -0500
X-MC-Unique: _GkXqE4yPXOgEwljVby7Hg-1
Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-45dad127a7eso1385177137.2 for <spasm@ietf.org>; Tue, 07 Nov 2023 07:31:27 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699371086; x=1699975886; h=content-transfer-encoding:user-agent:organization:references :in-reply-to:message-id:mime-version:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IzTFpdc6Jg30C1LJSKLmaF8hTbXZWhZ4i82utKG4reo=; b=CQuInvhbVC2XV9r2jl05e6yrKQMHcsm71GhTNDnevCH9MAxBDk8TyMrmADFQkx8hsV xOwXbypWSkZDdbnckrfq31hr2Jqw2MPIG3LfRSdW2unbKYF/Ov5EZ+YxtrYhQw/VG9TO yKX1kOhyF7iMUljNR8s7/TVZwklkgLs6B7oehmS+48agRUx8y04Efw0PB/ECEoY38Vas Ss+E3GxG25saiQzwnH8rP8uFCxtZkMr/0UqcReqjlR5ZHnTLPE7vudY/YsqhZ9jtq42A jFR9H6ejyvGpvOEXhj3v1VP7j9cMWLLFCOgDkm09I0+h0j29hFszIVz8Gkz+WjvTn7/5 mwbA==
X-Gm-Message-State: AOJu0Yx48oms4CcPWIn+E9bZdksx7o2UuQpy3BUZBc7Y7nmsYseeKLFG 889TmBOpAn5vUjHESICQ/aVTYs3UymIiNJMehEXL6fW5J2pMC8t9500Ux+Z2WYvqGbWdE+gPIkb xBlH2VHOntsVTGw==
X-Received: by 2002:a67:c201:0:b0:45f:5d1:9c5e with SMTP id i1-20020a67c201000000b0045f05d19c5emr7484929vsj.9.1699371086639; Tue, 07 Nov 2023 07:31:26 -0800 (PST)
X-Google-Smtp-Source: AGHT+IG2jGyUM4ToV+e31CAN5uxMVvCd+mCaKVFKBbGV9rSxhoRSezIcTWjEN+p4xMNzUzJSTzQdgQ==
X-Received: by 2002:a67:c201:0:b0:45f:5d1:9c5e with SMTP id i1-20020a67c201000000b0045f05d19c5emr7484908vsj.9.1699371086308; Tue, 07 Nov 2023 07:31:26 -0800 (PST)
Received: from localhost (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id e13-20020ad4418d000000b006263a9e7c63sm4396151qvp.104.2023.11.07.07.31.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 07:31:25 -0800 (PST)
From: Hubert Kario <hkario@redhat.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "Salz, Rich" <rsalz=40akamai.com@dmarc.ietf.org>, Russ Housley <housley@vigilsec.com>, LAMPS <spasm@ietf.org>
Date: Tue, 07 Nov 2023 16:31:23 +0100
MIME-Version: 1.0
Message-ID: <9388a24d-36a5-468c-b824-2db67240ff62@redhat.com>
In-Reply-To: <d3f39b48532d0737c52f6f124fa335e6b2a979b6.camel@infradead.org>
References: <C61AE8CA-3692-43E0-ACE4-8BB0DEDB6D8B@vigilsec.com> <49C2F154-5545-4B33-8F82-F0E117E27A72@akamai.com> <11ee8b09d53b1e250b931384bb05e92bbcbf8191.camel@infradead.org> <78114a97-b76e-414f-bef1-ce93bb93728a@redhat.com> <029c803a7d4a931076d9b1ac52881f127fd99272.camel@infradead.org> <6cc34c56-3211-421f-b94d-dcd5e73bbe1e@redhat.com> <244e5470c740a85bb87e83645b537883dcdf4aa0.camel@infradead.org> <eb3f87cc-af9a-463a-a17e-2f056ee1e14f@redhat.com> <7825bd846ac983257be347b991f455d44e087681.camel@infradead.org> <b5da4714-fead-4a95-9d4c-4169d79acf3c@redhat.com> <23453e52e5128cd4eb96e04c3da2d294c3df0579.camel@infradead.org> <117b8392-dc50-4780-bbcf-6f5a0b265276@redhat.com> <6f23a98cd5cba98f43a2e833c1f2774e251c5530.camel@infradead.org> <75d6db69-b47f-4599-9bb5-4273aa130066@redhat.com> <d3f39b48532d0737c52f6f124fa335e6b2a979b6.camel@infradead.org>
Organization: Red Hat
User-Agent: Trojita/0.7-git; Qt/5.15.9; xcb; Linux; Fedora release 37 (Thirty Seven)
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/spasm/A-P0FOYzhZzlxjUmUR3mnFeQvo4>
Subject: Re: [lamps] WG Last Call for draft-ietf-lamps-pkcs12-pbmac1-02
X-BeenThere: spasm@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: This is the mail list for the LAMPS Working Group <spasm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/spasm>, <mailto:spasm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spasm/>
List-Post: <mailto:spasm@ietf.org>
List-Help: <mailto:spasm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/spasm>, <mailto:spasm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Nov 2023 15:31:30 -0000

My explicit goal for draft-ietf-lamps-pkcs12-pbmac1 is to NOT
influence how PBES1 or PBES2 is done. However the password is
handled by the library, it should just continue to do the same
thing, but instead of passing it to the legacy mac calculation,
pass it to PBMAC1 and then to PBKDF2 or something else.

So, no, I will not be adding additional test vectors as those
are unnecessary to ensure that.

If you want to standardise how passwords outside 7-bit ASCII range
are to be handled, I'm willing to contribute to that draft,
but I consider it completely out of scope and a distraction for
the purpose of introducing PBMAC1.

Unless Chairs state otherwise, I consider this discussion finished.

On Tuesday, 7 November 2023 07:50:43 CET, David Woodhouse wrote:
> On Mon, 2023-11-06 at 21:42 +0100, Hubert Kario wrote:
>> 
>> That's the issue: NFC isn't the correct normalisation because it will
>> leave ligatures intact. And with people copying passwords from pdf
>> files there's non-zero chance of it including ligatures.
>
> Honestly, if you put a password into a PDF and allow it to use
> ligatures and expect users to cut and paste… that isn't a problem we're
> trying to solve today. And 'f' and 'i' are in ASCII anyway. Does that
> mean you'd be disinclined to use a test password of 'fish' too?
>
>> So there's two of us and we already are disagreeing about the correct
>> normalisation form for passwords: precisely the reason why I don't
>> want to touch it.
>
> I agree that it's out of scope. As is the input method. And the means
> (PDF or otherwise) by which it's communicated to the user, if such
> occurs.
>
> But once we get to PKCS#12 with a password character sequence of U+2460
> U+00B2 U+00B3 U+FF14, *however* we got that, from then *on* it's
> perfectly defined and can be tested.
>
> The lack of normalization of our normalization doesn't have to stop us
> exercising the basic character encoding. Which *sorely* needs testing.
>
>

-- 
Regards,
Hubert Kario
Principal Quality Engineer, RHEL Crypto team
Web: www.cz.redhat.com
Red Hat Czech s.r.o., Purkyňova 99/71, 612 45, Brno, Czech Republic