Re: [lamps] WG Last Call for draft-ietf-lamps-pkcs12-pbmac1-02

Hubert Kario <hkario@redhat.com> Wed, 25 October 2023 17:28 UTC

Return-Path: <hkario@redhat.com>
X-Original-To: spasm@ietfa.amsl.com
Delivered-To: spasm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8EF5DC1705FE for <spasm@ietfa.amsl.com>; Wed, 25 Oct 2023 10:28:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.106
X-Spam-Level:
X-Spam-Status: No, score=-2.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4ssELKq1YUQs for <spasm@ietfa.amsl.com>; Wed, 25 Oct 2023 10:28:49 -0700 (PDT)
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4C797C1516E1 for <spasm@ietf.org>; Wed, 25 Oct 2023 10:28:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698254927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v4/XSYHlYTjggzPoSD6hrJkFfpcngMnXQYo9OFy4PmY=; b=Zr7biQBjJeZBoeoRzvel1ZroJ/1IVdujEv8UARsV5cvh9JBqXfdfBGBGgWZe6H5KDwpZq9 cdbmudZcQIedHY9/iN3eGp1K//oOGiIxsXLx+yZb9cuAOW9u73BNe4dBq0+eR+y89pvKUL goblO/GY5IcIEqa6tZjqJgJNhhJNNCI=
Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487-FPbeFcRrNZ-jz_Hz3pymoQ-1; Wed, 25 Oct 2023 13:28:31 -0400
X-MC-Unique: FPbeFcRrNZ-jz_Hz3pymoQ-1
Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-9bd7c682b33so1012066b.3 for <spasm@ietf.org>; Wed, 25 Oct 2023 10:28:31 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698254910; x=1698859710; h=content-transfer-encoding:user-agent:organization:references :in-reply-to:message-id:mime-version:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VbtOveZkw//yZjZ7e0mTUR06xtpaMQ8zDTjDMPehGTI=; b=Dyx7JFMBvuCCarzE4sUxrm597ppiCcY2Dqm+B7WQFADmY/ZRj/LxWHaVgkuAhrcL9J ibKHUT5jWQS01MRaSOoKrBUce/XEtnIQn9FxLPzSPB1ODRG5AWu5M8TcWyQC5Vlk28P4 1fIaiBKMho7HfYFo+imBiQwN9AxLWgs3uXraDtIBoT6InhUo5O+xedh0SUw8T9nzmI0v z4XjkK29jCs782wkxmDjZlkgeS8C45bMNuejZk50+BGpkg4vEYx0c7Lj/xpodSWZANKC dUcsrhtNX553Z3w4GUlmodrsbealGybbhNxZmWnXqLCK96eM0R5DIW+v+z3O9KTwuMRQ Sjrw==
X-Gm-Message-State: AOJu0YywY3xRNPpJWYXR//hE98uUlZsBoyPInKoOTUSKXFRLYbevy0Oz qgEilCnuVJ/pYbtK4w+opZtFqR6+rG1o7KRp1ObSV0sp6wTVU9ldqTW3pbw/grwlHvElhvSw/gp sxL/c2g==
X-Received: by 2002:a17:907:7da3:b0:9c3:cd12:1927 with SMTP id oz35-20020a1709077da300b009c3cd121927mr11168757ejc.5.1698254910488; Wed, 25 Oct 2023 10:28:30 -0700 (PDT)
X-Google-Smtp-Source: AGHT+IGHOf+bmrK7mFJURiIRY3CgGQ9V5vwq1TrWayGkb1D9PKto7Se7+M8qoUQQOyqMiAkhJzo/vg==
X-Received: by 2002:a17:907:7da3:b0:9c3:cd12:1927 with SMTP id oz35-20020a1709077da300b009c3cd121927mr11168747ejc.5.1698254910179; Wed, 25 Oct 2023 10:28:30 -0700 (PDT)
Received: from localhost (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id ay18-20020a170906d29200b009b2c5363ebasm10179240ejb.26.2023.10.25.10.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 10:28:30 -0700 (PDT)
From: Hubert Kario <hkario@redhat.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "Salz, Rich" <rsalz=40akamai.com@dmarc.ietf.org>, Russ Housley <housley@vigilsec.com>, LAMPS <spasm@ietf.org>
Date: Wed, 25 Oct 2023 19:28:29 +0200
MIME-Version: 1.0
Message-ID: <78114a97-b76e-414f-bef1-ce93bb93728a@redhat.com>
In-Reply-To: <11ee8b09d53b1e250b931384bb05e92bbcbf8191.camel@infradead.org>
References: <C61AE8CA-3692-43E0-ACE4-8BB0DEDB6D8B@vigilsec.com> <49C2F154-5545-4B33-8F82-F0E117E27A72@akamai.com> <11ee8b09d53b1e250b931384bb05e92bbcbf8191.camel@infradead.org>
Organization: Red Hat
User-Agent: Trojita/0.7-git; Qt/5.15.9; xcb; Linux; Fedora release 37 (Thirty Seven)
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/spasm/ppWsn2dzu5vUaW9Us1rlPA3Rmio>
Subject: Re: [lamps] WG Last Call for draft-ietf-lamps-pkcs12-pbmac1-02
X-BeenThere: spasm@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: This is the mail list for the LAMPS Working Group <spasm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/spasm>, <mailto:spasm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spasm/>
List-Post: <mailto:spasm@ietf.org>
List-Help: <mailto:spasm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/spasm>, <mailto:spasm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Oct 2023 17:28:53 -0000

On Wednesday, 11 October 2023 00:02:41 CEST, David Woodhouse wrote:
> On Tue, 2023-10-10 at 19:26 +0000, Salz, Rich wrote:
>>> Title: Use of Password Based Message Authentication Code 1 (PBMAC1)
>>> in PKCS #12 Syntax
>>> Should the LAMPS WG ask the IESG to publish this document as an
>>> Informational RFC? Please respond to this WG last Call by 24
>>> October 2024.
>> 
>> 
>> Yes. The document is clear and easy to understand and has a nice set
>> of test vectors.
>
> I respectfully disagree that the set of test vectors is 'nice'.
>
> The password for them all is "1234". That's not much of a test.
>
> Ideally the password should contain at least one character outside
> ASCII. And preferably outside the BMP. And maybe something that would
> be represented differently in NFC vs. other normalization forms, for
> extra fun.
>
> Once we start thinking about that... is it actually fully specified?
>
> The draft refers to RFC8018 but RFC8018 itself doesn't specify the
> character set to be used for passwords, does it? It merely hints that
> "ASCII and UTF-8 are two possibilities" ... but are actually one
> because ASCII is a subset of UTF-8.
>
> Does this draft implicitly fall under the auspices of §B.1 of RFC7292,
> which laments that fact about RFC8018, and tells us that "all passwords
> are created from BMPStrings with a NULL[sic] terminator"? If so, could
> it be made *explicit* just for clarity?
>
> And could we specify the normalization while we're at it?

Specified it as "do the same as you do for PBES1 or PBES2":
https://github.com/tomato42/id-pkcs12-pbmac1/pull/4
is that acceptable to you?
-- 
Regards,
Hubert Kario
Principal Quality Engineer, RHEL Crypto team
Web: www.cz.redhat.com
Red Hat Czech s.r.o., Purkyňova 99/71, 612 45, Brno, Czech Republic