Re: [auth48] [AD] AUTH48: RFC-to-be 9277 <draft-ietf-cbor-file-magic-12> for your review

Sandy Ginoza <sginoza@amsl.com> Fri, 05 August 2022 17:02 UTC

Return-Path: <sginoza@amsl.com>
X-Original-To: auth48archive@ietfa.amsl.com
Delivered-To: auth48archive@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 23986C16ECF9; Fri, 5 Aug 2022 10:02:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.908
X-Spam-Level:
X-Spam-Status: No, score=-6.908 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eEtFJWx0fhhA; Fri, 5 Aug 2022 10:02:51 -0700 (PDT)
Received: from c8a.amsl.com (c8a.amsl.com [4.31.198.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C2382C157B49; Fri, 5 Aug 2022 10:02:51 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by c8a.amsl.com (Postfix) with ESMTP id A04C3424B44D; Fri, 5 Aug 2022 10:02:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
Received: from c8a.amsl.com ([127.0.0.1]) by localhost (c8a.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YwndGSj3mALe; Fri, 5 Aug 2022 10:02:51 -0700 (PDT)
Received: from smtpclient.apple (2603-8000-9603-b513-49bd-4304-9889-70eb.res6.spectrum.com [IPv6:2603:8000:9603:b513:49bd:4304:9889:70eb]) by c8a.amsl.com (Postfix) with ESMTPSA id 55D17424B446; Fri, 5 Aug 2022 10:02:51 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
From: Sandy Ginoza <sginoza@amsl.com>
In-Reply-To: <4B486C33-842C-4E0D-88CA-D4B9D9007D2D@tzi.org>
Date: Fri, 05 Aug 2022 10:02:38 -0700
Cc: RFC Editor <rfc-editor@rfc-editor.org>, Michael Richardson <mcr+ietf@sandelman.ca>, cbor-ads@ietf.org, cbor-chairs@ietf.org, Christian Amsüss <christian@amsuess.com>, auth48archive@rfc-editor.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <055AE9FA-B00A-4B05-8B43-D33B93873103@amsl.com>
References: <20220803210827.2D4B455D45@rfcpa.amsl.com> <A72D6D20-35C9-4D83-95BF-B1FA5DC92821@tzi.org> <15BA74A8-D16D-456E-9C7C-DB00D4786605@amsl.com> <805A67C7-6E3E-4B0C-925F-CD8F99A5970F@tzi.org> <4A805B5F-87D1-4B64-BD95-A9BE76803EEE@amsl.com> <4B486C33-842C-4E0D-88CA-D4B9D9007D2D@tzi.org>
To: Carsten Bormann <cabo@tzi.org>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
Archived-At: <https://mailarchive.ietf.org/arch/msg/auth48archive/73SdaLnZBsZmytwc2pVY3fveTUU>
Subject: Re: [auth48] [AD] AUTH48: RFC-to-be 9277 <draft-ietf-cbor-file-magic-12> for your review
X-BeenThere: auth48archive@rfc-editor.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "Archiving AUTH48 exchanges between the RFC Production Center, the authors, and other related parties" <auth48archive.rfc-editor.org>
List-Unsubscribe: <https://mailman.rfc-editor.org/mailman/options/auth48archive>, <mailto:auth48archive-request@rfc-editor.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/auth48archive/>
List-Post: <mailto:auth48archive@rfc-editor.org>
List-Help: <mailto:auth48archive-request@rfc-editor.org?subject=help>
List-Subscribe: <https://mailman.rfc-editor.org/mailman/listinfo/auth48archive>, <mailto:auth48archive-request@rfc-editor.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Aug 2022 17:02:56 -0000

Hi Carsten,

Great - I’ve marked your approval on the AUTH48 page <http://www.rfc-editor.org/auth48/rfc9277>.  We’ll wait to hear from Michael and Murray as well before continuing with publication. 

Enjoy your vacation!
Sandy 

> On Aug 5, 2022, at 9:30 AM, Carsten Bormann <cabo@tzi.org> wrote:
> 
> Hi Sandy,
> 
> thank you for the very quick turnaround before I vanish into a vacation!
> I believe RFC 9277-to-be is now ready for publishing.
> 
> Grüße, Carsten
> 
>> On 2022-08-05, at 18:11, Sandy Ginoza <sginoza@amsl.com> wrote:
>> 
>> Hi Carsten,
>> 
>> Thanks for your thorough review.  The document has been updated as described below.  Please review and let us know if any additional updates are needed.
>> 
>> The files have been posted here:
>>  https://www.rfc-editor.org/authors/rfc9277.txt
>>  https://www.rfc-editor.org/authors/rfc9277.pdf
>>  https://www.rfc-editor.org/authors/rfc9277.html
>>  https://www.rfc-editor.org/authors/rfc9277.xml
>> 
>> These diffs highlight the only the recent updates:
>>  https://www.rfc-editor.org/authors/rfc9277-lastdiff.html
>>  https://www.rfc-editor.org/authors/rfc9277-lastrfcdiff.html (side by side)
>> 
>> AUTH48 diff: 
>>  https://www.rfc-editor.org/authors/rfc9277-auth48diff.html
>> 
>> Comprehensive diffs: 
>>  https://www.rfc-editor.org/authors/rfc9277-diff.html
>>  https://www.rfc-editor.org/authors/rfc9277-rfcdiff.html (side by side)
>> 
>> Thanks,
>> Sandy 
>> 
>> 
>> 
>>> On Aug 5, 2022, at 5:47 AM, Carsten Bormann <cabo@tzi.org> wrote:
>>> 
>>> Hi Sandy,
>>> 
>>>> On 5. Aug 2022, at 04:38, Sandy Ginoza <sginoza@amsl.com> wrote:
>>>> 
>>>> We have updated the document as described below, with a few minor updates (e.g., added commas or abbreviation expansion). 
>>> 
>>> Thank you.
>>> 
>>> Here are my comments from a full reread:
>>> 
>>> (1)
>>> Abstract:
>>> OLD:
>>> This document defines a stored ("file") format for Consice Binary
>>> NEW:
>>> This document defines a stored ("file") format for Concise Binary
>>> 
>>> (2)
>>> 1. Introduction:
>>> OLD:
>>> certain ASN.1-based systems where most files are Privacy-
>>> Enhanced Mail (PEM) encoded; 
>>> NEW:
>>> certain ASN.1-based systems where most files are Privacy-Enhanced Mail (PEM) encoded; 
>>> 
>>> (No space after Privacy-.)
>>> 
>>> (3)
>>> 1. Introduction:
>>> OLD:
>>> determine it by other means.  For instance, in classical macOS, a
>>> NEW:
>>> determine it by other means.  For instance, in classical Mac OS, a
>>> 
>>> (Classical Mac OS was styled this way, as opposed to modern macOS, which was named Mac OS X or variants thereof in between.)
>>> 
>>> (4)
>>> 1. Introduction:
>>> OLD:
>>> A common way to identify the type of a file from its contents is to
>>> place a "magic number" at the start of the file contents [MAGIC].  In
>>> the media type registration template [RFC6838], it is noted that a
>>> magic number is asked for, if available, as is a file extension.
>>> NEW:
>>> A common way to identify the type of a file from its contents is to
>>> place a "magic number" at the start of the file contents [MAGIC].  In
>>> the media type registration template [RFC6838], a
>>> magic number is asked for, if available, as is a file extension.
>>> 
>>> (The note is not in 6838, but here — but it is not necessary to phrase this as a note in the introduction.  A “for instance” or some such might be added.)
>>> 
>>> (5)
>>> 1. Introduction:
>>> OLD:
>>> A third method is also proposed by which this CBOR format tag is
>>> NEW:
>>> A third method is also proposed by which a CBOR format tag is
>>> 
>>> (There is no referent for “this” here, and it is not needed either.)
>>> 
>>> (6)
>>> 2.3.1.  Example:
>>> OLD
>>> as assigned for application/missing-blocks+cbor-seq of the "CAP
>>> NEW:
>>> as assigned for application/missing-blocks+cbor-seq of the "CoAP
>>> 
>>> (7)
>>> 3. Security Considerations:
>>> OLD:
>>> of a check versus a use issue.)  For example, end-point assessment
>>> NEW:
>>> of a check versus use issue.)  For example, end-point assessment
>>> 
>>> 
>>> (8)
>>>> - Global s/1668547090/1668574090 (see mail from Carsten dated 19 July 2022)
>>> 
>>> I’m a bit confused here, as the mail dated 2022-07-19 was about the fix s/0x63470101/0x63740101/g in the TN formulae, which has been successfully executed.
>>> 
>>> The value 1668574090 is an incorrect replacement for 1668547090.
>>> This change (5 places) needs to be reverted.
>>> Similar for 1668574250, which needs to revert to 1668547250 (2 places).
>>> 
>>> (9)
>>> 4. IANA Considerations
>>> It is slightly weird that the introduction of 4 introduces Sections 4.1 and 4.3, but not Section 4.2.  Maybe add in between:
>>> 
>>> NEW:
>>> Section 4.2 documents the allocation for a CBOR tag to be used in the CBOR-Labeled Non-CBOR Data Enveloping Method (Appendix D, which also shows examples).
>>> 
>>> (Cross reference the links for Section 4.2 and Appendix D, obviously.)
>>> 
>>> (10)
>>> A.2.  Can many items be trivially concatenated?:
>>> OLD:
>>> The program involved may throw errors or warnings on the Labeled CBOR
>>> Sequence if they have not yet been updated, but this may not be a
>>> NEW:
>>> The programs involved may throw errors or warnings on the Labeled CBOR
>>> Sequence if they have not yet been updated, but this may not be a
>>> 
>>> (Or: A program… if it has not yet…)
>>> 
>>> (11)
>>> Appendix B.  CBOR Tags for CoAP Content Formats:
>>> 
>>> OLD:
>>> together with a content encoding.
>>> NEW:
>>> together with a content coding (see Section 8.4.1 of [RFC9110]).
>>> 
>>> (And add RFC 9110, which has since been published, to the informative references.)
>>> 
>>> (12)
>>> OLD:
>>> Tags 55800 (Section 2.3) or 55801 (Appendix D):  the byte string
>>>    "BOR", signifying that the representation of the given content-
>>> NEW:
>>> Tags 55800 (Section 2.3) or 55801 (Appendix D):  the byte string
>>>    'BOR', signifying that the representation of the given content-
>>> 
>>> (‘BOR’ is diagnostic notation for a byte string; “BOR” swaps this out confusingly for that of a text string, which is not what this is.)
>>> 
>>> A few more of these:
>>> 
>>> (13)
>>> Appendix D.  Using CBOR Labels for Non-CBOR data
>>> OLD:
>>> 3.  The tag content is a 3-byte CBOR byte string containing
>>>     0x42_4F_52 ("BOR" in diagnostic notation).
>>> NEW:
>>> 3.  The tag content is a 3-byte CBOR byte string containing
>>>     0x42_4F_52 ('BOR' in diagnostic notation).
>>> 
>>> (14)
>>> OLD:
>>> encoded data item for the 3-byte string 0x42_4f_52 ("BOR" in
>>> diagnostic notation).
>>> NEW:
>>> encoded data item for the 3-byte string 0x42_4f_52 ('BOR' in
>>> diagnostic notation).
>>> 
>>> 
>>> Grüße, Carsten
>>> 
>> 
>