Re: [lisp] AD Review of draft-ietf-lisp-pubsub-09

Alvaro Retana <aretana.ietf@gmail.com> Thu, 12 January 2023 19:40 UTC

Return-Path: <aretana.ietf@gmail.com>
X-Original-To: lisp@ietfa.amsl.com
Delivered-To: lisp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 80C1FC15C510; Thu, 12 Jan 2023 11:40:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eY5ypMPlHs4K; Thu, 12 Jan 2023 11:40:48 -0800 (PST)
Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F0934C15AE1D; Thu, 12 Jan 2023 11:40:47 -0800 (PST)
Received: by mail-pj1-x102f.google.com with SMTP id cx21-20020a17090afd9500b00228f2ecc6dbso3158631pjb.0; Thu, 12 Jan 2023 11:40:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=1r9MX3wybAQcwl//N+cP53w5KEeheQucaE1pFpbiEYU=; b=hqcGD9cwHy6R0YU4AXfjR84DWCbyf45Lfg+jFvtsPkaDkgK0M/lAhK+r1vou3nN8Et paYlc1Wu2bQ71gNHWtPzJrxE/QGF1P16Gj1J0SP5BH6LViQWt2H/LVFQKYc8JWoWLLP7 MJL/AuE1b8WSSOR8RAUkQQGmFT+Ko8atkeqL7WJ9v8+8WHOjFr1du9u+2moXuDvmIWmv UKFEHNuVqip3KqAqDF6cvXSuC4VjGKGJzKNstT6tRF4MIEDSjt1reMcFjN6YhdSLGFRd RHY79qsYhFYks5QZyCF/hMkpdMZZJAmfEnFNNfW6cL2aA7BYnih8hXbWwlCbB0kspbis XmlQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1r9MX3wybAQcwl//N+cP53w5KEeheQucaE1pFpbiEYU=; b=k5sZYDGTNNPmwMAadiWKBllLqEEu3hPwTAfTx3XrxxKkrJJDZG+Bz+NIWHL11ydVqC jTtEmh41sj7v3G8qFrA5e1u4S4NBCdNEWYsD86m/M9aIl8TWzGklstYDLz2tVJ4DAHJB 9kh5GSyx7UXU35yXGnPoC+34xTKVpRIZ5XESRv2T91TborFpAzg9mtRpiEU8MVeX/mgA rbNiuZ5wnA9gJFp83xLxQl4WG9VPsHIMH9Y0pWzOJutAw5x+im2SLHT4FGyWiW49CisI urhXCdalz+QfUclAvZ7e37bszpZkUwfq6R8yzliV5ep5bw28oiUFze2JHsYj5ALV239W lq0Q==
X-Gm-Message-State: AFqh2krLs+ZeAn19tLrJhody8uaQQyutGl30fXXQwPJx8iOsN0IPEmYj ZAD2N6rVSyDIDmjhPgvjiUxHI6X3wqqM1mG/eQQ=
X-Google-Smtp-Source: AMrXdXuzI+7EFEXGuz/Rm4luInyNqsJLAnTUX8HeQnyim+WddxZXThISh13rELCtCx4QAsYOY5xW6FAoErEqaXUJfGA=
X-Received: by 2002:a17:90a:4703:b0:227:537:bb81 with SMTP id h3-20020a17090a470300b002270537bb81mr2254555pjg.186.1673552447409; Thu, 12 Jan 2023 11:40:47 -0800 (PST)
Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Thu, 12 Jan 2023 13:40:46 -0600
From: Alvaro Retana <aretana.ietf@gmail.com>
In-Reply-To: <BN8PR11MB3588A92BEE89699E39F6503DB63D9@BN8PR11MB3588.namprd11.prod.outlook.com>
References: <CAMMESsyB6WXxZP-CxQ6xzYQ6rRC86TQPT+PDqc3+qvR364qdCw@mail.gmail.com> <BYAPR11MB3591E2378CCEA32D8697F002B62E9@BYAPR11MB3591.namprd11.prod.outlook.com> <BN8PR11MB3588A92BEE89699E39F6503DB63D9@BN8PR11MB3588.namprd11.prod.outlook.com>
MIME-Version: 1.0
Date: Thu, 12 Jan 2023 13:40:46 -0600
Message-ID: <CAMMESswB2VsZOSuhc6TPcnXkQ2WCVHhYhPV-Ug+HCjuSMNgmrg@mail.gmail.com>
To: "Alberto Rodriguez-Natal (natal)" <natal@cisco.com>, "lisp@ietf.org" <lisp@ietf.org>
Cc: Vina Ermagan <ermagan@gmail.com>, "mohamed.boucadair@orange.com" <mohamed.boucadair@orange.com>, "Fabio Maino (fmaino)" <fmaino@cisco.com>, "lisp-chairs@ietf.org" <lisp-chairs@ietf.org>, Dino Farinacci <farinacci@gmail.com>, Luigi Iannone <ggx@gigix.net>, Albert Cabellos <acabello@ac.upc.edu>, Stefano Secci <stefano.secci@cnam.fr>, Johnson Leong <johnsonleong@gmail.com>, JACQUENET Christian INNOV/NET <christian.jacquenet@orange.com>, Sharon Barkai <sharon.barkai@getnexar.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/lisp/5zh-NBeiZYTRs91Ofj2Jlf6OL0M>
Subject: Re: [lisp] AD Review of draft-ietf-lisp-pubsub-09
X-BeenThere: lisp@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: List for the discussion of the Locator/ID Separation Protocol <lisp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lisp>, <mailto:lisp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lisp/>
List-Post: <mailto:lisp@ietf.org>
List-Help: <mailto:lisp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lisp>, <mailto:lisp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jan 2023 19:40:48 -0000

On November 6, 2022 at 5:32:47 AM, Alberto Rodriguez-Natal wrote:


Alberto:

Hi!

I've looked at your replies and the diffs using the version -10.  I
still have a couple of comments in-line -- mostly about the
instructions to the designated experts.

Please move the text in §8 (Sample PubSub Deployment Experiences) to
an appendix and update the reference to rfc6830.

I am starting the IETF Last Call.  I know that you still have to
address Padma's comments -- you can treat them (and mine) as LC
comments.

Thanks!

Alvaro.



...
> > 144 4. Map-Request PubSub Additions
> > ...
> > [major] "MUST set the I bit to 1 and include its xTR-ID and Site-ID"
>
> > What should the receiver do if the I bit is set but the ID fields are
> > not included?
>
> [AR] As per the Alvaro/Dino discussion, we’re adding some text along the
> lines of: “If the I-bit is set but the Site-ID and/or xTR-ID are not
> included, a receiver can detect the error because after processing that last
> EID-record, there are no bytes left from processing the message. The receiver
> will log a malformed Map-Request and drop the message.”

Can we use normative language?  s/will log...and drop/SHOULD log...and MUST drop

I'm also fine if you want to use "MUST" in both cases.



...
> > 296 6. Mapping Notification Publish Procedures
> > ...
> >
> > [major] "If after a configurable timeout, the Map-Server has not
> > received back the Map-Notify-Ack..." §5.7/rfc6833bis talks about
> > exponentially backed-off retransmissions. You shouldn't change the
> > behavior here.
>
> [AR] Please note that 9301 does not talk about trying to send a Map-Notify to
> a different ITR-RLOC, since in 9301 Map-Notifies are not sent to ITR-RLOCs,
> hence the need to define this behavior here.

Yes.  I meant the part about a "configurable timeout" vs the
exponential back-off.



...
> > 482 10. IANA Considerations
...
> > 515 The policy for allocating new bits from this sub-registry is
> > 516 Specification Required (Section 4.6 of [RFC8126]).
> >
> > [major] "Specification Required" required the review of a Designated
> > Expert. Please provide any specific instructions that the DEs should
> > take into account when assigning values from this registry.
> >
...
> NEW:
>
> The policy for allocating new bits from this sub-registry is Specification
> Required (Section 4.6 of [RFC8126]).  It is suggested that multiple
> designated experts be appointed for registry change requests.

The second sentence is not needed; the IESG always assigns a couple of DEs.


> Criteria that should be applied by the designated experts include
> determining whether the proposed registration duplicates existing entries
> and whether the registration description is clear and fits the purpose of
> this registry. These criteria are considered in addition to those already
> provided in Section 4.6 of [RFC8126] (e.g., the proposed registration must
> be documented in a permanent and readily available public specification).
> Registration requests are evaluated within a three-week review
> period on the advice of one or more designated experts. Within the review
> period, the designated experts will either approve or deny the
> registration request, communicating this decision to IANA. Denials
> should include an explanation and, if applicable, suggestions as to how to
> make the request successful.

How should the DE determine if "the registration description is
clear"?  Is there any required information that the request should
have?  Clarity is subjective and may change from one DE to the next.

I don't think that including a timeframe for evaluation ("three-week
review period") is a good idea.  Not only delays can occur, but IANA
already has a practice of following up within a two-week window -- so
an exception would just be more work for them.

If there is something that the DEs should be doing during the
evaluation time, please indicate so.  Some registries ask the DEs to
at least ping the WG -- note that this doesn't mean that the
documentation has to be a WG draft (or even a draft at all), unless
that is what you want.  Specification Required allows anyone to
request a codepoint without going through the IETF.