Re: [quicwg/base-drafts] VarInt all the HTTP things (#2437)

[Christian Huitema <[e-mail]>]

huitema commented on this pull request.

The use of reserved values is a bit loose; what about `0x1f * N` when `N=0`? Apart from that, looks fine.

> @@ -881,12 +885,12 @@ the DUPLICATE_PUSH.
 
 ### Reserved Frame Types {#frame-grease}
 
-Frame types of the format `0xb + (0x1f * N)` are reserved to exercise the
-requirement that unknown types be ignored ({{extensions}}). These frames have no
-semantic value, and can be sent when application-layer padding is desired. They
-MAY also be sent on connections where no request data is currently being
-transferred. Endpoints MUST NOT consider these frames to have any meaning upon
-receipt.
+Frame types of the format `0x1f * N` for non-zero values of N are reserved to
+exercise the requirement that unknown types be ignored ({{extensions}}). These
+frames have no semantic value, and can be sent when application-layer padding is
+desired. They MAY also be sent on connections where no request data is currently
+being transferred. Endpoints MUST NOT consider these frames to have any meaning
+upon receipt.
 

When you write  `0x1f * N` , is 0 a valid value of N?

> @@ -384,11 +385,12 @@ client MUST treat this as a connection error of type HTTP_DUPLICATE_PUSH.
 
 ### Reserved Stream Types {#stream-grease}
 
-Stream types of the format `0x1f * N` are reserved to exercise the requirement
-that unknown types be ignored. These streams have no semantic meaning, and can
-be sent when application-layer padding is desired.  They MAY also be sent on
-connections where no request data is currently being transferred. Endpoints MUST
-NOT consider these streams to have any meaning upon receipt.
+Stream types of the format `0x1f * N` for non-zero values of N are reserved to
+exercise the requirement that unknown types be ignored. These streams have no
+semantic meaning, and can be sent when application-layer padding is desired.
+They MAY also be sent on connections where no request data is currently being
+transferred. Endpoints MUST NOT consider these streams to have any meaning upon
+receipt.
 

What if `N=0` in `0x1f * N`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2437#pullrequestreview-201393225