IETF Logo Mail Archive

Re: [quicwg/base-drafts] VarInt all the HTTP things (#2437)

Lucas Pardue <notifications@github.com> Mon, 11 February 2019 00:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9B7801295D8 for <quic-issues@ietfa.amsl.com>; Sun, 10 Feb 2019 16:12:54 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fCDRm9Kkveel for <quic-issues@ietfa.amsl.com>; Sun, 10 Feb 2019 16:12:53 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 01D63129284 for <quic-issues@ietf.org>; Sun, 10 Feb 2019 16:12:53 -0800 (PST)
Date: Sun, 10 Feb 2019 16:12:51 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549843971; bh=4wS8gL0qMD+1x9Iudo/L5TxUnitMXSUrQEJG+N6tWPo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=tXTiZTvewLSb7amv5s8StcwNlMFjf5htnaDs1CQJlvbYx2L02Q79el+OUu8aAcmYm stivNPhJdl3ej9Ehdt4DLIsd1t2PS/pGHMsx2zMsq+TcwRx70ehsvTLltbrOKSZ7zj YzefcEsOwxbqgoXHjBFaqQCXYfz0Ai5PZEqoQlCw=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd5531bc9b9a45de0e384b104b523264a0025b43792cf000000011878800392a169ce1850d58f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2437/review/201931142@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2437@github.com>
References: <quicwg/base-drafts/pull/2437@github.com>
Subject: Re: [quicwg/base-drafts] VarInt all the HTTP things (#2437)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c60be03ea24f_74e83f9a1d0d45c0211455"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lf3XBbZQxWPRliDpppa5daadP28>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Feb 2019 00:12:55 -0000

LPardue commented on this pull request.



> @@ -303,15 +303,16 @@ specify a value of zero for the QUIC transport parameter
 ## Unidirectional Streams
 
 Unidirectional streams, in either direction, are used for a range of purposes.
-The purpose is indicated by a stream type, which is sent as a single byte header
-at the start of the stream. The format and structure of data that follows this
-header is determined by the stream type.
+The purpose is indicated by a stream type, which is sent as a variable-length
+integer at the start of the stream. The format and structure of data that

"this header" is now "this integer" on line 308

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2437#discussion_r255364310

v2.23.0 | Report a Bug | By Email