Re: [quicwg/base-drafts] VarInt all the HTTP things (#2437)

Dmitri Tikhonov <> Fri, 08 February 2019 04:16 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id A9089130F24 for <>; Thu, 7 Feb 2019 20:16:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id 5yvj-XzqRdxx for <>; Thu, 7 Feb 2019 20:16:20 -0800 (PST)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 8D117130F23 for <>; Thu, 7 Feb 2019 20:16:20 -0800 (PST)
Date: Thu, 07 Feb 2019 20:16:19 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1549599379; bh=p14sHxc6MWeLrno2DiSa+T04837gx7otKesSKW77jzM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=XYpyqxsvynTxfBBmG6Rq7jlFJa2QDORxdVdSfFbXrt2rDfCQIjMAFW7RZ0zk2vano EJqi5hN6ZaKd2F6wTO+28xTcW6tOgUMUBqy5Ni80m1eYT19+VZVnHwAcXJo38PfQIc 3g6YpDfLCq8D6bSnAmYYVfzXf7j29Gcfimp+7liE=
From: Dmitri Tikhonov <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2437/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] VarInt all the HTTP things (#2437)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5d0293555b8_2ae83ff107ad45c015838c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Fri, 08 Feb 2019 04:16:23 -0000

dtikhonov requested changes on this pull request.

> @@ -373,7 +374,7 @@ MUST be treated as a stream error of type HTTP_WRONG_STREAM_DIRECTION.
  0                   1                   2                   3
  0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
-|Stream Type (8)|                  Push ID (i)                ...
+|    0x01 (8)   |                  Push ID (i)                ...

The `(8)` suggests that this is an octet, whereas the stream type is a varint.  I'd make this figure use the same format as _fig-stream-header_.

> @@ -384,11 +385,12 @@ client MUST treat this as a connection error of type HTTP_DUPLICATE_PUSH.
 ### Reserved Stream Types {#stream-grease}
-Stream types of the format `0x1f * N` are reserved to exercise the requirement
-that unknown types be ignored. These streams have no semantic meaning, and can
-be sent when application-layer padding is desired.  They MAY also be sent on
-connections where no request data is currently being transferred. Endpoints MUST
-NOT consider these streams to have any meaning upon receipt.
+Stream types of the format `0x1f * N` for non-zero values of N are reserved to
+exercise the requirement that unknown types be ignored. These streams have no
+semantic meaning, and can be sent when application-layer padding is desired.

"Semantic meaning" sounds like a tautology.

(This formulation is not introduced in this change, but I figured I'd highlight it while I am at it.)

> @@ -671,14 +673,16 @@ treat the presence of the same parameter more than once as a connection error of
 The payload of a SETTINGS frame consists of zero or more parameters, each
-consisting of an unsigned 16-bit setting identifier and a value which uses the
+consisting of a setting identifier and a value, each of which uses the

I'd put it as "...identifier and a value, each encoded as a QUIC variable-length integer," simply because I don't see how the identifier and the value _use_ the encoding.

(Again, this is not a new thing in this change, but simply something I've noticed.)

> @@ -1824,7 +1815,9 @@ CONTINUATION (0x9):
 Frame types defined by extensions to HTTP/2 need to be separately registered for
 HTTP/3 if still applicable.  The IDs of frames defined in {{!RFC7540}} have been
-reserved for simplicity.  See {{iana-frames}}.
+reserved for simplicity.  Note that the frame type space in HTTP/3 is
+substantially larger (62 bits versus 8 bits), so many HTTP/3 frame types have no
+equivalent HTTP/2 code point.   See {{iana-frames}}.

Number agreement: `s/point/points/`

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: