Re: [quicwg/base-drafts] VarInt all the HTTP things (#2437)

[Dmitri Tikhonov <[e-mail]>]

dtikhonov requested changes on this pull request.



> @@ -373,7 +374,7 @@ MUST be treated as a stream error of type HTTP_WRONG_STREAM_DIRECTION.
  0                   1                   2                   3
  0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
-|Stream Type (8)|                  Push ID (i)                ...
+|    0x01 (8)   |                  Push ID (i)                ...

The `(8)` suggests that this is an octet, whereas the stream type is a varint.  I'd make this figure use the same format as _fig-stream-header_.

> @@ -384,11 +385,12 @@ client MUST treat this as a connection error of type HTTP_DUPLICATE_PUSH.
 
 ### Reserved Stream Types {#stream-grease}
 
-Stream types of the format `0x1f * N` are reserved to exercise the requirement
-that unknown types be ignored. These streams have no semantic meaning, and can
-be sent when application-layer padding is desired.  They MAY also be sent on
-connections where no request data is currently being transferred. Endpoints MUST
-NOT consider these streams to have any meaning upon receipt.
+Stream types of the format `0x1f * N` for non-zero values of N are reserved to
+exercise the requirement that unknown types be ignored. These streams have no
+semantic meaning, and can be sent when application-layer padding is desired.

"Semantic meaning" sounds like a tautology.

(This formulation is not introduced in this change, but I figured I'd highlight it while I am at it.)

> @@ -671,14 +673,16 @@ treat the presence of the same parameter more than once as a connection error of
 type HTTP_MALFORMED_FRAME.
 
 The payload of a SETTINGS frame consists of zero or more parameters, each
-consisting of an unsigned 16-bit setting identifier and a value which uses the
+consisting of a setting identifier and a value, each of which uses the

I'd put it as "...identifier and a value, each encoded as a QUIC variable-length integer," simply because I don't see how the identifier and the value _use_ the encoding.

(Again, this is not a new thing in this change, but simply something I've noticed.)

> @@ -1824,7 +1815,9 @@ CONTINUATION (0x9):
 
 Frame types defined by extensions to HTTP/2 need to be separately registered for
 HTTP/3 if still applicable.  The IDs of frames defined in {{!RFC7540}} have been
-reserved for simplicity.  See {{iana-frames}}.
+reserved for simplicity.  Note that the frame type space in HTTP/3 is
+substantially larger (62 bits versus 8 bits), so many HTTP/3 frame types have no
+equivalent HTTP/2 code point.   See {{iana-frames}}.

Number agreement: `s/point/points/`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2437#pullrequestreview-201425291