IETF Logo Mail Archive

Re: [quicwg/base-drafts] VarInt all the HTTP things (#2437)

ianswett <notifications@github.com> Fri, 08 February 2019 16:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0EADD12867A for <quic-issues@ietfa.amsl.com>; Fri, 8 Feb 2019 08:39:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3fPlEqDDOuus for <quic-issues@ietfa.amsl.com>; Fri, 8 Feb 2019 08:39:23 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 26D47127598 for <quic-issues@ietf.org>; Fri, 8 Feb 2019 08:39:23 -0800 (PST)
Date: Fri, 08 Feb 2019 08:39:21 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549643961; bh=yMA5WRpbLuHdtgSMPxklf9YLMwCV/GGsX2fDJkH5u3g=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=l+3muzi42GScKs3Mok3HdCotk9vTc393Y3x0BSITjnGrMdKXWtPA9dC2PE/z6CsPI bGsnnoiSBt0zoN7KAIGux+minAZiMPLJ3rTfX+fIrIcKuXjIIj+rm8lA0FWfTj39dy Q4OFZZxjNuKIJbUNn74nfnOGDwKdJ+ja8E8D24Cg=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab523b86cec225571081ad2e9ff04873ba756a6c7f92cf00000001187572b992a169ce1850d58f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2437/review/201673543@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2437@github.com>
References: <quicwg/base-drafts/pull/2437@github.com>
Subject: Re: [quicwg/base-drafts] VarInt all the HTTP things (#2437)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5db0b9cbaff_27c93f7e0b6d45c0242598"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pblkU0azO3soHqC8vyV5xdirnys>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Feb 2019 16:39:25 -0000

ianswett commented on this pull request.



> @@ -303,15 +303,16 @@ specify a value of zero for the QUIC transport parameter
 ## Unidirectional Streams
 
 Unidirectional streams, in either direction, are used for a range of purposes.
-The purpose is indicated by a stream type, which is sent as a single byte header
-at the start of the stream. The format and structure of data that follows this
-header is determined by the stream type.
+The purpose is indicated by a stream type, which is sent as a variable-length
+integer at the start of the stream. The format and structure of data that
+follows this header is determined by the stream type.

```suggestion
follows this integer is determined by the stream type.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2437#pullrequestreview-201673543

v2.23.0 | Report a Bug | By Email