IETF Logo Mail Archive

Re: [quicwg/base-drafts] VarInt all the HTTP things (#2437)

Christian Huitema <notifications@github.com> Fri, 08 February 2019 00:59 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BBD851286E7 for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 16:59:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A7U3ideiF4am for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 16:59:33 -0800 (PST)
Received: from out-9.smtp.github.com (out-9.smtp.github.com [192.30.254.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 77626128B14 for <quic-issues@ietf.org>; Thu, 7 Feb 2019 16:59:32 -0800 (PST)
Date: Thu, 07 Feb 2019 16:59:31 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549587571; bh=yRtZPe/CGx7zSSqvafKO0cYZ7brMfcUI8nlceKJDJNw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=WAESAeoZX/CdGj0zjVMMomRjpoDx/p0lrrwB8ew6zpCr8SPe4K0+eEmHK9t9yFI53 MGOD2TCo19ml8kZcGKgA8oybHJYllUMao+/pSor4Bvw/25V/ZPSoNPY/eA6ubr/6qj mPpPSqXtcZ1aw/jbhOM9JoLdbbTAZvr7uRj317+s=
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abdaba69bcb0df5a8f4409c39233d6ef7b78bc4e4192cf000000011874967392a169ce1850d58f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2437/review/201395017@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2437@github.com>
References: <quicwg/base-drafts/pull/2437@github.com>
Subject: Re: [quicwg/base-drafts] VarInt all the HTTP things (#2437)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5cd473c4562_17303fc6a06d45c41496e9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: huitema
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/XJHwDgXgT3sCJ_dEyWrpa2MUJoA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Feb 2019 00:59:35 -0000

huitema commented on this pull request.

My previous comments are addressed by the  "non zero values of N" fix.

> @@ -384,11 +385,12 @@ client MUST treat this as a connection error of type HTTP_DUPLICATE_PUSH.
 
 ### Reserved Stream Types {#stream-grease}
 
-Stream types of the format `0x1f * N` are reserved to exercise the requirement
-that unknown types be ignored. These streams have no semantic meaning, and can
-be sent when application-layer padding is desired.  They MAY also be sent on
-connections where no request data is currently being transferred. Endpoints MUST
-NOT consider these streams to have any meaning upon receipt.
+Stream types of the format `0x1f * N` for non-zero values of N are reserved to
+exercise the requirement that unknown types be ignored. These streams have no
+semantic meaning, and can be sent when application-layer padding is desired.
+They MAY also be sent on connections where no request data is currently being
+transferred. Endpoints MUST NOT consider these streams to have any meaning upon
+receipt.
 

Oh, this is addressed by the "non zero values of N" fix.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2437#pullrequestreview-201395017

v2.23.0 | Report a Bug | By Email