Re: [quicwg/base-drafts] compensation of ack_delay is fragile against errors (#2060)

Kazuho Oku <notifications@github.com> Fri, 30 November 2018 22:38 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E5E111310B1 for <quic-issues@ietfa.amsl.com>; Fri, 30 Nov 2018 14:38:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.46
X-Spam-Level:
X-Spam-Status: No, score=-4.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TIDDnz-fTPCe for <quic-issues@ietfa.amsl.com>; Fri, 30 Nov 2018 14:38:15 -0800 (PST)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D19FD130EC8 for <quic-issues@ietf.org>; Fri, 30 Nov 2018 14:38:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=nddUcBlXk92TD0eZGY/MZKKSrXg=; b=gc6lfSo8SKpstZi5 qqytmkqzfDToxV+LjFgSC1d+DHXnYGAg/I2z7IL8iijYMt1dSG7sb2uLU43GXQyj N6D7F7UZjcR6V9ZewI0VopKvR/ZjDZKwWJmDxm5PNMUf5wxA8TaGYgu7lpUaMq/k z7ukVEt5ewe5miA3RjNgnX3HERA=
Received: by filter0051p1iad2.sendgrid.net with SMTP id filter0051p1iad2-18608-5C01BBD5-29 2018-11-30 22:38:13.920786906 +0000 UTC m=+623063.335170517
Received: from github-lowworker-c7d2ff2.cp1-iad.github.net (unknown [192.30.252.32]) by ismtpd0013p1iad1.sendgrid.net (SG) with ESMTP id rw8ruw6lRa2wLmVvWT1zAg for <quic-issues@ietf.org>; Fri, 30 Nov 2018 22:38:13.703 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-c7d2ff2.cp1-iad.github.net (Postfix) with ESMTP id A83834C0279 for <quic-issues@ietf.org>; Fri, 30 Nov 2018 14:38:13 -0800 (PST)
Date: Fri, 30 Nov 2018 22:38:13 +0000
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3f3108f36fc06efffdb999fd557db4f7fc6bb6aa92cf0000000118197dd592a169ce16f4226e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2060/443360997@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2060@github.com>
References: <quicwg/base-drafts/issues/2060@github.com>
Subject: Re: [quicwg/base-drafts] compensation of ack_delay is fragile against errors (#2060)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c01bbd5a4f8f_19ba3f889b4d45b41452a2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak31o/GSXKlE/eSFY1Leo5unVIqz29fnt4ThkC k7OwPo2ec/ApxKVDEtRy9Wj3cEh05OcLC6l8sTC2U6kYugatrSjS2CWRbOeG/vGU2j/TPwxHxjFelg eQYtcM9UcpGH45yMkux02ahWoW3xVrGKJ7OFb7qc99g9sDFOuC58S31Oc3YeU90yrb1pgv2C7aOXRq k=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/DtKz_OdX5KOzadQfS6no_ChgCOI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Nov 2018 22:38:18 -0000

@ianswett 
> @kazuho up above you were concerned about a 10 second RTT sample due to bundling an ACK of an ACK. That should not be an issue because only when the largest acked is a retransmittable packet should an RTT sample taken.
> 
> But now that I look at the text and pseudocode, the retransmittable qualification is missing, so I'll writeup a PR to fix that.

Thank you for the clarification and the PR. They make me less worried about the issue :-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2060#issuecomment-443360997