Re: [quicwg/base-drafts] compensation of ack_delay is fragile against errors (#2060)
ianswett <notifications@github.com> Fri, 30 November 2018 14:06 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 05B0B1200B3 for <quic-issues@ietfa.amsl.com>; Fri, 30 Nov 2018 06:06:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xPu1m97qIf_r for <quic-issues@ietfa.amsl.com>; Fri, 30 Nov 2018 06:06:47 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3B33F123FFD for <quic-issues@ietf.org>; Fri, 30 Nov 2018 06:06:47 -0800 (PST)
Date: Fri, 30 Nov 2018 06:06:46 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543586806; bh=GkHeeP2of1VBgAJFjQ1v5litgvs+lMvKt8OfJjccjKY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Ao9ijPSsr5wlnZnYjFCrSUZ7zm57xKAX4oNg5SRdauuyMt85bkyz0uSUQLRavUn0c KjXPvGJNYRbamo2+ZEGaFbPoAe485z8VNPfJL+/0aWVRSDyaYnuOSxngP6FV4u0A69 sxTa+fxtMWtzyD2yO4vDamXgd+XLPIRoOBrKPMJo=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4f76679acc1c34425f2f3617b9ee03c783adbddc92cf00000001181905f692a169ce16f4226e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2060/443213389@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2060@github.com>
References: <quicwg/base-drafts/issues/2060@github.com>
Subject: Re: [quicwg/base-drafts] compensation of ack_delay is fragile against errors (#2060)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c0143f6373de_3e543fb0ed6d45c4627e4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/OxKrBxfgpe8NRGp_qgBieFHinYg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Nov 2018 14:06:49 -0000
Yes, those are the two issues, and they're somewhat separate. For 1, I'm concerned we could ignore samples for a long time under some circumstances. If the RTT is 25ms and a connection is always sending 1 packet and hitting the delayed ack timer, then the min_rtt will be 50ms, not 25ms. And I believe ignoring SRTT samples that are less than min_rtt would result in ignoring every SRTT sample until an immediate ack was sent. Admittedly, we say to ACK crypto packets immediately, but if one used a 1ms timer as 'immediate', I think the same problem results? For 2, I think putting it into SRTT is the natural thing. Adding another EWMA doesn't seem worthwhile, and in most cases it is very similar to incorporating it into SRTT. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/2060#issuecomment-443213389
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- [quicwg/base-drafts] compensation of ack_delay is… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… Martin Thomson
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… Martin Thomson
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… Martin Thomson
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… Martin Thomson
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… Dmitri Tikhonov
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett