Re: [quicwg/base-drafts] introduce a max_connection_ids transport parameter (#1998)

janaiyengar <notifications@github.com> Fri, 21 December 2018 20:52 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BAEE1130E64 for <quic-issues@ietfa.amsl.com>; Fri, 21 Dec 2018 12:52:28 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.064
X-Spam-Level:
X-Spam-Status: No, score=-3.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P6ghQcO9NVnt for <quic-issues@ietfa.amsl.com>; Fri, 21 Dec 2018 12:52:27 -0800 (PST)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B4E19129BBF for <quic-issues@ietf.org>; Fri, 21 Dec 2018 12:52:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=rDPqBw8DW/a1zVenkl3AIgIsDEE=; b=a141ETN5zQGvP59R KZhDIH0JhCc+X5v8qishU+nmqOGbgWm8nNEoOmTKt5XVIkEGiOxUE8j+aaIpi/Gp npHTRIogyx42ty9Cuk1AAS3pPw0iTZvIMvxHENm39hs5AcUbVey/8FZKfkLY4hK6 MaNnuQQTr42gy5ItckNlYiXW4Fs=
Received: by filter0115p1iad2.sendgrid.net with SMTP id filter0115p1iad2-2078-5C1D5289-27 2018-12-21 20:52:25.706480545 +0000 UTC m=+354653.145513990
Received: from github-lowworker-c7d2ff2.cp1-iad.github.net (unknown [192.30.252.32]) by ismtpd0017p1iad1.sendgrid.net (SG) with ESMTP id QwpipKKlRhWBvGoXTh4grA for <quic-issues@ietf.org>; Fri, 21 Dec 2018 20:52:25.616 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-c7d2ff2.cp1-iad.github.net (Postfix) with ESMTP id 947A84C0369 for <quic-issues@ietf.org>; Fri, 21 Dec 2018 12:52:25 -0800 (PST)
Date: Fri, 21 Dec 2018 20:52:25 +0000 (UTC)
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9b218d2dd704c85753423d2e5af22b210d7dc46192cf000000011835148992a169ce16a7e5d6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1998/review/187535320@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1998@github.com>
References: <quicwg/base-drafts/pull/1998@github.com>
Subject: Re: [quicwg/base-drafts] introduce a max_connection_ids transport parameter (#1998)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1d52899295a_20e73ff5c94d45b4123195"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0RQeZjW5YUhquicCIWobFDJDjrI+Ixr7rFM7 idznChIO1GpQDLajshsCS6FLMnWy5JIeTIimjyBhNWtV9lQN0HjVbhzOEaV5MDxn8oWtIAUV2rrydx K4pSLk9ISR/1sGg28UZOGPje0eFDoytMEUIZPrbkm+95Z704Bfgoy04DuUODsZtefwp3QXQyQBBdhW c=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/EhWjQFePJOS5PAU6SYObMS1D2-U>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2018 20:52:29 -0000

janaiyengar commented on this pull request.



> @@ -3981,6 +3979,12 @@ A client MUST NOT include an original connection ID, a stateless reset token, or
 a preferred address.  A server MUST treat receipt of any of these transport
 parameters as a connection error of type TRANSPORT_PARAMETER_ERROR.
 
+max_connection_ids (0x000e):
+
+: The maximum number of connection IDs that the peer is willing to store.
+  This value includes only connection IDs sent in NEW_CONNECTION_ID frames.

@kazuho: I think that's fair, and I'm ok with not closing the connection if a peer violates my max_connection_id. We need to be clear that an endpoint that drops a NEW_CID because it has no space MUST NOT send a RETIRE_CID. This is an easy bug, so it's worth noting.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1998#discussion_r243689601