Re: [quicwg/base-drafts] introduce a max_connection_ids transport parameter (#1998)

Christian Huitema <notifications@github.com> Thu, 07 February 2019 20:49 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B7814130E6F for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 12:49:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.001
X-Spam-Level:
X-Spam-Status: No, score=-3.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oh_BVLzWrMNw for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 12:49:14 -0800 (PST)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 89EBC130E6C for <quic-issues@ietf.org>; Thu, 7 Feb 2019 12:49:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=Wvr0uh0ZvVJfBt6aJW7Zcn1UR9s=; b=wAz/qiUX+Pgn4ahw Ms4R9X0gsPC6ILuqMrdphaj9hj0xCciC99bNyKzgmqO0al7x1wVnYEPHZ5DN/Bto dUWPaIHPRbhVDd2y8nQP1U1y5Ace7ll45zqe3c2xWW6awjw62y0bxJBWW9WUS0VZ ziwbq3nAfbepvSmRR1O0F5cnTQ4=
Received: by filter1789p1mdw1.sendgrid.net with SMTP id filter1789p1mdw1-31814-5C5C99C8-18 2019-02-07 20:49:12.453541286 +0000 UTC m=+171620.913269127
Received: from github-lowworker-e51511d.cp1-iad.github.net (unknown [192.30.252.34]) by ismtpd0005p1iad1.sendgrid.net (SG) with ESMTP id L4Y8duwnRniCKRnJzArMMg for <quic-issues@ietf.org>; Thu, 07 Feb 2019 20:49:12.451 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e51511d.cp1-iad.github.net (Postfix) with ESMTP id 6C5D180032 for <quic-issues@ietf.org>; Thu, 7 Feb 2019 12:49:12 -0800 (PST)
Date: Thu, 07 Feb 2019 20:49:12 +0000 (UTC)
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7dd369f005ad9848375e0b4b2b6964b4b3eab44a92cf0000000118745bc892a169ce16a7e5d6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1998/review/201316137@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1998@github.com>
References: <quicwg/base-drafts/pull/1998@github.com>
Subject: Re: [quicwg/base-drafts] introduce a max_connection_ids transport parameter (#1998)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5c99c86ad3c_36b33fa6636d45b810090"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: huitema
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0ohQLg3ujWVH5VsXcJKVIIwJr9iw/iCexU7B 5HwDJRk9nnWFcBq8zb9nI4QTlmYmvhBaP2PdrtZrq9rp0wVaMccoBVRbbwwXeodccW5exg3Khxp+7u Z5VTPpI8tt4g1u3jqcp6GOhtS7x1n5fSwK0/JNgjuxpBUyocpBtPP2t0kZj1Cn6so2LdNTcgZPcLY0 s=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5I9UNTHmqFEj35VBareBxEz-UCQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Feb 2019 20:49:17 -0000

huitema commented on this pull request.



> @@ -3981,6 +3979,12 @@ A client MUST NOT include an original connection ID, a stateless reset token, or
 a preferred address.  A server MUST treat receipt of any of these transport
 parameters as a connection error of type TRANSPORT_PARAMETER_ERROR.
 
+max_connection_ids (0x000e):
+
+: The maximum number of connection IDs that the peer is willing to store.
+  This value includes only connection IDs sent in NEW_CONNECTION_ID frames.

@MikeBishop yes indeed, the server always sends at least 1 CID, so a limit of 0 appears to break. But this is easily worked around by only applying the test to NCID frames. This is easier than special-casing the handling of CID[0] and CID[1]/SPA. In particular, the logic for handling RETIRE_CID and creation of new NCID becomes much simpler.

As I mentioned before, a default of 0 does not work very well, because the default for migration disabled is also 0 -- yet enabling migration without any NCID would be a protocol violation. The default should be at least 2 (initial and SPA), and I would prefer 3.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1998#discussion_r254862789