IETF Logo Mail Archive

Re: [quicwg/base-drafts] Include handshake anti-deadlock logic in pseudocode (#2281)

Martin Thomson <notifications@github.com> Thu, 04 April 2019 09:26 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EC524120470 for <quic-issues@ietfa.amsl.com>; Thu, 4 Apr 2019 02:26:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.383
X-Spam-Level:
X-Spam-Status: No, score=-1.383 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GbFG6PxccEZi for <quic-issues@ietfa.amsl.com>; Thu, 4 Apr 2019 02:26:44 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BE6D61203FB for <quic-issues@ietf.org>; Thu, 4 Apr 2019 02:26:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=Esurmn1elsl9Hh/N+mFxF8zmWw0=; b=LHfHT7v2HczciaXt Pwnmq/sBH+/TxbJQNogKvIt8+N3pGMFWbqYmEKW2tUkgb3aPKWgPFp1wK2bE0c1X X+JlZ0hk7bs/OUG7Q9nw+LtGbAjAKlNcurFUjm/ustgb7WW02D7d4yZcBba6a1sV y7/5xhMDiXSNHBc7oWfG9xfs1aU=
Received: by filter0824p1las1.sendgrid.net with SMTP id filter0824p1las1-25220-5CA5CDD2-2 2019-04-04 09:26:42.07401253 +0000 UTC m=+471389.291759129
Received: from github-lowworker-3c598a3.cp1-iad.github.net (unknown [192.30.252.43]) by ismtpd0036p1iad1.sendgrid.net (SG) with ESMTP id 89tsoLjIQfaKpo6KgPXwug for <quic-issues@ietf.org>; Thu, 04 Apr 2019 09:26:42.023 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-3c598a3.cp1-iad.github.net (Postfix) with ESMTP id 040DEA80B0D for <quic-issues@ietf.org>; Thu, 4 Apr 2019 02:26:42 -0700 (PDT)
Date: Thu, 04 Apr 2019 09:26:42 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0016b5b1c25ffaa29aa7857d7b7462897f29437592cf0000000118bd8fd292a169ce178befb2@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2281/review/222649175@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2281@github.com>
References: <quicwg/base-drafts/pull/2281@github.com>
Subject: Re: [quicwg/base-drafts] Include handshake anti-deadlock logic in pseudocode (#2281)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ca5cdd228ec_262c3ff8734d45bc291f1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak02WHURsNG6bIel85SXafV7gknrmKIVY7dkP2 iPlLlwnCYz4DDB4vwYiX07K6lPgD6BZW3T2IsSXKGAhROclsPzoXepcFDEolGVaB2o+H4s+BLw4swD cTMM70IzScHq+5K9/zK6nvaIuLuvgtr16v/xkKtvwJIDEpijn6xzusWr4sSK2AdomqKUt2V2Z1t2TI Q=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_HPmfL3GeNrxVjXgff87AG0cuS8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Apr 2019 09:26:45 -0000

martinthomson commented on this pull request.



>      // Crypto retransmission timeout.
     RetransmitUnackedCryptoData()
     crypto_count++
+  else if (endpoint is client without 1-RTT keys):
+    if (will send Initial packet):

"Will send Initial packet" is correct.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2281#discussion_r272092316

v2.23.0 | Report a Bug | By Email