IETF Logo Mail Archive

Re: [quicwg/base-drafts] Include handshake anti-deadlock logic in pseudocode (#2281)

Jana Iyengar <notifications@github.com> Mon, 08 April 2019 21:49 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 815EA12034D for <quic-issues@ietfa.amsl.com>; Mon, 8 Apr 2019 14:49:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3
X-Spam-Level:
X-Spam-Status: No, score=-3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r6chBxhAyvQ5 for <quic-issues@ietfa.amsl.com>; Mon, 8 Apr 2019 14:49:42 -0700 (PDT)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0660C12008D for <quic-issues@ietf.org>; Mon, 8 Apr 2019 14:49:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=A4vy3Z+rfPgK/QpIDsvzFLiCCZI=; b=mvcrZC4Yxi7/D9SE h424iucybkW9ectiqae57nUxFDekwhtyurNjbPxhgDT+64POPiSN9iD7pWuwTF4A 92cV1Ey4I3/tMAhSWCSXSHaZVJOVGJMjaojTOWpc4w/vcAUM6QX5yThXnCsJQK9m Du69mp0Qx/Xd4Q4cznHuomhHQPw=
Received: by filter0977p1las1.sendgrid.net with SMTP id filter0977p1las1-7935-5CABC1F5-B 2019-04-08 21:49:41.351953379 +0000 UTC m=+254953.744591414
Received: from github-lowworker-0c86143.cp1-iad.github.net (unknown [192.30.252.43]) by ismtpd0012p1iad1.sendgrid.net (SG) with ESMTP id -lAdlNTsRsCmlSxxMK4McA for <quic-issues@ietf.org>; Mon, 08 Apr 2019 21:49:41.058 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-0c86143.cp1-iad.github.net (Postfix) with ESMTP id 0B338240085 for <quic-issues@ietf.org>; Mon, 8 Apr 2019 14:49:41 -0700 (PDT)
Date: Mon, 08 Apr 2019 21:49:41 +0000
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba8403dd336ceeb1a61fbf7ce388f43b3fc2898ca92cf0000000118c383f592a169ce178befb2@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2281/review/224104923@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2281@github.com>
References: <quicwg/base-drafts/pull/2281@github.com>
Subject: Re: [quicwg/base-drafts] Include handshake anti-deadlock logic in pseudocode (#2281)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cabc1f591f0_6d073f8398ed45bc114421"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3InZVwvNF6cvKWuRb3+sZofiL1gH5sm0Ydy0 Sq3RqXY7/eifUaT7nc0+cseQ7e56nRCE0pnJWfXOtQj9lFc2CJhxKP4TQpLU0G4ObRI+t4qfxAQbCS KipoqxTMTfK6GGtD+4acRfhnamoRH8emQpJ2i6PKGyDLHRJ1PnYRg61mTFc7O8y2CQbQXe6TRlRiZr g=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xWi8EcaKFSbpY69ZLtf_GsOauyg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Apr 2019 21:49:45 -0000

janaiyengar commented on this pull request.



>      // Crypto retransmission timeout.
     RetransmitUnackedCryptoData()
     crypto_count++
+  else if (endpoint is client without 1-RTT keys):
+    if (will send Initial packet):

@martinthomson: AIUI, you'd remember this better since it was your PR, but wasn't the bit we agreed to remove was about special-casing padding of Initial packets? My reading of @ianswett 's proposed text doesn't contradict that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2281#discussion_r273252767

v2.23.0 | Report a Bug | By Email