Re: [quicwg/base-drafts] Improve language on evictable entries. (#3131)

Dmitri Tikhonov <notifications@github.com> Wed, 12 February 2020 13:58 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2339A12001E for <quic-issues@ietfa.amsl.com>; Wed, 12 Feb 2020 05:58:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FxVfY8gtGWm9 for <quic-issues@ietfa.amsl.com>; Wed, 12 Feb 2020 05:58:01 -0800 (PST)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A727212001A for <quic-issues@ietf.org>; Wed, 12 Feb 2020 05:58:01 -0800 (PST)
Received: from github-lowworker-5825cd4.ac4-iad.github.net (github-lowworker-5825cd4.ac4-iad.github.net [10.52.22.68]) by smtp.github.com (Postfix) with ESMTP id 95DB16A1A4E for <quic-issues@ietf.org>; Wed, 12 Feb 2020 05:58:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581515880; bh=UUoD2CdU0gF/TQzxizxhrcdhU9+P7SJQoBHqmmw630g=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=BDNxFk6o9D4I1RZI8bgW57687yYeX/6KUyx79VYLnb6wZrKW0561TYhIv5QRltDyT uSSazQVjUW2HCK3QxxeAzTqkYCUrxNZ7H3gL9s6IFa83tGHciHAcAVw4L06YaT01Zv AjkVHPD16K3KOYeGX1zo/cEbrdXlaSP+dbUNliD8=
Date: Wed, 12 Feb 2020 05:58:00 -0800
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2PYPHY2LUZRGXU2VF4KE3OREVBNHHB45IJ64@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3131/review/357470249@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3131@github.com>
References: <quicwg/base-drafts/pull/3131@github.com>
Subject: Re: [quicwg/base-drafts] Improve language on evictable entries. (#3131)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e440468865ab_4d2c3fa640acd96c46877d"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uah-hJY4iUD1BZf4R8egp9bvoDM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Feb 2020 13:58:03 -0000

dtikhonov requested changes on this pull request.



>  ### Limits on Dynamic Table Insertions {#blocked-insertion}
 
 Inserting entries into the dynamic table might not be possible if the table
 contains entries which cannot be evicted.
 
 A dynamic table entry cannot be evicted immediately after insertion, even if it
 has never been referenced. Once the insertion of a dynamic table entry has been
-acknowledged and there are no outstanding unacknowledged references to the
-entry, the entry becomes evictable.
+acknowledged and there are no outstanding references to the entry in
+unacknowledged header blocks, the entry becomes evictable.  Note that
+unacknowledged references on the encoder stream do not preclude the eviction of

I don't agree with introducing the concept of "an unacknowledged reference on the encoder stream."  In the current version of the draft (12), the term "unacknowledged reference" always implies a reference from the header block.  In addition, only insertions and header blocks can be acknowledged.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3131#pullrequestreview-357470249